Skip to content

Commit b15cea2

Browse files
authored
hotfix(typescript): some angular setups can't handle .forRoot() retur… (#6689)
* hotfix(typescript): some angular setups can't handle .forRoot() returning just module * 18.1.1 * chore(version): version bumped
1 parent 2c7d6f0 commit b15cea2

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+135
-82
lines changed

apps/ngx-bootstrap-docs/src/assets/css/style.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22
@import "bs-datepicker";
33

44
/* HEADER */
5-
5+
.bs-datepicker-head {
6+
width: 150px;
7+
}
68
header {
79
padding: 10px 50px 10px 30px;
810
height: $header-height;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"version": "18.1.0"
2+
"version": "18.1.1"
33
}

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngx-bootstrap-base",
3-
"version": "18.1.0",
3+
"version": "18.1.1",
44
"license": "MIT",
55
"author": "Dmitriy Shekhovtsov <[email protected]>",
66
"schematics": "./schematics/src/collection.json",

src/accordion/accordion.module.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { NgModule } from '@angular/core';
1+
import { ModuleWithProviders, NgModule } from '@angular/core';
22

33
import { AccordionComponent } from './accordion.component';
44
import { AccordionPanelComponent } from './accordion-group.component';
@@ -9,7 +9,10 @@ import { AccordionPanelComponent } from './accordion-group.component';
99
})
1010
export class AccordionModule {
1111
// @deprecated method not required anymore, will be deleted in v19.0.0
12-
static forRoot() {
13-
return AccordionModule;
12+
static forRoot(): ModuleWithProviders<AccordionModule> {
13+
return {
14+
ngModule: AccordionModule,
15+
providers: []
16+
};
1417
}
1518
}

src/accordion/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngx-bootstrap/accordion",
3-
"version": "18.1.0",
3+
"version": "18.1.1",
44
"author": "Dmitriy Shekhovtsov <[email protected]>",
55
"license": "MIT"
66
}

src/alert/alert.module.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { NgModule } from '@angular/core';
1+
import { ModuleWithProviders, NgModule } from '@angular/core';
22
import { AlertComponent } from './alert.component';
33

44
@NgModule({
@@ -7,7 +7,10 @@ import { AlertComponent } from './alert.component';
77
})
88
export class AlertModule {
99
// @deprecated method not required anymore, will be deleted in v19.0.0
10-
static forRoot() {
11-
return AlertModule;
10+
static forRoot(): ModuleWithProviders<AlertModule> {
11+
return {
12+
ngModule: AlertModule,
13+
providers: []
14+
};
1215
}
1316
}

src/alert/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngx-bootstrap/alert",
3-
"version": "18.1.0",
3+
"version": "18.1.1",
44
"author": "Dmitriy Shekhovtsov <[email protected]>",
55
"license": "MIT"
66
}

src/buttons/buttons.module.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { NgModule } from '@angular/core';
1+
import { ModuleWithProviders, NgModule } from '@angular/core';
22

33
import { ButtonCheckboxDirective } from './button-checkbox.directive';
44
import { ButtonRadioDirective } from './button-radio.directive';
@@ -10,7 +10,10 @@ import { ButtonRadioGroupDirective } from './button-radio-group.directive';
1010
})
1111
export class ButtonsModule {
1212
// @deprecated method not required anymore, will be deleted in v19.0.0
13-
static forRoot() {
14-
return ButtonsModule;
13+
static forRoot(): ModuleWithProviders<ButtonsModule> {
14+
return {
15+
ngModule: ButtonsModule,
16+
providers: []
17+
};
1518
}
1619
}

src/buttons/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngx-bootstrap/buttons",
3-
"version": "18.1.0",
3+
"version": "18.1.1",
44
"author": "Dmitriy Shekhovtsov <[email protected]>",
55
"license": "MIT"
66
}

0 commit comments

Comments
 (0)