Skip to content

Commit e9e01f0

Browse files
authored
Alex angular 19 migration (#6712)
* chore(angular-19): added angular 19 support * chore(angular-19-migration): added angular-19 support * chore(angular-19-migration): removed nx-cache for npw * fix(workflow): removed cloud build temporarily * fix(workflow): fixing build * fix(workflow): fixing build * fix(workflow): fixing build * fix(workflow): fixing build * fix(workflow): fixing build * fix(workflow): fixing build * fix(workflow): fixing build * fix(workflow): fixing build * fix(workflow): fixing build * 19.0.0 * chore(version-bump): bumped version to 19.0.0 * fix(workflow): fixing build * fix(workflow): fixing tests * fix(workflow): fixing tests * fix(workflow): fixing tests * fix(workflow): fixing tests * fix(workflow): fixing tests
1 parent f09e4b1 commit e9e01f0

File tree

407 files changed

+10420
-10832
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

407 files changed

+10420
-10832
lines changed

.eslintrc.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,10 @@
3333
"semi": "off",
3434
"@typescript-eslint/semi": ["error"],
3535
"@typescript-eslint/no-extra-semi": "error",
36-
"no-extra-semi": "off"
36+
"no-extra-semi": "off",
37+
"@angular-eslint/prefer-standalone": [
38+
"off"
39+
]
3740
}
3841
},
3942
{

.github/workflows/on-push-or-pull.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,12 @@ jobs:
6161
with:
6262
path: ${{ env.CACHE_DIST_PATH }}
6363
key: dist-${{ github.run_id }}
64+
# - run: |
65+
# npx nx build ngx-bootstrap --runner=cloud --configuration=production
66+
# npx nx build --runner=cloud --configuration=production
6467
- run: |
65-
npx nx build ngx-bootstrap --runner=cloud --configuration=production
66-
npx nx build --runner=cloud --configuration=production
68+
npx nx build ngx-bootstrap --configuration=production
69+
npx nx build --configuration=production
6770
6871
6972
# run unit tests
@@ -80,7 +83,8 @@ jobs:
8083
with:
8184
path: ${{ env.CACHE_DIST_PATH }}
8285
key: dist-${{ github.run_id }}
83-
- run: npm test -- --runner=cloud --codeCoverage
86+
# - run: npm test -- --runner=cloud --codeCoverage
87+
- run: npm test -- --codeCoverage
8488
- run: npx codecov ./coverage/
8589
continue-on-error: true
8690

@@ -94,7 +98,8 @@ jobs:
9498
with:
9599
path: ${{ env.CACHE_NODE_MODULES_PATH }}
96100
key: node_modules-${{ hashFiles('**/package-lock.json') }}
97-
- run: npm run lint -- --runner=cloud
101+
# - run: npm run lint -- --runner=cloud
102+
- run: npm run lint --
98103

99104
# firebase deploy preview
100105
firebase_preview:

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ Thumbs.db
4242

4343
firebase-debug.log
4444
.nx-cache
45+
.nx
4546
scully.log
4647
/.angular
4748
/.scully
@@ -59,4 +60,4 @@ scully.log
5960

6061
migration.json
6162

62-
.nx/cache
63+
.nx/cache

apps/ngx-bootstrap-docs/.eslintrc.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@
3737
"style": "kebab-case"
3838
}
3939
],
40+
"@angular-eslint/prefer-standalone": [
41+
"off"
42+
],
4043
"@typescript-eslint/no-explicit-any": 0,
4144
"@angular-eslint/component-class-suffix": 0,
4245
"@angular-eslint/no-output-on-prefix": 0

apps/ngx-bootstrap-docs/src/app/app.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ import { filter } from 'rxjs/operators';
77

88
@Component({
99
selector: 'bs-demo',
10-
templateUrl: './app.component.html'
10+
templateUrl: './app.component.html',
11+
standalone: false
1112
})
1213
export class AppComponent implements AfterContentInit {
1314
showSidebar = false;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"version": "18.1.3"
2+
"version": "19.0.0"
33
}

libs/common-docs/.eslintrc.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@
3535
"prefix": "ngx-bootstrap-base",
3636
"style": "kebab-case"
3737
}
38+
],
39+
"@angular-eslint/prefer-standalone": [
40+
"off"
3841
]
3942
}
4043
},

libs/common-docs/src/lib/api-docs/api-doc-class/api-doc-class.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ import { ComponentApi } from '../../models/components-api.model';
1616
// eslint-disable-next-line @angular-eslint/component-selector
1717
selector: 'ng-api-doc-class',
1818
changeDetection: ChangeDetectionStrategy.OnPush,
19-
templateUrl: './api-doc-class.component.html'
19+
templateUrl: './api-doc-class.component.html',
20+
standalone: false
2021
})
2122
export class NgApiDocClassComponent {
2223
headerAnchor?: string;

libs/common-docs/src/lib/api-docs/api-doc-config/api-doc-config.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ const CONFIG_SUFFIX_LENGTH = 'Config'.length;
2121
// eslint-disable-next-line @angular-eslint/component-selector
2222
selector: 'ng-api-doc-config',
2323
changeDetection: ChangeDetectionStrategy.OnPush,
24-
templateUrl: './api-doc-config.component.html'
24+
templateUrl: './api-doc-config.component.html',
25+
standalone: false
2526
})
2627
export class NgApiDocConfigComponent {
2728
apiDocs?: ClassDesc;

libs/common-docs/src/lib/api-docs/api-doc/api-doc.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ import { DomSanitizer } from '@angular/platform-browser';
2121
// eslint-disable-next-line @angular-eslint/component-selector
2222
selector: 'ng-api-doc',
2323
changeDetection: ChangeDetectionStrategy.OnPush,
24-
templateUrl: './api-doc.component.html'
24+
templateUrl: './api-doc.component.html',
25+
standalone: false
2526
})
2627
export class NgApiDocComponent {
2728
apiDocs?: DirectiveDesc;

0 commit comments

Comments
 (0)