chore(config): migrate some remote config to Statsig and remove legacy configs (#6473)

### Description

This PR removes some unused remote config configs, and replaces the
following with statsig:
- wallet connect v2 enabled -> feature gate (note that feature gates
always default to false, but we should default this value to true since
then builders can access wallet connect without a statsig account,
[context](https://valora-app.slack.com/archives/C025V1D6F3J/p1722383273562829))
- celo education url -> new item in app_config links

Note that the expanded pincode blocklist remote config flag doesn't
actually exist in the remote config console - so it is always defaulting
to false, so i've just removed the functionality.

Removed unused config:
- logPhoneNumberTypeEnabled
- pincodeUseExpandedBlocklist
- coinbasePayEnabled
- maxSwapSlippagePercentage
- networkTimeoutSeconds

### Test plan

n/a

### Related issues

- Related to RET-1272

### Backwards compatibility

Y

### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [ ] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)

Author: kathaypacific

src/app/reducers.ts

@@ -21,24 +21,17 @@ interface State {
   locked: boolean
   lastTimeBackgrounded: number
   sessionId: string
-  celoEducationUri: string | null
   activeScreen: Screens
-  walletConnectV2Enabled: boolean
   // In 1.13 we had a critical error which requires a migration to fix. See |verificationMigration.ts|
   // for the migration code. We can remove all the code associated with this after some time has passed.
-  logPhoneNumberTypeEnabled: boolean
   googleMobileServicesAvailable?: boolean
   huaweiMobileServicesAvailable?: boolean
-  pincodeUseExpandedBlocklist: boolean
   sentryTracesSampleRate: number
   sentryNetworkErrors: string[]
   supportedBiometryType: BIOMETRY_TYPE | null
   fiatConnectCashInEnabled: boolean
   fiatConnectCashOutEnabled: boolean
-  coinbasePayEnabled: boolean
-  maxSwapSlippagePercentage: number
   inviterAddress: string | null
-  networkTimeoutSeconds: number
   celoNews: CeloNewsConfig
   hapticFeedbackEnabled: boolean
   pushNotificationRequestedUnixTime: number | null
@@ -63,22 +56,15 @@ const initialState = {
   locked: false,
   lastTimeBackgrounded: 0,
   sessionId: '',
-  celoEducationUri: null,
   activeScreen: Screens.Main,
-  walletConnectV2Enabled: REMOTE_CONFIG_VALUES_DEFAULTS.walletConnectV2Enabled,
-  logPhoneNumberTypeEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.logPhoneNumberTypeEnabled,
   googleMobileServicesAvailable: undefined,
   huaweiMobileServicesAvailable: undefined,
-  pincodeUseExpandedBlocklist: REMOTE_CONFIG_VALUES_DEFAULTS.pincodeUseExpandedBlocklist,
   sentryTracesSampleRate: REMOTE_CONFIG_VALUES_DEFAULTS.sentryTracesSampleRate,
   sentryNetworkErrors: REMOTE_CONFIG_VALUES_DEFAULTS.sentryNetworkErrors.split(','),
   supportedBiometryType: null,
   fiatConnectCashInEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.fiatConnectCashInEnabled,
   fiatConnectCashOutEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.fiatConnectCashOutEnabled,
-  coinbasePayEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.coinbasePayEnabled,
-  maxSwapSlippagePercentage: REMOTE_CONFIG_VALUES_DEFAULTS.maxSwapSlippagePercentage,
   inviterAddress: null,
-  networkTimeoutSeconds: REMOTE_CONFIG_VALUES_DEFAULTS.networkTimeoutSeconds,
   celoNews: JSON.parse(REMOTE_CONFIG_VALUES_DEFAULTS.celoNews),
   hapticFeedbackEnabled: true,
   pushNotificationRequestedUnixTime: null,
@@ -167,17 +153,10 @@ export const appReducer = (
     case Actions.UPDATE_REMOTE_CONFIG_VALUES:
       return {
         ...state,
-        celoEducationUri: action.configValues.celoEducationUri,
-        walletConnectV2Enabled: action.configValues.walletConnectV2Enabled,
-        logPhoneNumberTypeEnabled: action.configValues.logPhoneNumberTypeEnabled,
-        pincodeUseExpandedBlocklist: action.configValues.pincodeUseExpandedBlocklist,
         sentryTracesSampleRate: action.configValues.sentryTracesSampleRate,
         sentryNetworkErrors: action.configValues.sentryNetworkErrors,
         fiatConnectCashInEnabled: action.configValues.fiatConnectCashInEnabled,
         fiatConnectCashOutEnabled: action.configValues.fiatConnectCashOutEnabled,
-        coinbasePayEnabled: action.configValues.coinbasePayEnabled,
-        maxSwapSlippagePercentage: action.configValues.maxSwapSlippagePercentage,
-        networkTimeoutSeconds: action.configValues.networkTimeoutSeconds,
         celoNews: action.configValues.celoNews,
       }
     case Actions.ACTIVE_SCREEN_CHANGED:

src/app/saga.test.ts

@@ -46,11 +46,12 @@ import { allowHooksPreviewSelector } from 'src/positions/selectors'
 import { handlePaymentDeeplink } from 'src/send/utils'
 import { initializeSentry } from 'src/sentry/Sentry'
 import { getDynamicConfigParams, getFeatureGate, patchUpdateStatsigUser } from 'src/statsig'
+import { StatsigFeatureGates } from 'src/statsig/types'
 import { NetworkId } from 'src/transactions/types'
 import { navigateToURI } from 'src/utils/linking'
 import Logger from 'src/utils/Logger'
 import { ONE_DAY_IN_MILLIS } from 'src/utils/time'
-import { initialiseWalletConnect } from 'src/walletConnect/saga'
+import { _setClientForTesting, initialiseWalletConnect } from 'src/walletConnect/saga'
 import { selectHasPendingState } from 'src/walletConnect/selectors'
 import { WalletConnectRequestType } from 'src/walletConnect/types'
 import { handleWalletConnectDeepLink } from 'src/walletConnect/walletConnect'
@@ -286,6 +287,7 @@ describe('handleDeepLink', () => {
 describe('WalletConnect deeplinks', () => {
   beforeEach(() => {
     jest.clearAllMocks()
+    _setClientForTesting({} as any)
   })
 
   const connectionString = encodeURIComponent(
@@ -619,7 +621,12 @@ describe(requestInAppReview, () => {
   `(
     `Should show when isAvailable: true, Last Interaction: $lastInteraction and Wallet Address: 0xTest`,
     async ({ lastInteractionTimestamp }) => {
-      jest.mocked(getFeatureGate).mockReturnValue(true)
+      jest.mocked(getFeatureGate).mockImplementation((featureGate) => {
+        if (featureGate === StatsigFeatureGates.APP_REVIEW) {
+          return true
+        }
+        return false
+      })
       mockIsInAppReviewAvailable.mockReturnValue(true)
       mockRequestInAppReview.mockResolvedValue(true)
 
@@ -648,7 +655,12 @@ describe(requestInAppReview, () => {
   `(
     `Should not show when Device Available: $isAvailable, Feature Gate: $featureGate, Last Interaction: $lastInteraction and Wallet Address: $walletAddress`,
     async ({ lastInteractionTimestamp, isAvailable, featureGate, walletAddress }) => {
-      jest.mocked(getFeatureGate).mockReturnValue(featureGate)
+      jest.mocked(getFeatureGate).mockImplementation((gate) => {
+        if (gate === StatsigFeatureGates.APP_REVIEW) {
+          return featureGate
+        }
+        return false
+      })
       mockIsInAppReviewAvailable.mockReturnValue(isAvailable)
       mockRequestInAppReview.mockResolvedValue(true)
 
@@ -668,7 +680,12 @@ describe(requestInAppReview, () => {
   )
 
   it('Should handle error from react-native-in-app-review', async () => {
-    jest.mocked(getFeatureGate).mockReturnValue(true)
+    jest.mocked(getFeatureGate).mockImplementation((featureGate) => {
+      if (featureGate === StatsigFeatureGates.APP_REVIEW) {
+        return true
+      }
+      return false
+    })
     mockIsInAppReviewAvailable.mockReturnValue(true)
     mockRequestInAppReview.mockRejectedValue(new Error('🤖💥'))
 

src/app/saga.ts

@@ -176,12 +176,8 @@ export function* checkAndroidMobileServicesSaga() {
 }
 
 export interface RemoteConfigValues {
-  celoEducationUri: string | null
   dappListApiUrl: string | null
   inviteRewardsVersion: string
-  walletConnectV2Enabled: boolean
-  logPhoneNumberTypeEnabled: boolean
-  pincodeUseExpandedBlocklist: boolean
   allowOtaTranslations: boolean
   sentryTracesSampleRate: number
   sentryNetworkErrors: string[]
@@ -190,9 +186,6 @@ export interface RemoteConfigValues {
   fiatConnectCashInEnabled: boolean
   fiatConnectCashOutEnabled: boolean
   fiatAccountSchemaCountryOverrides: FiatAccountSchemaCountryOverrides
-  coinbasePayEnabled: boolean
-  maxSwapSlippagePercentage: number
-  networkTimeoutSeconds: number
   celoNews: CeloNewsConfig
   priceImpactWarningThreshold: number
 }

src/app/selectors.ts

@@ -24,14 +24,6 @@ export const sessionIdSelector = (state: RootState) => {
   return state.app.sessionId
 }
 
-// this can be called with undefined state in the tests
-export const walletConnectEnabledSelector = (state?: RootState) => ({
-  v2: state?.app.walletConnectV2Enabled ?? false,
-})
-
-export const logPhoneNumberTypeEnabledSelector = (state: RootState) =>
-  state.app.logPhoneNumberTypeEnabled
-
 export const googleMobileServicesAvailableSelector = (state: RootState) =>
   state.app.googleMobileServicesAvailable
 
@@ -49,15 +41,10 @@ export const fiatConnectCashInEnabledSelector = (state: RootState) =>
 export const fiatConnectCashOutEnabledSelector = (state: RootState) =>
   state.app.fiatConnectCashOutEnabled
 
-export const maxSwapSlippagePercentageSelector = (state: RootState) =>
-  state.app.maxSwapSlippagePercentage
-
 export const phoneNumberVerifiedSelector = (state: RootState) => state.app.phoneNumberVerified
 
 export const inviterAddressSelector = (state: RootState) => state.app.inviterAddress
 
-export const networkTimeoutSecondsSelector = (state: RootState) => state.app.networkTimeoutSeconds
-
 export const celoNewsConfigSelector = (state: RootState) => state.app.celoNews
 
 export const hapticFeedbackEnabledSelector = (state: RootState) => state.app.hapticFeedbackEnabled

src/firebase/firebase.ts

@@ -274,16 +274,8 @@ export async function fetchRemoteConfigValues(): Promise<RemoteConfigValues | nu
   const celoNewsString = flags.celoNews?.asString()
 
   return {
-    // these next 2 flags are a bit weird because their default is undefined or null
-    // and the default map cannot have a value of undefined or null
-    // that is why we still need to check for it before calling a method
-    // in the future it would be great to avoid using these as default values
-    celoEducationUri: flags.celoEducationUri?.asString() ?? null,
     dappListApiUrl: flags.dappListApiUrl?.asString() ?? null,
     inviteRewardsVersion: flags.inviteRewardsVersion.asString(),
-    walletConnectV2Enabled: flags.walletConnectV2Enabled.asBoolean(),
-    pincodeUseExpandedBlocklist: flags.pincodeUseExpandedBlocklist.asBoolean(),
-    logPhoneNumberTypeEnabled: flags.logPhoneNumberTypeEnabled.asBoolean(),
     allowOtaTranslations: flags.allowOtaTranslations.asBoolean(),
     sentryTracesSampleRate: flags.sentryTracesSampleRate.asNumber(),
     sentryNetworkErrors: flags.sentryNetworkErrors.asString().split(','),
@@ -294,9 +286,6 @@ export async function fetchRemoteConfigValues(): Promise<RemoteConfigValues | nu
     fiatAccountSchemaCountryOverrides: fiatAccountSchemaCountryOverrides
       ? JSON.parse(fiatAccountSchemaCountryOverrides)
       : {},
-    coinbasePayEnabled: flags.coinbasePayEnabled.asBoolean(),
-    maxSwapSlippagePercentage: flags.maxSwapSlippagePercentage.asNumber(),
-    networkTimeoutSeconds: flags.networkTimeoutSeconds.asNumber(),
     celoNews: celoNewsString ? JSON.parse(celoNewsString) : {},
     // Convert to percentage, so we're consistent with the price impact value returned by our swap API
     priceImpactWarningThreshold: flags.priceImpactWarningThreshold.asNumber() * 100,

src/firebase/remoteConfigValuesDefaults.e2e.ts

@@ -2,15 +2,12 @@ import { RemoteConfigValues } from 'src/app/saga'
 
 export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   RemoteConfigValues,
-  'celoEducationUri' | 'sentryNetworkErrors' | 'fiatAccountSchemaCountryOverrides' | 'celoNews'
+  'sentryNetworkErrors' | 'fiatAccountSchemaCountryOverrides' | 'celoNews'
 > & {
   sentryNetworkErrors: string
   celoNews: string
 } = {
   inviteRewardsVersion: 'none',
-  walletConnectV2Enabled: true,
-  pincodeUseExpandedBlocklist: true,
-  logPhoneNumberTypeEnabled: false,
   allowOtaTranslations: false,
   sentryTracesSampleRate: 0.2,
   sentryNetworkErrors: '',
@@ -19,9 +16,6 @@ export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   dappsWebViewEnabled: true,
   fiatConnectCashInEnabled: false,
   fiatConnectCashOutEnabled: true,
-  coinbasePayEnabled: false,
-  maxSwapSlippagePercentage: 2,
-  networkTimeoutSeconds: 30,
   celoNews: JSON.stringify({} as RemoteConfigValues['celoNews']),
   priceImpactWarningThreshold: 0.04,
 }

src/firebase/remoteConfigValuesDefaults.ts

@@ -3,16 +3,13 @@ import { DEFAULT_SENTRY_NETWORK_ERRORS, DEFAULT_SENTRY_TRACES_SAMPLE_RATE } from
 
 export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   RemoteConfigValues,
-  'celoEducationUri' | 'sentryNetworkErrors' | 'fiatAccountSchemaCountryOverrides' | 'celoNews'
+  'sentryNetworkErrors' | 'fiatAccountSchemaCountryOverrides' | 'celoNews'
 > & {
   sentryNetworkErrors: string
   dappListApiUrl: string
   celoNews: string
 } = {
   inviteRewardsVersion: 'none',
-  walletConnectV2Enabled: true,
-  pincodeUseExpandedBlocklist: false,
-  logPhoneNumberTypeEnabled: false,
   allowOtaTranslations: false,
   sentryTracesSampleRate: DEFAULT_SENTRY_TRACES_SAMPLE_RATE,
   sentryNetworkErrors: DEFAULT_SENTRY_NETWORK_ERRORS.join(','),
@@ -21,9 +18,6 @@ export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   dappListApiUrl: '',
   fiatConnectCashInEnabled: false,
   fiatConnectCashOutEnabled: false,
-  coinbasePayEnabled: false,
-  maxSwapSlippagePercentage: 2,
-  networkTimeoutSeconds: 30,
   celoNews: JSON.stringify({} as RemoteConfigValues['celoNews']),
   priceImpactWarningThreshold: 0.04,
 }

src/navigator/SettingsMenu.test.tsx

@@ -6,17 +6,23 @@ import { clearStoredAccount } from 'src/account/actions'
 import { navigate } from 'src/navigator/NavigationService'
 import { Screens } from 'src/navigator/Screens'
 import SettingsMenu from 'src/navigator/SettingsMenu'
+import { getFeatureGate, getMultichainFeatures } from 'src/statsig'
+import { StatsigFeatureGates } from 'src/statsig/types'
+import { NetworkId } from 'src/transactions/types'
 import MockedNavigator from 'test/MockedNavigator'
 import { createMockStore } from 'test/utils'
 import { mockE164Number } from 'test/values'
 
-jest.mock('src/statsig', () => ({
-  ...jest.requireActual('src/statsig'),
-  getFeatureGate: jest.fn().mockReturnValue(false),
-  getMultichainFeatures: jest.fn(() => ({
-    showBalances: ['celo-alfajores'],
-  })),
-}))
+jest.mock('src/statsig')
+jest.mocked(getMultichainFeatures).mockReturnValue({
+  showBalances: [NetworkId['celo-alfajores']],
+})
+jest.mocked(getFeatureGate).mockImplementation((gate) => {
+  if (gate === StatsigFeatureGates.DISABLE_WALLET_CONNECT_V2) {
+    return false
+  }
+  throw new Error('Unexpected gate')
+})
 
 jest.mock('statsig-react-native', () => ({
   Statsig: {

src/navigator/SettingsMenu.tsx

@@ -22,11 +22,7 @@ import {
 import AppAnalytics from 'src/analytics/AppAnalytics'
 import { SettingsEvents } from 'src/analytics/Events'
 import { setSessionId } from 'src/app/actions'
-import {
-  phoneNumberVerifiedSelector,
-  sessionIdSelector,
-  walletConnectEnabledSelector,
-} from 'src/app/selectors'
+import { phoneNumberVerifiedSelector, sessionIdSelector } from 'src/app/selectors'
 import ContactCircleSelf from 'src/components/ContactCircleSelf'
 import GradientBlock from 'src/components/GradientBlock'
 import { SettingsItemTextValue } from 'src/components/SettingsItem'
@@ -44,6 +40,8 @@ import { navigate } from 'src/navigator/NavigationService'
 import { Screens } from 'src/navigator/Screens'
 import { StackParamList } from 'src/navigator/types'
 import { useDispatch, useSelector } from 'src/redux/hooks'
+import { getFeatureGate } from 'src/statsig'
+import { StatsigFeatureGates } from 'src/statsig/types'
 import Colors from 'src/styles/colors'
 import { typeScale } from 'src/styles/fonts'
 import { Spacing } from 'src/styles/styles'
@@ -125,9 +123,8 @@ export default function SettingsMenu({ route }: Props) {
   const appVersion = deviceInfoModule.getVersion()
   const buildNumber = deviceInfoModule.getBuildNumber()
 
-  const { v2 } = useSelector(walletConnectEnabledSelector)
   const { sessions } = useSelector(selectSessions)
-  const walletConnectEnabled = v2
+  const walletConnectV2Disabled = getFeatureGate(StatsigFeatureGates.DISABLE_WALLET_CONNECT_V2)
   const connectedDapps = sessions?.length
 
   const sessionId = useSelector(sessionIdSelector)
@@ -231,7 +228,7 @@ export default function SettingsMenu({ route }: Props) {
           showChevron
           borderless
         />
-        {walletConnectEnabled && (
+        {!walletConnectV2Disabled && (
           <SettingsItemTextValue
             icon={<Stack size={24} color={Colors.contentPrimary} />}
             title={t('connectedApplications')}