chore(config): move more remote config to Statsig (#6474)

### Description

This PR moves the following remote config variables to statsig dynamic
config:
- dapp list url -> app config
- dapp in-app webview enabled -> dapps webview config
- celo news -> app config
- swap price impact warning threshold -> swap config
- `maxNumRecentDapps` is no longer used and just removed here

### Test plan

n/a

### Related issues

- Related to RET-1272

### Backwards compatibility

Y

### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [ ] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)

Author: kathaypacific

src/app/reducers.ts

@@ -1,7 +1,6 @@
 import { BIOMETRY_TYPE } from '@interaxyz/react-native-keychain'
 import { Platform } from 'react-native'
 import { Actions, ActionTypes, AppState } from 'src/app/actions'
-import { CeloNewsConfig } from 'src/celoNews/types'
 import { DEEP_LINK_URL_SCHEME } from 'src/config'
 import { REMOTE_CONFIG_VALUES_DEFAULTS } from 'src/firebase/remoteConfigValuesDefaults'
 import { Screens } from 'src/navigator/Screens'
@@ -32,7 +31,6 @@ interface State {
   fiatConnectCashInEnabled: boolean
   fiatConnectCashOutEnabled: boolean
   inviterAddress: string | null
-  celoNews: CeloNewsConfig
   hapticFeedbackEnabled: boolean
   pushNotificationRequestedUnixTime: number | null
   pushNotificationsEnabled: boolean
@@ -65,7 +63,6 @@ const initialState = {
   fiatConnectCashInEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.fiatConnectCashInEnabled,
   fiatConnectCashOutEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.fiatConnectCashOutEnabled,
   inviterAddress: null,
-  celoNews: JSON.parse(REMOTE_CONFIG_VALUES_DEFAULTS.celoNews),
   hapticFeedbackEnabled: true,
   pushNotificationRequestedUnixTime: null,
   pushNotificationsEnabled: false,
@@ -157,7 +154,6 @@ export const appReducer = (
         sentryNetworkErrors: action.configValues.sentryNetworkErrors,
         fiatConnectCashInEnabled: action.configValues.fiatConnectCashInEnabled,
         fiatConnectCashOutEnabled: action.configValues.fiatConnectCashOutEnabled,
-        celoNews: action.configValues.celoNews,
       }
     case Actions.ACTIVE_SCREEN_CHANGED:
       return {

src/app/saga.ts

@@ -30,7 +30,6 @@ import {
   inAppReviewLastInteractionTimestampSelector,
   sentryNetworkErrorsSelector,
 } from 'src/app/selectors'
-import { CeloNewsConfig } from 'src/celoNews/types'
 import { DEFAULT_APP_LANGUAGE, FETCH_TIMEOUT_DURATION, isE2EEnv } from 'src/config'
 import { FiatExchangeFlow } from 'src/fiatExchanges/types'
 import { FiatAccountSchemaCountryOverrides } from 'src/fiatconnect/types'
@@ -176,18 +175,13 @@ export function* checkAndroidMobileServicesSaga() {
 }
 
 export interface RemoteConfigValues {
-  dappListApiUrl: string | null
   inviteRewardsVersion: string
   allowOtaTranslations: boolean
   sentryTracesSampleRate: number
   sentryNetworkErrors: string[]
-  maxNumRecentDapps: number
-  dappsWebViewEnabled: boolean
   fiatConnectCashInEnabled: boolean
   fiatConnectCashOutEnabled: boolean
   fiatAccountSchemaCountryOverrides: FiatAccountSchemaCountryOverrides
-  celoNews: CeloNewsConfig
-  priceImpactWarningThreshold: number
 }
 
 export function* appRemoteFeatureFlagSaga() {

src/app/selectors.ts

@@ -45,8 +45,6 @@ export const phoneNumberVerifiedSelector = (state: RootState) => state.app.phone
 
 export const inviterAddressSelector = (state: RootState) => state.app.inviterAddress
 
-export const celoNewsConfigSelector = (state: RootState) => state.app.celoNews
-
 export const hapticFeedbackEnabledSelector = (state: RootState) => state.app.hapticFeedbackEnabled
 
 export const pushNotificationsEnabledSelector = (state: RootState) =>

src/celoNews/CeloNewsFeed.tsx

@@ -4,14 +4,15 @@ import { useTranslation } from 'react-i18next'
 import { FlatList, ListRenderItemInfo, StyleSheet, Text, View } from 'react-native'
 import AppAnalytics from 'src/analytics/AppAnalytics'
 import { CeloNewsEvents } from 'src/analytics/Events'
-import { celoNewsConfigSelector } from 'src/app/selectors'
 import CeloNewsFeedItem from 'src/celoNews/CeloNewsFeedItem'
 import { CeloNewsArticle, CeloNewsArticles } from 'src/celoNews/types'
 import Button, { BtnSizes, BtnTypes } from 'src/components/Button'
 import EmptyView from 'src/components/EmptyView'
 import { navigate } from 'src/navigator/NavigationService'
 import { Screens } from 'src/navigator/Screens'
-import { useSelector } from 'src/redux/hooks'
+import { getDynamicConfigParams } from 'src/statsig'
+import { DynamicConfigs } from 'src/statsig/constants'
+import { StatsigDynamicConfigs } from 'src/statsig/types'
 import colors from 'src/styles/colors'
 import { typeScale } from 'src/styles/fonts'
 import { Spacing } from 'src/styles/styles'
@@ -61,7 +62,8 @@ export default function CeloNewsFeed() {
   const { t } = useTranslation()
 
   const asyncArticles = useFetchArticles()
-  const { readMoreUrl } = useSelector(celoNewsConfigSelector)
+  const { links } = getDynamicConfigParams(DynamicConfigs[StatsigDynamicConfigs.APP_CONFIG])
+  const readMoreUrl = links?.celoNews
   const isLoading = asyncArticles.status === 'loading'
 
   useEffect(() => {

src/celoNews/types.ts

@@ -1,6 +1,3 @@
-export interface CeloNewsConfig {
-  readMoreUrl?: string
-}
 export interface CeloNewsArticles {
   articles: CeloNewsArticle[]
   nextPageId: string

src/dapps/DappsScreen.test.tsx

@@ -39,7 +39,7 @@ const dappsCategories: DappCategory[] = [
 ]
 
 const defaultStore = createMockStore({
-  dapps: { dappListApiUrl: 'http://url.com', dappsList, dappsCategories },
+  dapps: { dappsList, dappsCategories },
 })
 
 describe('DappsScreen', () => {
@@ -106,7 +106,6 @@ describe('DappsScreen', () => {
   it('opens dapps directly', () => {
     const store = createMockStore({
       dapps: {
-        dappListApiUrl: 'http://url.com',
         dappsList,
         dappsCategories,
       },
@@ -130,7 +129,6 @@ describe('DappsScreen', () => {
   it('renders error message when fetching dapps fails', () => {
     const store = createMockStore({
       dapps: {
-        dappListApiUrl: 'http://url.com',
         dappsList: [],
         dappsCategories: [],
         dappsListError: 'Error fetching dapps',
@@ -152,7 +150,6 @@ describe('DappsScreen', () => {
     it('renders correctly when there are no favorite dapps', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: [],
@@ -173,7 +170,6 @@ describe('DappsScreen', () => {
     it('renders correctly when there are favourited dapps', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp2'],
@@ -195,7 +191,6 @@ describe('DappsScreen', () => {
     it('triggers the events when favoriting', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp1'],
@@ -230,7 +225,6 @@ describe('DappsScreen', () => {
     it('triggers the events when unfavoriting', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp2'],
@@ -268,7 +262,6 @@ describe('DappsScreen', () => {
     it('renders correctly when there are no search results', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: [],
@@ -291,7 +284,6 @@ describe('DappsScreen', () => {
     it('renders correctly when there are search results in both sections', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp2'],
@@ -324,7 +316,6 @@ describe('DappsScreen', () => {
     it('clearing search input should show all dapps', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp2'],
@@ -360,7 +351,6 @@ describe('DappsScreen', () => {
     it('renders correctly when there are no filters applied', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp1'],
@@ -391,7 +381,6 @@ describe('DappsScreen', () => {
     it('renders correctly when there are filters applied', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp1'],
@@ -425,7 +414,6 @@ describe('DappsScreen', () => {
     it('triggers event when filtering', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp1'],
@@ -453,7 +441,6 @@ describe('DappsScreen', () => {
     it('triggers events when toggling a category filter', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp1'],
@@ -488,7 +475,6 @@ describe('DappsScreen', () => {
     it('triggers event when clearing filters from category section', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp2'],
@@ -524,7 +510,6 @@ describe('DappsScreen', () => {
     it('triggers event when clearing filters from favorite section', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp1'],
@@ -559,7 +544,6 @@ describe('DappsScreen', () => {
     it('renders correctly when there are results in all and favorites sections', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp1'],
@@ -588,7 +572,6 @@ describe('DappsScreen', () => {
     it('renders correctly when there are results in favorites and no results in all', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp1'],
@@ -619,7 +602,6 @@ describe('DappsScreen', () => {
     it('renders correctly when there are no results in favorites and results in all', () => {
       const store = createMockStore({
         dapps: {
-          dappListApiUrl: 'http://url.com',
           dappsList,
           dappsCategories,
           favoriteDappIds: ['dapp2'],
@@ -651,7 +633,6 @@ describe('DappsScreen', () => {
 
   describe('dapp open analytics event properties', () => {
     const defaultStoreProps = {
-      dappListApiUrl: 'http://url.com',
       dappsList,
       dappsCategories,
       favoriteDappIds: [],

src/dapps/saga.test.ts

@@ -3,17 +3,22 @@ import { expectSaga } from 'redux-saga-test-plan'
 import { select } from 'redux-saga/effects'
 import { DEEP_LINK_URL_SCHEME } from 'src/config'
 import { handleFetchDappsList, handleOpenDapp } from 'src/dapps/saga'
-import { dappsListApiUrlSelector, dappsWebViewEnabledSelector } from 'src/dapps/selectors'
 import { dappSelected, fetchDappsListCompleted, fetchDappsListFailed } from 'src/dapps/slice'
 import { Dapp, DappSection } from 'src/dapps/types'
 import { currentLanguageSelector } from 'src/i18n/selectors'
 import { navigate } from 'src/navigator/NavigationService'
 import { Screens } from 'src/navigator/Screens'
-import { getExperimentParams } from 'src/statsig'
+import { getDynamicConfigParams, getExperimentParams } from 'src/statsig'
 import { walletAddressSelector } from 'src/web3/selectors'
 import { mockAccount } from 'test/values'
 
 jest.mock('src/statsig')
+jest.mocked(getDynamicConfigParams).mockReturnValue({
+  inAppWebviewEnabled: true,
+  links: {
+    dappList: 'http://some.url',
+  },
+})
 
 describe('Dapps saga', () => {
   describe('Handles opening a dapp', () => {
@@ -30,9 +35,7 @@ describe('Dapps saga', () => {
       await expectSaga(
         handleOpenDapp,
         dappSelected({ dapp: { ...baseDapp, openedFrom: DappSection.All } })
-      )
-        .provide([[select(dappsWebViewEnabledSelector), true]])
-        .run()
+      ).run()
 
       expect(navigate).toHaveBeenCalledWith(Screens.WebViewScreen, {
         uri: baseDapp.dappUrl,
@@ -50,10 +53,7 @@ describe('Dapps saga', () => {
           },
         })
       )
-        .provide([
-          [select(dappsWebViewEnabledSelector), true],
-          [select(walletAddressSelector), mockAccount],
-        ])
+        .provide([[select(walletAddressSelector), mockAccount]])
         .run()
 
       expect(navigate).toHaveBeenCalledWith(Screens.BidaliScreen, { currency: undefined })
@@ -68,10 +68,7 @@ describe('Dapps saga', () => {
 
     it('does not fetch the dapps list if the wallet is not yet initialized', async () => {
       await expectSaga(handleFetchDappsList)
-        .provide([
-          [select(dappsListApiUrlSelector), 'http://some.url'],
-          [select(walletAddressSelector), null],
-        ])
+        .provide([[select(walletAddressSelector), null]])
         .run()
 
       expect(mockFetch).not.toHaveBeenCalled()
@@ -123,7 +120,6 @@ describe('Dapps saga', () => {
 
       await expectSaga(handleFetchDappsList)
         .provide([
-          [select(dappsListApiUrlSelector), 'http://some.url'],
           [select(walletAddressSelector), '0xabc'],
           [select(currentLanguageSelector), 'en'],
         ])
@@ -171,7 +167,6 @@ describe('Dapps saga', () => {
 
       await expectSaga(handleFetchDappsList)
         .provide([
-          [select(dappsListApiUrlSelector), 'http://some.url'],
           [select(walletAddressSelector), '0xabc'],
           [select(currentLanguageSelector), 'en'],
         ])

src/dapps/saga.ts

@@ -1,7 +1,6 @@
 import { PayloadAction } from '@reduxjs/toolkit'
 import { openDeepLink, openUrl } from 'src/app/actions'
 import { handleDeepLink, handleOpenUrl } from 'src/app/saga'
-import { dappsListApiUrlSelector, dappsWebViewEnabledSelector } from 'src/dapps/selectors'
 import {
   dappSelected,
   DappSelectedAction,
@@ -14,6 +13,9 @@ import { currentLanguageSelector } from 'src/i18n/selectors'
 import { setLanguage } from 'src/i18n/slice'
 import { navigate } from 'src/navigator/NavigationService'
 import { Screens } from 'src/navigator/Screens'
+import { getDynamicConfigParams } from 'src/statsig'
+import { DynamicConfigs } from 'src/statsig/constants'
+import { StatsigDynamicConfigs } from 'src/statsig/types'
 import { isDeepLink } from 'src/utils/linking'
 import Logger from 'src/utils/Logger'
 import { safely } from 'src/utils/safely'
@@ -36,7 +38,9 @@ interface Application {
 
 export function* handleOpenDapp(action: PayloadAction<DappSelectedAction>) {
   const { dappUrl } = action.payload.dapp
-  const dappsWebViewEnabled = yield* select(dappsWebViewEnabledSelector)
+  const dappsWebViewEnabled = getDynamicConfigParams(
+    DynamicConfigs[StatsigDynamicConfigs.DAPP_WEBVIEW_CONFIG]
+  ).inAppWebviewEnabled
 
   if (dappsWebViewEnabled) {
     const walletConnectEnabled: boolean = yield* call(isWalletConnectEnabled, dappUrl)
@@ -51,7 +55,8 @@ export function* handleOpenDapp(action: PayloadAction<DappSelectedAction>) {
 }
 
 export function* handleFetchDappsList() {
-  const dappsListApiUrl = yield* select(dappsListApiUrlSelector)
+  const { links } = getDynamicConfigParams(DynamicConfigs[StatsigDynamicConfigs.APP_CONFIG])
+  const dappsListApiUrl = links.dappList
   if (!dappsListApiUrl) {
     Logger.warn(TAG, 'dappsListApiUrl not found, skipping dapps list fetch')
     return

src/dapps/selectors.ts

@@ -17,12 +17,7 @@ function getDappsById(dapps: Dapp[], dappIds: string[]) {
   return matchingDapps
 }
 
-export const dappsListApiUrlSelector = (state: RootState) => state.dapps.dappListApiUrl
-
-export const activeDappSelector = (state: RootState) =>
-  state.dapps.dappsWebViewEnabled ? state.dapps.activeDapp : null
-
-export const dappsWebViewEnabledSelector = (state: RootState) => state.dapps.dappsWebViewEnabled
+export const activeDappSelector = (state: RootState) => state.dapps.activeDapp
 
 export const dappsCategoriesSelector = (state: RootState) => state.dapps.dappsCategories