Commit 5d70e8e
authored
fix(jumpstart): correct jumpstart contracts
### Description
1) All possible dynamic config properties must be listed in
`defaultValues` when declaring that config.
Otherwise, they [won't be
forwarded](https://github.com/valora-inc/wallet/blob/a0b4675774579822a6c2ac55e7de38f6658b45c2/src/statsig/index.ts#L29-L34).
2) In addition, it seems more appropriate to use `NetworkId` as network
specifier instead of `Network` to enable jumpstart contracts on the
testnet as well.
### Test plan
* Updated unit tests
### Related issues
- Related to RET-999
### Backwards compatibility
Jumpstart functionality is not fully released yet
### Network scalability
If a new NetworkId and/or Network are added in the future, the changes
in this PR will:
- [x] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)defaultValue (#4923)1 parent 81e998c commit 5d70e8e
File tree
3 files changed
+9
-5
lines changed- src
- jumpstart
- statsig
3 files changed
+9
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
46 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
47 | 50 | | |
48 | 51 | | |
49 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
| |||
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
19 | | - | |
| 18 | + | |
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
105 | 107 | | |
106 | 108 | | |
107 | 109 | | |
| |||
0 commit comments