Bugfix for Cache::memo()->many() returning the wrong value with an integer key type (laravel#55503)

* Update MemoizedStore.php to maintain key types

Bugfix for laravel#55500

* Styling Fix

* Style Fix

* Add tests

* Remove redundant `all` call

* Make fall back strict

* Improve tests

* Style fix

* Update tests/Integration/Cache/MemoizedStoreTest.php

* Update MemoizedStore.php

---------

Co-authored-by: Tim MacDonald <[email protected]>
Co-authored-by: Taylor Otwell <[email protected]>

Author: 3 people

src/Illuminate/Cache/MemoizedStore.php

@@ -75,12 +75,17 @@ public function many(array $keys)
             });
         }
 
-        $result = [
-            ...$memoized,
-            ...$retrieved,
-        ];
+        $result = [];
 
-        return array_replace(array_flip($keys), $result);
+        foreach ($keys as $key) {
+            if (array_key_exists($key, $memoized)) {
+                $result[$key] = $memoized[$key];
+            } else {
+                $result[$key] = $retrieved[$key];
+            }
+        }
+
+        return $result;
     }
 
     /**

tests/Integration/Cache/MemoizedStoreTest.php

@@ -89,6 +89,33 @@ public function test_it_can_memoize_when_retrieving_mulitple_values()
         $this->assertSame(['name.0' => 'Tim', 'name.1' => 'Taylor'], $memoized);
     }
 
+    public function test_it_uses_correct_keys_for_getMultiple()
+    {
+        $data = [
+            'a' => 'string-value',
+            '1.1' => 'float-value',
+            '1' => 'integer-value-as-string',
+            2 => 'integer-value',
+        ];
+        Cache::putMany($data);
+
+        $memoValue = Cache::memo()->many(['a', '1.1', '1', 2]);
+        $cacheValue = Cache::many(['a', '1.1', '1', 2]);
+
+        $this->assertSame([
+            'a' => 'string-value',
+            '1.1' => 'float-value',
+            '1' => 'integer-value-as-string',
+            2 => 'integer-value',
+        ], $cacheValue);
+        $this->assertSame($cacheValue, $memoValue);
+
+        // ensure correct on the second memoized retrieval
+        $memoValue = Cache::memo()->many(['a', '1.1', '1', 2]);
+
+        $this->assertSame($cacheValue, $memoValue);
+    }
+
     public function test_null_values_are_memoized_when_retrieving_mulitple_values()
     {
         $live = Cache::getMultiple(['name.0', 'name.1']);