Skip to content

Commit aa55942

Browse files
It builds!
1 parent 75b9ccc commit aa55942

File tree

3 files changed

+28
-33
lines changed

3 files changed

+28
-33
lines changed

src/Optimizely.TestContainers.Commerce.Tests/StartupTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
using EPiServer.Commerce.Catalog;
2-
using EPiServer.Core;
1+
using EPiServer;
32
using EPiServer.Scheduler;
3+
using Mediachase.Commerce.Catalog;
44
using Microsoft.AspNetCore.Builder;
55
using Microsoft.AspNetCore.Hosting;
66
using Microsoft.AspNetCore.Http;

src/OptimizelyTestContainers.Tests/OptimizelyDataImporterTests.cs

Lines changed: 25 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -8,33 +8,26 @@ namespace OptimizelyTestContainers.Tests;
88

99
public class OptimizelyDataImporterTests
1010
{
11-
private readonly Mock<ILogger<OptimizelyDataImporter>> _mockLogger;
12-
private readonly Mock<IDataImporter> _mockDataImporter;
13-
private readonly Mock<IContentEvents> _mockContentEvents;
14-
15-
public OptimizelyDataImporterTests()
16-
{
17-
_mockLogger = new Mock<ILogger<OptimizelyDataImporter>>();
18-
_mockDataImporter = new Mock<IDataImporter>();
19-
_mockContentEvents = new Mock<IContentEvents>();
20-
}
11+
private readonly Mock<ILogger<OptimizelyDataImporter>> _mockLogger = new();
12+
private readonly Mock<IDataImporter> _mockDataImporter = new();
13+
private readonly Mock<IContentEvents> _mockContentEvents = new();
2114

2215
[Fact]
2316
public void Import_Should_Subscribe_To_PublishedContent_Event()
2417
{
2518
// Arrange
2619
var importer = new OptimizelyDataImporter(_mockLogger.Object, _mockDataImporter.Object, _mockContentEvents.Object);
27-
var importLog = new TransferLog();
20+
var mockImportLog = CreateMockImportLog();
2821
var tempFile = CreateTempImportFile();
2922

3023
_mockDataImporter.Setup(x => x.Import(It.IsAny<Stream>(), It.IsAny<ContentReference>(), It.IsAny<ImportOptions>()))
31-
.Returns(importLog);
24+
.Returns(mockImportLog);
3225

3326
// Act
3427
importer.Import(tempFile);
3528

3629
// Assert
37-
_mockContentEvents.VerifyAdd(x => x.PublishedContent += It.IsAny<EventHandler<ContentEventArgs>>(), Times.Once);
30+
_mockContentEvents.VerifyAdd(x => x.PublishedContent += It.IsAny<EventHandler<EPiServer.ContentEventArgs>>(), Times.Once);
3831

3932
// Cleanup
4033
File.Delete(tempFile);
@@ -45,11 +38,11 @@ public void Import_Should_Call_DataImporter_With_Correct_Options()
4538
{
4639
// Arrange
4740
var importer = new OptimizelyDataImporter(_mockLogger.Object, _mockDataImporter.Object, _mockContentEvents.Object);
48-
var importLog = new TransferLog();
41+
var mockImportLog = CreateMockImportLog();
4942
var tempFile = CreateTempImportFile();
5043

5144
_mockDataImporter.Setup(x => x.Import(It.IsAny<Stream>(), It.IsAny<ContentReference>(), It.IsAny<ImportOptions>()))
52-
.Returns(importLog);
45+
.Returns(mockImportLog);
5346

5447
// Act
5548
importer.Import(tempFile);
@@ -75,12 +68,11 @@ public void Import_Should_Throw_Exception_When_Errors_Present()
7568
{
7669
// Arrange
7770
var importer = new OptimizelyDataImporter(_mockLogger.Object, _mockDataImporter.Object, _mockContentEvents.Object);
78-
var importLog = new TransferLog();
79-
importLog.AddError("Test error message");
71+
var mockImportLog = CreateMockImportLog(errors: new List<string> { "Test error message" });
8072
var tempFile = CreateTempImportFile();
8173

8274
_mockDataImporter.Setup(x => x.Import(It.IsAny<Stream>(), It.IsAny<ContentReference>(), It.IsAny<ImportOptions>()))
83-
.Returns(importLog);
75+
.Returns(mockImportLog);
8476

8577
// Act & Assert
8678
var exception = Assert.Throws<Exception>(() => importer.Import(tempFile));
@@ -95,13 +87,11 @@ public void Import_Should_Log_Warnings_When_Present()
9587
{
9688
// Arrange
9789
var importer = new OptimizelyDataImporter(_mockLogger.Object, _mockDataImporter.Object, _mockContentEvents.Object);
98-
var importLog = new TransferLog();
99-
importLog.AddWarning("Test warning 1");
100-
importLog.AddWarning("Test warning 2");
90+
var mockImportLog = CreateMockImportLog(warnings: new List<string> { "Test warning 1", "Test warning 2" });
10191
var tempFile = CreateTempImportFile();
10292

10393
_mockDataImporter.Setup(x => x.Import(It.IsAny<Stream>(), It.IsAny<ContentReference>(), It.IsAny<ImportOptions>()))
104-
.Returns(importLog);
94+
.Returns(mockImportLog);
10595

10696
// Act
10797
importer.Import(tempFile);
@@ -134,11 +124,11 @@ public void Import_Should_Not_Log_Warnings_When_None_Present()
134124
{
135125
// Arrange
136126
var importer = new OptimizelyDataImporter(_mockLogger.Object, _mockDataImporter.Object, _mockContentEvents.Object);
137-
var importLog = new TransferLog();
127+
var mockImportLog = CreateMockImportLog();
138128
var tempFile = CreateTempImportFile();
139129

140130
_mockDataImporter.Setup(x => x.Import(It.IsAny<Stream>(), It.IsAny<ContentReference>(), It.IsAny<ImportOptions>()))
141-
.Returns(importLog);
131+
.Returns(mockImportLog);
142132

143133
// Act
144134
importer.Import(tempFile);
@@ -173,11 +163,11 @@ public void Import_Should_Complete_Successfully_With_No_Errors_Or_Warnings()
173163
{
174164
// Arrange
175165
var importer = new OptimizelyDataImporter(_mockLogger.Object, _mockDataImporter.Object, _mockContentEvents.Object);
176-
var importLog = new TransferLog();
166+
var mockImportLog = CreateMockImportLog();
177167
var tempFile = CreateTempImportFile();
178168

179169
_mockDataImporter.Setup(x => x.Import(It.IsAny<Stream>(), It.IsAny<ContentReference>(), It.IsAny<ImportOptions>()))
180-
.Returns(importLog);
170+
.Returns(mockImportLog);
181171

182172
// Act
183173
var exception = Record.Exception(() => importer.Import(tempFile));
@@ -195,4 +185,12 @@ private string CreateTempImportFile()
195185
File.WriteAllText(tempFile, "test content");
196186
return tempFile;
197187
}
198-
}
188+
189+
private ITransferLog CreateMockImportLog(List<string>? errors = null, List<string>? warnings = null)
190+
{
191+
var mockLog = new Mock<ITransferLog>();
192+
mockLog.SetupGet(x => x.Errors).Returns(errors ?? []);
193+
mockLog.SetupGet(x => x.Warnings).Returns(warnings ?? []);
194+
return mockLog.Object;
195+
}
196+
}

src/OptimizelyTestContainers.Tests/StartupTests.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
using EPiServer.Cms.UI.AspNetIdentity;
2-
using EPiServer.Core;
3-
using EPiServer.DataAccess;
1+
using EPiServer;
42
using EPiServer.Scheduler;
5-
using EPiServer.Web.Routing;
63
using Microsoft.AspNetCore.Builder;
74
using Microsoft.AspNetCore.Hosting;
85
using Microsoft.AspNetCore.Http;

0 commit comments

Comments
 (0)