Drop Go 1.23 support (#2065)

erikdubbelboer · web-flow · commit 4d25421ae55c · 2025-09-10T22:16:01.000+02:00
The Go team doesn't support this version anymore. This is required to
update our golang.org/x/... dependencies.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -25,5 +25,5 @@ jobs:
     - name: Run golangci-lint
       uses: golangci/golangci-lint-action@v8
       with:
-        version: v2.1.0
+        version: v2.4.0
         args: --verbose
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go-version: [1.23.x, 1.24.x]
+        go-version: [1.24.x]
         os: [ubuntu-latest, macos-latest, windows-latest, macos-14]
     runs-on: ${{ matrix.os }}
     steps:
diff --git a/.golangci.yml b/.golangci.yml
@@ -31,6 +31,7 @@ linters:
     - nestif
     - nlreturn
     - noctx
+    - noinlineerr
     - nonamedreturns
     - paralleltest
     - testableexamples
@@ -42,6 +43,7 @@ linters:
     - varnamelen
     - wrapcheck
     - wsl
+    - wsl_v5
   settings:
     gocritic:
       disabled-checks:
diff --git a/README.md b/README.md
@@ -654,7 +654,7 @@ This is an **unsafe** way, the result string and `[]byte` buffer share the same
 - _Which GO versions are supported by fasthttp?_
 
   We support the same versions the Go team supports.
-  Currently that is Go 1.23.x and newer.
+  Currently that is Go 1.24.x and newer.
   Older versions might work, but won't officially be supported.
 
 - _Please provide real benchmark data and server information_
diff --git a/client_test.go b/client_test.go
@@ -1947,6 +1947,7 @@ func testClientRequestSetTimeoutError(t *testing.T, c *Client, n int) {
 
 type readTimeoutConn struct {
 	net.Conn
+
 	wc chan struct{}
 	rc chan struct{}
 	t  time.Duration
@@ -2266,6 +2267,7 @@ func (r *readErrorConn) SetWriteDeadline(_ time.Time) error {
 
 type singleReadConn struct {
 	net.Conn
+
 	s string
 	n int
 }
@@ -2305,6 +2307,7 @@ func (r *singleReadConn) SetWriteDeadline(_ time.Time) error {
 
 type singleEchoConn struct {
 	net.Conn
+
 	b []byte
 	n int
 }
diff --git a/client_timing_test.go b/client_timing_test.go
@@ -18,6 +18,7 @@ import (
 
 type fakeClientConn struct {
 	net.Conn
+
 	ch chan struct{}
 	s  []byte
 	n  int
diff --git a/fasthttpproxy/dialer.go b/fasthttpproxy/dialer.go
@@ -54,6 +54,7 @@ type Dialer struct {
 	// A best effort is made to parse the string and errors are
 	// ignored.
 	httpproxy.Config
+
 	// Attempt to connect to both ipv4 and ipv6 addresses if set to true.
 	// By default, dial only to ipv4 addresses,
 	// since unfortunately ipv6 remains broken in many networks worldwide :)
diff --git a/fasthttputil/inmemory_listener_test.go b/fasthttputil/inmemory_listener_test.go
@@ -134,7 +134,7 @@ func testInmemoryListenerHTTP(t *testing.T, f func(t *testing.T, client *http.Cl
 
 	f(t, client)
 
-	ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*100)
+	ctx, cancel := context.WithTimeout(t.Context(), time.Millisecond*100)
 	defer cancel()
 	server.Shutdown(ctx) //nolint:errcheck
 }
diff --git a/go.mod b/go.mod
@@ -1,16 +1,16 @@
 module github.com/valyala/fasthttp
 
-go 1.23.0
+go 1.24.0
 
 toolchain go1.24.1
 
 require (
 	github.com/andybalholm/brotli v1.2.0
 	github.com/klauspost/compress v1.18.0
 	github.com/valyala/bytebufferpool v1.0.0
-	golang.org/x/crypto v0.41.0
-	golang.org/x/net v0.43.0
-	golang.org/x/sys v0.35.0
+	golang.org/x/crypto v0.42.0
+	golang.org/x/net v0.44.0
+	golang.org/x/sys v0.36.0
 )
 
-require golang.org/x/text v0.28.0 // indirect
+require golang.org/x/text v0.29.0 // indirect
diff --git a/go.sum b/go.sum
@@ -6,11 +6,11 @@ github.com/valyala/bytebufferpool v1.0.0 h1:GqA5TC/0021Y/b9FG4Oi9Mr3q7XYx6Kllzaw
 github.com/valyala/bytebufferpool v1.0.0/go.mod h1:6bBcMArwyJ5K/AmCkWv1jt77kVWyCJ6HpOuEn7z0Csc=
 github.com/xyproto/randomstring v1.0.5 h1:YtlWPoRdgMu3NZtP45drfy1GKoojuR7hmRcnhZqKjWU=
 github.com/xyproto/randomstring v1.0.5/go.mod h1:rgmS5DeNXLivK7YprL0pY+lTuhNQW3iGxZ18UQApw/E=
-golang.org/x/crypto v0.41.0 h1:WKYxWedPGCTVVl5+WHSSrOBT0O8lx32+zxmHxijgXp4=
-golang.org/x/crypto v0.41.0/go.mod h1:pO5AFd7FA68rFak7rOAGVuygIISepHftHnr8dr6+sUc=
-golang.org/x/net v0.43.0 h1:lat02VYK2j4aLzMzecihNvTlJNQUq316m2Mr9rnM6YE=
-golang.org/x/net v0.43.0/go.mod h1:vhO1fvI4dGsIjh73sWfUVjj3N7CA9WkKJNQm2svM6Jg=
-golang.org/x/sys v0.35.0 h1:vz1N37gP5bs89s7He8XuIYXpyY0+QlsKmzipCbUtyxI=
-golang.org/x/sys v0.35.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
-golang.org/x/text v0.28.0 h1:rhazDwis8INMIwQ4tpjLDzUhx6RlXqZNPEM0huQojng=
-golang.org/x/text v0.28.0/go.mod h1:U8nCwOR8jO/marOQ0QbDiOngZVEBB7MAiitBuMjXiNU=
+golang.org/x/crypto v0.42.0 h1:chiH31gIWm57EkTXpwnqf8qeuMUi0yekh6mT2AvFlqI=
+golang.org/x/crypto v0.42.0/go.mod h1:4+rDnOTJhQCx2q7/j6rAN5XDw8kPjeaXEUR2eL94ix8=
+golang.org/x/net v0.44.0 h1:evd8IRDyfNBMBTTY5XRF1vaZlD+EmWx6x8PkhR04H/I=
+golang.org/x/net v0.44.0/go.mod h1:ECOoLqd5U3Lhyeyo/QDCEVQ4sNgYsqvCZ722XogGieY=
+golang.org/x/sys v0.36.0 h1:KVRy2GtZBrk1cBYA7MKu5bEZFxQk4NIDV6RLVcC8o0k=
+golang.org/x/sys v0.36.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
+golang.org/x/text v0.29.0 h1:1neNs90w9YzJ9BocxfsQNHKuAT4pkghyXc4nhZ6sJvk=
+golang.org/x/text v0.29.0/go.mod h1:7MhJOA9CD2qZyOKYazxdYMF85OwPdEr9jTtBpO7ydH4=
diff --git a/header.go b/header.go
@@ -47,9 +47,10 @@ type header struct {
 // ResponseHeader instance MUST NOT be used from concurrently running
 // goroutines.
 type ResponseHeader struct {
-	noCopy noCopy
 	header
 
+	noCopy noCopy
+
 	statusMessage   []byte
 	contentEncoding []byte
 	server          []byte
@@ -67,9 +68,10 @@ type ResponseHeader struct {
 // RequestHeader instance MUST NOT be used from concurrently running
 // goroutines.
 type RequestHeader struct {
-	noCopy noCopy
 	header
 
+	noCopy noCopy
+
 	method     []byte
 	requestURI []byte
 	host       []byte
diff --git a/http.go b/http.go
@@ -346,6 +346,7 @@ type ReadCloserWithError interface {
 
 type closeReader struct {
 	io.Reader
+
 	closeFunc func(err error) error
 }
 
diff --git a/server.go b/server.go
@@ -2636,6 +2636,7 @@ func (s *Server) releaseHijackConn(hjc *hijackConn) {
 
 type hijackConn struct {
 	net.Conn
+
 	r io.Reader
 	s *Server
 }
@@ -2866,6 +2867,7 @@ var fakeServer = &Server{
 
 type fakeAddrer struct {
 	net.Conn
+
 	laddr net.Addr
 	raddr net.Addr
 }
diff --git a/server_race_test.go b/server_race_test.go
@@ -4,9 +4,10 @@ package fasthttp
 
 import (
 	"context"
-	"github.com/valyala/fasthttp/fasthttputil"
 	"math"
 	"testing"
+
+	"github.com/valyala/fasthttp/fasthttputil"
 )
 
 func TestServerDoneRace(t *testing.T) {
@@ -39,7 +40,7 @@ func TestServerDoneRace(t *testing.T) {
 		"GET / HTTP/1.1\r\nHost: go.dev\r\n\r\n")); err != nil {
 		t.Fatal(err)
 	}
-	ctx, cancelFunc := context.WithCancel(context.Background())
+	ctx, cancelFunc := context.WithCancel(t.Context())
 	cancelFunc()
 
 	s.ShutdownWithContext(ctx)
diff --git a/server_test.go b/server_test.go
@@ -525,6 +525,7 @@ func TestRequestCtxIsTLS(t *testing.T) {
 	// overridden tls.Conn
 	ctx.c = &struct {
 		*tls.Conn
+
 		fooBar bool
 	}{}
 	if !ctx.IsTLS() {
@@ -3471,6 +3472,7 @@ func TestServerCustomRemoteAddr(t *testing.T) {
 
 type readWriterRemoteAddr struct {
 	net.Conn
+
 	rw   io.ReadWriteCloser
 	addr net.Addr
 }
@@ -3917,7 +3919,7 @@ func TestShutdownWithContext(t *testing.T) {
 	}()
 
 	time.Sleep(1 * time.Millisecond * 500)
-	ctx, cancel := context.WithTimeout(context.Background(), 500*time.Millisecond)
+	ctx, cancel := context.WithTimeout(t.Context(), 500*time.Millisecond)
 	defer cancel()
 	shutdownErr := make(chan error)
 	go func() {
@@ -4373,6 +4375,7 @@ func verifyResponse(t *testing.T, r *bufio.Reader, expectedStatusCode int, expec
 
 type readWriter struct {
 	net.Conn
+
 	r bytes.Buffer
 	w bytes.Buffer
 }
diff --git a/server_timing_test.go b/server_timing_test.go
@@ -193,6 +193,7 @@ func BenchmarkServerTimeoutError(b *testing.B) {
 
 type fakeServerConn struct {
 	net.TCPConn
+
 	ln            *fakeListener
 	requestsCount int
 	pos           int

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ func testInmemoryListenerHTTP(t testing.T, f func(t testing.T, client *http.Cl`
`134`	`134`
`135`	`135`	`f(t, client)`
`136`	`136`
`137`		`- ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*100)`
	`137`	`+ ctx, cancel := context.WithTimeout(t.Context(), time.Millisecond*100)`
`138`	`138`	`defer cancel()`
`139`	`139`	`server.Shutdown(ctx) //nolint:errcheck`
`140`	`140`	`}`