http.go: close form file if copyZeroAlloc fails (#1498)

alexandear · web-flow · commit 4e8c92b2ef78 · 2023-03-03T20:48:32.000+01:00
diff --git a/http.go b/http.go
@@ -992,6 +992,7 @@ func WriteMultipartForm(w io.Writer, f *multipart.Form, boundary string) error {
 				return fmt.Errorf("cannot open form file %q (%q): %w", k, fv.Filename, err)
 			}
 			if _, err = copyZeroAlloc(vw, fh); err != nil {
+				_ = fh.Close()
 				return fmt.Errorf("error when copying form file %q (%q): %w", k, fv.Filename, err)
 			}
 			if err = fh.Close(); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -992,6 +992,7 @@ func WriteMultipartForm(w io.Writer, f *multipart.Form, boundary string) error {`
`992`	`992`	`return fmt.Errorf("cannot open form file %q (%q): %w", k, fv.Filename, err)`
`993`	`993`	`}`
`994`	`994`	`if _, err = copyZeroAlloc(vw, fh); err != nil {`
	`995`	`+ _ = fh.Close()`
`995`	`996`	`return fmt.Errorf("error when copying form file %q (%q): %w", k, fv.Filename, err)`
`996`	`997`	`}`
`997`	`998`	`if err = fh.Close(); err != nil {`