Fix up logging for better details

Author: vanZeben

BeatSaberOnline/Data/Steam/LobbyInfo.cs

@@ -134,6 +134,10 @@ public override int GetHashCode()
         {
             return unchecked(this.LobbyID.m_SteamID.GetHashCode() * 17 + this.HostName.GetHashCode());
         }
+        public string ToString()
+        {
+            return $"lobbyId={LobbyID},hostname={HostName},status={Status},joinable={Joinable},UsedSlots={UsedSlots},TotalSlots={TotalSlots},MaxSlots={MaxSlots},CurrentSongId={CurrentSongId},CurrentSongDifficulty={CurrentSongDifficulty},CurretnSongName={CurrentSongName},Screen={Screen},gameplayModifiers={_gameplayModifiers}";
+        }
 
         public string Serialize()
         {

BeatSaberOnline/Data/Steam/SteamAPI.cs

@@ -245,6 +245,7 @@ public static void FinishSong()
         private static void SendLobbyInfo(bool reqHost = false)
         {
              if (reqHost && !IsHost()) return;
+             Logger.Debug($"Sending {_lobbyInfo.ToString()}");
              SteamMatchmaking.SetLobbyData(_lobbyInfo.LobbyID, "LOBBY_INFO", _lobbyInfo.Serialize());
         }
         public static void IncreaseSlots()

BeatSaberOnline/Data/Steam/SteamCallbacks.cs

@@ -49,21 +49,25 @@ public void OnLobbyDataUpdate(LobbyDataUpdate_t pCallback)
                 LobbyInfo info = new LobbyInfo(SteamMatchmaking.GetLobbyData(new CSteamID(pCallback.m_ulSteamIDLobby), "LOBBY_INFO"));
 
                 if (pCallback.m_ulSteamIDLobby == 0) return;
-               
+                Logger.Debug($"Received: {info.ToString()}");
                 if (pCallback.m_ulSteamIDLobby == SteamAPI.getLobbyID().m_SteamID)
                 {
+                    SteamAPI.UpdateLobbyInfo(info);
                     if (DidScreenChange(info.Screen, LobbyInfo.SCREEN_TYPE.WAITING))
                     {
+                        currentScreen = info.Screen;
                         Logger.Debug($"Song has been selected, going to the waiting screen");
                         WaitingMenu.Instance.Present();
                     }
                     else if (DidScreenChange(info.Screen, LobbyInfo.SCREEN_TYPE.MENU))
                     {
+                        currentScreen = info.Screen;
                         Logger.Debug($"Song has finished, updating state to menu");
                         GameController.Instance.SongFinished(null, null, null, null);
                     }
                     else if (DidScreenChange(info.Screen, LobbyInfo.SCREEN_TYPE.PLAY_SONG))
                     {
+                        currentScreen = info.Screen;
                         Logger.Debug($"Host requested to play the current song {info.CurrentSongId}");
 
                         LevelSO song = SongListUtils.GetInstalledSong();
@@ -75,9 +79,6 @@ public void OnLobbyDataUpdate(LobbyDataUpdate_t pCallback)
                         SteamAPI.ClearPlayerReady(new CSteamID(SteamAPI.GetUserID()), true);
                         SongListUtils.StartSong(song, SteamAPI.GetSongDifficulty(), info.GameplayModifiers);
                     }
-
-                    SteamAPI.UpdateLobbyInfo(info);
-                    currentScreen = info.Screen;
                 } else
                 {
                     SteamAPI.SetOtherLobbyData(pCallback.m_ulSteamIDLobby, info);

BeatSaberOnline/Views/Menus/WaitingMenu.cs

@@ -82,21 +82,12 @@ public static void Init()
 
         private static void ReadyUp(LevelSO song)
         {
-            try
-            {
-                Data.Logger.Info("RU queued song " + (queuedSong == null ? "is null" : "is not null"));
-                Data.Logger.Info("RU song " + (queuedSong == null ? "is null" : "is not null"));
-
-                if (queuedSong != null || (queuedSong == null && song == null)) { return; }
-                if (queuedSong == null && song != null)
-                {
-                    queuedSong = song;
-                    SteamAPI.SetReady();
-                    PreviewPlayer.CrossfadeTo(song.audioClip, song.previewStartTime, song.previewDuration);
-                }
-            } catch (Exception e)
+            if (queuedSong != null || (queuedSong == null && song == null)) { return; }
+            if (queuedSong == null && song != null)
             {
-                Data.Logger.Error(e);
+                queuedSong = song;
+                SteamAPI.SetReady();
+                PreviewPlayer.CrossfadeTo(song.audioClip, song.previewStartTime, song.previewDuration);
             }
         }
         public static void RefreshData(LevelSO song = null)
@@ -164,7 +155,6 @@ public static void LevelDownloaded(string hash)
             {
                 Logger.Error(e);
             }
-            
         }
     }
 }