Linting media queries #480
Unanswered
amorriscode
asked this question in
Q&A
Replies: 1 comment
-
You're right in that there's currently no validation for queries. Definitely open to adding this though. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Howdy!
We've been using Vanilla Extract successfully in production for a while now. Today we hit a little snag.
We wrote an invalid media query and it wasn't caught by the linter. In the end, this meant a CSS file was generated that had invalid syntax.
When using an online CSS validator, this is what we noticed:
If you write a media query like this, you can recreate the issue:
So it's clear that the strings aren't being linted. This might not even be a Vanilla Extract issue (there was a post on CSSType about media queries). Do you have any ideas on how something like this could be avoided? Is this a config issue on our end?
Beta Was this translation helpful? Give feedback.
All reactions