Skip to content

Commit 4d0b2d7

Browse files
authored
Fix Gradle 6.0 deprecation warnings. (#155)
1 parent 97288be commit 4d0b2d7

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/main/groovy/com/vanniktech/android/junit/jacoco/GenerationPlugin.groovy

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,11 @@ class GenerationPlugin implements Plugin<Project> {
6767
html.enabled = true
6868
}
6969

70-
classDirectories = subProject.fileTree(
70+
getClassDirectories().from(subProject.fileTree(
7171
dir: subProject.buildDir,
7272
includes: ['**/classes/**/main/**'],
7373
excludes: getExcludes(extension)
74-
)
74+
))
7575

7676
final def coverageSourceDirs = [
7777
'src/main/clojure',
@@ -81,9 +81,9 @@ class GenerationPlugin implements Plugin<Project> {
8181
'src/main/scala'
8282
]
8383

84-
additionalSourceDirs = subProject.files(coverageSourceDirs)
85-
sourceDirectories = subProject.files(coverageSourceDirs)
86-
executionData = subProject.files("${subProject.buildDir}/jacoco/test.exec")
84+
getAdditionalSourceDirs().from(subProject.files(coverageSourceDirs))
85+
getSourceDirectories().from(subProject.files(coverageSourceDirs))
86+
getExecutionData().from(subProject.files(subProject.files("${subProject.buildDir}/jacoco/test.exec")))
8787

8888
if (mergeTask != null) {
8989
mergeTask.executionData.setFrom(executionData.files + mergeTask.executionData.files)
@@ -124,7 +124,6 @@ class GenerationPlugin implements Plugin<Project> {
124124
}
125125

126126
variants.all { variant ->
127-
128127
def productFlavorName = variant.getFlavorName()
129128
def buildType = variant.getBuildType()
130129
def buildTypeName = buildType.name
@@ -203,11 +202,11 @@ class GenerationPlugin implements Plugin<Project> {
203202
}
204203
}
205204

206-
classDirectories = subProject.fileTree(
205+
getClassDirectories().from(subProject.fileTree(
207206
dir: subProject.buildDir,
208207
includes: classPaths,
209208
excludes: getExcludes(extension)
210-
)
209+
))
211210

212211
final def coverageSourceDirs = [
213212
"src/main/clojure",
@@ -230,9 +229,9 @@ class GenerationPlugin implements Plugin<Project> {
230229
coverageSourceDirs.add("src/$productFlavorName/scala")
231230
}
232231

233-
additionalSourceDirs = subProject.files(coverageSourceDirs)
234-
sourceDirectories = subProject.files(coverageSourceDirs)
235-
executionData = subProject.files("${subProject.buildDir}/jacoco/${jvmTestTaskName}.exec")
232+
getAdditionalSourceDirs().from(subProject.files(coverageSourceDirs))
233+
getSourceDirectories().from(subProject.files(coverageSourceDirs))
234+
getExecutionData().from(subProject.files("${subProject.buildDir}/jacoco/${jvmTestTaskName}.exec"))
236235

237236
if (combined) {
238237
// add instrumentation coverage execution data
@@ -305,9 +304,9 @@ class GenerationPlugin implements Plugin<Project> {
305304
}
306305

307306
// Start with empty collections.
308-
classDirectories = project.files()
309-
additionalSourceDirs = project.files()
310-
sourceDirectories = project.files()
307+
getClassDirectories().from(project.files())
308+
getAdditionalSourceDirs().from(project.files())
309+
getSourceDirectories().from(project.files())
311310
}
312311

313312
return [mergeTask, mergedReportTask]

src/test/groovy/com/vanniktech/android/junit/jacoco/GenerationTest.groovy

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -492,8 +492,9 @@ class GenerationTest {
492492
assert sourceDirectories.contains(project.file("src/main/$it"))
493493
}
494494

495-
assert classDirectories.getFrom().first().dir == project.file("build/")
496-
assert contentEquals(classDirectories.getFrom().first().includes, ['**/classes/**/main/**'])
495+
assert classDirectories.size() == 2 // First one is empty and the second fileTree is the one we plant.
496+
assert classDirectories.getFrom()[1].dir == project.file("build/")
497+
assert contentEquals(classDirectories.getFrom()[1].includes, ['**/classes/**/main/**'])
497498

498499
assert reports.xml.enabled
499500
assert reports.csv.enabled

0 commit comments

Comments
 (0)