Skip to content

Commit 739b0e0

Browse files
vRallevvanniktech
authored andcommitted
Use Jacoco 0.8.2 by default (#129)
I don't see why the plugin should use a 4 year old Jacoco version by default. The latest plugin works better with Kotlin and contains many other good fixes. Good default values are important in my opinion.
1 parent 031f47f commit 739b0e0

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ Those are all available configurations - shown with default values and their typ
7171

7272
```groovy
7373
junitJacoco {
74-
jacocoVersion = '0.7.2.201409121644' // type String
74+
jacocoVersion = '0.8.2' // type String
7575
ignoreProjects = [] // type String array
7676
excludes // type String List
7777
includeNoLocationClasses = false // type boolean

src/main/groovy/com/vanniktech/android/junit/jacoco/JunitJacocoExtension.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class JunitJacocoExtension {
99
* define the version of jacoco which should be used
1010
* @since 0.3.0
1111
*/
12-
String jacocoVersion = '0.7.2.201409121644'
12+
String jacocoVersion = '0.8.2'
1313

1414
/**
1515
* subprojects that should be ignored

src/test/groovy/com/vanniktech/android/junit/jacoco/GenerationTest.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ class GenerationTest {
169169
private void assertJacocoAndroidWithFlavors(final Project project) {
170170
assert project.plugins.hasPlugin(JacocoPlugin)
171171

172-
assert project.jacoco.toolVersion == '0.7.2.201409121644'
172+
assert project.jacoco.toolVersion == '0.8.2'
173173

174174
assertTask(project, 'red', 'debug')
175175
assertTask(project, 'red', 'release')
@@ -220,7 +220,7 @@ class GenerationTest {
220220
private void assertJacocoAndroidWithoutFlavors(final Project project) {
221221
assert project.plugins.hasPlugin(JacocoPlugin)
222222

223-
assert project.jacoco.toolVersion == '0.7.2.201409121644'
223+
assert project.jacoco.toolVersion == '0.8.2'
224224

225225
final def debugTask = project.tasks.findByName('jacocoTestReportDebug')
226226

@@ -298,7 +298,7 @@ class GenerationTest {
298298
private void assertJacocoJava(final Project project) {
299299
assert project.plugins.hasPlugin(JacocoPlugin)
300300

301-
assert project.jacoco.toolVersion == '0.7.2.201409121644'
301+
assert project.jacoco.toolVersion == '0.8.2'
302302

303303
final def task = project.tasks.findByName('jacocoTestReport')
304304

src/test/groovy/com/vanniktech/android/junit/jacoco/JunitJacocoExtensionTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class JunitJacocoExtensionTest {
66
@Test void defaults() {
77
def extension = new JunitJacocoExtension()
88

9-
assert extension.jacocoVersion == '0.7.2.201409121644'
9+
assert extension.jacocoVersion == '0.8.2'
1010
assert extension.ignoreProjects.size() == 0
1111
assert extension.excludes == null
1212
assert !extension.includeNoLocationClasses

0 commit comments

Comments
 (0)