Skip to content

Commit be137b8

Browse files
authored
Add a few more default excludes. (#58)
1 parent 2b8737b commit be137b8

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

src/main/groovy/com/vanniktech/android/junit/jacoco/Generation.groovy

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,11 +153,15 @@ class Generation implements Plugin<Project> {
153153
}
154154

155155
static List<String> getExcludes(final JunitJacocoExtension extension) {
156-
extension.excludes == null ? ['**/R.class',
156+
extension.excludes == null ? [
157+
'**/R.class',
158+
'**/R2.class', // ButterKnife Gradle Plugin
157159
'**/R$*.class',
160+
'**/R2$*.class', // ButterKnife Gradle Plugin
158161
'**/*$$*',
159-
'**/*$ViewInjector*.*',
160-
'**/*$ViewBinder*.*',
162+
'**/*$ViewInjector*.*', // Older ButterKnife Versions
163+
'**/*$ViewBinder*.*', // Older ButterKnife Versions
164+
'**/*_ViewBinding*.*', // Newer ButterKnife Versions
161165
'**/BuildConfig.*',
162166
'**/Manifest*.*',
163167
'**/*$Lambda$*.*', // Jacoco can not handle several "$" in class name.

src/test/groovy/com/vanniktech/android/junit/jacoco/GenerationTest.groovy

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,12 +272,15 @@ public class GenerationTest {
272272
public void getExcludesDefault() {
273273
final def excludes = Generation.getExcludes(new JunitJacocoExtension())
274274

275-
assert excludes.size == 15
275+
assert excludes.size == 18
276276
assert excludes.contains('**/R.class')
277+
assert excludes.contains('**/R2.class')
277278
assert excludes.contains('**/R$*.class')
279+
assert excludes.contains('**/R2$*.class')
278280
assert excludes.contains('**/*$$*')
279281
assert excludes.contains('**/*$ViewInjector*.*')
280282
assert excludes.contains('**/*$ViewBinder*.*')
283+
assert excludes.contains('**/*_ViewBinding*.*')
281284
assert excludes.contains('**/BuildConfig.*')
282285
assert excludes.contains('**/Manifest*.*')
283286
assert excludes.contains('**/*$Lambda$*.*')

0 commit comments

Comments
 (0)