Improve assertions, update copyrights & formatting

Replace bare assert(0) usages with assert(false && "<message>") or assert(false) to provide clearer diagnostics and mark unreachable cases. Update copyright years to include 2026 across several GD32/HAL files. Apply minor whitespace, include ordering and formatting fixes, adjust NDEBUG handling in pixel DMX JSON code, and small API/indentation cleanups. Affected files include gd32, hal and pixeldmx source/header files.

Author: vanvught

lib-displayudf/include/displayudf.h

@@ -33,7 +33,7 @@
 #include "firmwareversion.h"
 #if !defined(NO_EMAC)
 #include "network.h"
-#include "net/protocol/dhcp.h"
+#include "core/protocol/dhcp.h"
 #endif
 #if defined(NODE_ARTNET_MULTI)
 #define NODE_ARTNET
@@ -57,13 +57,13 @@
 #if defined(RDM_RESPONDER) || defined(OUTPUT_DMX_MONITOR) || defined(OUTPUT_DMX_PCA9685) || defined(OUTPUT_DMX_PIXEL) || defined(OUTPUT_DMX_TLC59711)
 #define HAVE_DMX_START_ADDRESS
 #endif
- #include "firmware/debug/debug_debug.h"
+#include "firmware/debug/debug_debug.h"
 
 namespace displayudf
 {
 inline constexpr uint32_t kLabelMaxRows = 6;
 
-enum class Labels: uint8_t
+enum class Labels : uint8_t
 {
     kTitle,
     kBoardname,
@@ -86,7 +86,7 @@ enum class Labels: uint8_t
     UNIVERSE_PORT_D,
 #endif
 #if defined(NODE_ARTNET) || defined(NODE_ARTNET_MULTI)
-    kDestinationIpPortA, 
+    kDestinationIpPortA,
 #if (DMX_MAX_PORTS > 1)
     kDestinationIpPortB,
 #endif
@@ -178,40 +178,39 @@ class DisplayUdf final : public Display
     void ShowIpAddress()
     {
         ClearEndOfLine();
-        Printf(labels_[static_cast<uint32_t>(displayudf::Labels::kIp)], "" IPSTR "/%d %c", IP2STR(net::GetPrimaryIp()), net::GetNetmaskCIDR(),
-               network::iface::AddressingMode());
+        Printf(labels_[static_cast<uint32_t>(displayudf::Labels::kIp)], "" IPSTR "/%d %c", IP2STR(network::GetPrimaryIp()), network::GetNetmaskCIDR(), network::iface::AddressingMode());
     }
 
     void ShowNetmask()
     {
         ClearEndOfLine();
-        Printf(labels_[static_cast<uint32_t>(displayudf::Labels::kNetmask)], "N: " IPSTR "", IP2STR(net::GetNetmask()));
+        Printf(labels_[static_cast<uint32_t>(displayudf::Labels::kNetmask)], "N: " IPSTR "", IP2STR(network::GetNetmask()));
         ShowIpAddress();
     }
 
     void ShowGatewayIp()
     {
         ClearEndOfLine();
-        Printf(labels_[static_cast<uint32_t>(displayudf::Labels::kDefaultGateway)], "G: " IPSTR "", IP2STR(net::GetGatewayIp()));
+        Printf(labels_[static_cast<uint32_t>(displayudf::Labels::kDefaultGateway)], "G: " IPSTR "", IP2STR(network::GetGatewayIp()));
     }
 
     void ShowHostName()
     {
         ClearEndOfLine();
-        Write(labels_[static_cast<uint32_t>(displayudf::Labels::kHostname)],  network::iface::GetHostName());
+        Write(labels_[static_cast<uint32_t>(displayudf::Labels::kHostname)], network::iface::HostName());
     }
 
-    void ShowDhcpStatus(net::dhcp::State state)
+    void ShowDhcpStatus(network::dhcp::State state)
     {
         switch (state)
         {
-            case net::dhcp::State::STATE_OFF:
+            case network::dhcp::State::kOff:
                 break;
-            case net::dhcp::State::STATE_RENEWING:
+            case network::dhcp::State::kRenewing:
                 ClearEndOfLine();
                 Printf(labels_[static_cast<uint32_t>(displayudf::Labels::kIp)], "DHCP renewing");
                 break;
-            case net::dhcp::State::STATE_BOUND:
+            case network::dhcp::State::kBound:
                 break;
             default:
                 break;
@@ -248,4 +247,4 @@ class DisplayUdf final : public Display
     inline static DisplayUdf* s_this;
 };
 
-#endif  // DISPLAYUDF_H_
+#endif // DISPLAYUDF_H_

lib-dmx/include/dmxconfigudp.h

@@ -106,7 +106,7 @@ class DmxConfigUdp
         s_this = this;
 
         assert(handle_ == -1);
-        handle_ = net::udp::Begin(kUdpPort, DmxConfigUdp::StaticCallbackFunction);
+        handle_ = network::udp::Begin(kUdpPort, DmxConfigUdp::StaticCallbackFunction);
 
         DEBUG_EXIT();
     }
@@ -119,7 +119,7 @@ class DmxConfigUdp
         DEBUG_ENTRY();
 
         assert(handle_ != -1);
-        net::udp::End(kUdpPort);
+        network::udp::End(kUdpPort);
         handle_ = -1;
 
         s_this = nullptr;

lib-dmxnode/include/dmxnode_nodetype.h

@@ -47,7 +47,7 @@ enum class NodeType
 
 inline constexpr const char* kNodeTypeNames[static_cast<uint32_t>(NodeType::kUndefined)] = 
 {
-	"Artnet",    
+	"Art-Net",    
 	"sACN E1.31", 
 	"DDP Display", 
 	"PixelPusher",

lib-dmxnode/include/dmxnode_outputtype.h

@@ -1,7 +1,7 @@
 /**
  * @file dmxnode_outputtype.h
  */
-/* Copyright (C) 2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2025-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -21,12 +21,11 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
- 
 
 #ifndef DMXNODE_OUTPUTTYPE_H_
 #define DMXNODE_OUTPUTTYPE_H_
 
- #include <cstdint>
+#include <cstdint>
 
 namespace dmxnode
 {
@@ -49,23 +48,8 @@ enum class OutputType
     kUndefined
 };
 
-inline constexpr const char* kOutputTypeNames[static_cast<uint32_t>(OutputType::kUndefined)] = 
-{
-	"DMX", 
-	"DMX/RDM", 
-	"Pixel",
-	"Pixel/DMX", 
-	"PWM", 
-	"RGB Panel", 
-	"Serial", 
-	"OSC", 
-	"Monitor", 
-	"Stepper", 
-	"Player", 
-	"Art-Net", 
-	"Timecode",
-	"None"
-};
+inline constexpr const char* kOutputTypeNames[static_cast<uint32_t>(OutputType::kUndefined)] = {
+    "DMX", "DMX/RDM", "Pixel", "Pixel/DMX", "PWM", "RGB Panel", "Serial", "OSC", "Monitor", "Stepper", "Player", "Art-Net", "Timecode", "None"};
 
 inline const char* GetOutputType(OutputType type)
 {
@@ -76,7 +60,7 @@ inline const char* GetOutputType(OutputType type)
 
     return "Undefined";
 }
-}  // namespace dmxnode
+} // namespace dmxnode
 
 #if defined(OUTPUT_DMX_SEND) || defined(OUTPUT_DMX_SEND_MULTI)
 #define DMXNODE_OUTPUT_DMX
@@ -195,4 +179,4 @@ inline constexpr auto kOutputType = OutputType::kUndefined;
 #endif
 } // namespace dmxnode
 
-#endif  // DMXNODE_OUTPUTTYPE_H_
+#endif // DMXNODE_OUTPUTTYPE_H_

lib-gd32/include/gd32_dma.h

@@ -2,7 +2,7 @@
  * @file gd32_dma.h
  *
  */
-/* Copyright (C) 2024-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2024-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -63,7 +63,7 @@ template <uint32_t dma_periph, dma_channel_enum channelx, uint32_t flag> inline
             interrupt_enable = DMA_CHCTL(dma_periph, channelx) & DMA_CHXCTL_ERRIE;
             break;
         default:
-            [[unlikely]] assert(0);
+            [[unlikely]] assert(false && "Invalid flag");
     }
 
     return interrupt_flag && interrupt_enable;
@@ -97,7 +97,7 @@ template <uint32_t dma_periph, dma_channel_enum channelx, uint32_t flag> inline
             interrupt_enable = DMA_CHCTL(dma_periph, channelx) & gif_enable;
             break;
         default:
-            [[unlikely]] assert(0);
+            [[unlikely]] assert(false && "Invalid flag");
     }
 
     return (interrupt_flag && interrupt_enable);
@@ -132,7 +132,7 @@ template <uint32_t dma_periph, dma_channel_enum channelx, uint32_t flag> inline
                 interrupt_enable = (DMA_CHCTL(dma_periph, channelx) & DMA_CHXCTL_FTFIE);
                 break;
             default:
-                [[unlikely]] assert(0);
+                [[unlikely]] assert(false && "Invalid flag");
                 break;
         }
     }
@@ -162,13 +162,13 @@ template <uint32_t dma_periph, dma_channel_enum channelx, uint32_t flag> inline
                 interrupt_enable = DMA_CHCTL(dma_periph, channelx) & DMA_CHXCTL_FTFIE;
                 break;
             default:
-                [[unlikely]] assert(0);
+                [[unlikely]] assert(false && "Invalid flag");
                 break;
         }
     }
     else
     {
-        [[unlikely]] assert(0);
+        [[unlikely]] assert(false && "Invalid channelx");
     }
 
     return (interrupt_flag && interrupt_enable);

lib-gd32/include/gd32_dma_memcpy32.h

@@ -2,7 +2,7 @@
  * @file gd32_dma_memcpy32.h
  *
  */
-/* Copyright (C) 2024-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2024-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -37,10 +37,10 @@ void Init();
 
 inline void StartDma(const void* destination, const void* source, uint32_t length)
 {
+#if !defined(GD32F4XX)
     assert((reinterpret_cast<uint32_t>(source) & 0x3) == 0);
     assert((reinterpret_cast<uint32_t>(destination) & 0x3) == 0);
 
-#if !defined(GD32F4XX)
     uint32_t dma_chctl = DMA_CHCTL(DMA0, DMA_CH3);
     dma_chctl &= ~DMA_CHXCTL_CHEN;
     DMA_CHCTL(DMA0, DMA_CH3) = dma_chctl;
@@ -52,6 +52,9 @@ inline void StartDma(const void* destination, const void* source, uint32_t lengt
     dma_chctl |= (DMA_CHXCTL_CHEN | DMA_INT_FTF);
     DMA_CHCTL(DMA0, DMA_CH3) = dma_chctl;
 #else
+    assert((reinterpret_cast<uint32_t>(source) & 0xF) == 0);
+    assert((reinterpret_cast<uint32_t>(destination) & 0xF) == 0);
+
     uint32_t dma_chctl = DMA_CHCTL(DMA1, DMA_CH0);
     dma_chctl &= ~DMA_CHXCTL_CHEN;
     DMA_CHCTL(DMA1, DMA_CH0) = dma_chctl;

lib-gd32/include/gd32_gpio.h

@@ -196,7 +196,7 @@ inline uint32_t Gd32GpioToPeriph(uint32_t gpio)
             break;
 #endif
         default:
-            assert(0);
+            assert(false && "Invalid gpio");
             return 0;
             break;
     }

lib-gd32/src/f/gd32_dma_memcpy32.cpp

@@ -2,7 +2,7 @@
  * @file gd32_dma_memcpy32.cpp
  *
  */
-/* Copyright (C) 2024-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2024-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -23,7 +23,6 @@
  * THE SOFTWARE.
  */
 
-#include "gd32.h"
 #include "gd32_dma.h"
 
 namespace dma::memcpy32
@@ -49,10 +48,12 @@ void Init()
     dma_circulation_disable(DMA0, DMA_CH3);
     dma_memory_to_memory_enable(DMA0, DMA_CH3);
 
+#if !defined(DMA_MEMCPY32_DISABLE_IRQ)
     Gd32DmaInterruptFlagClear<DMA0, DMA_CH3, (DMA_INT_FLAG_FTF | DMA_INT_FLAG_G)>();
 
     NVIC_SetPriority(DMA0_Channel3_IRQn, 0);
     NVIC_EnableIRQ(DMA0_Channel3_IRQn);
+#endif
 #else
     rcu_periph_clock_enable(RCU_DMA1);
     dma_deinit(DMA1, DMA_CH0);
@@ -73,10 +74,12 @@ void Init()
 
     dma_multi_data_mode_init(DMA1, DMA_CH0, &dma_init_parameter);
 
-    Gd32DmaInterruptFlagClear<DMA1, DMA_CH3, (DMA_INT_FLAG_FTF | DMA_INT_FLAG_TAE)>();
+#if !defined(DMA_MEMCPY32_DISABLE_IRQ)
+    Gd32DmaInterruptFlagClear<DMA1, DMA_CH0, (DMA_INT_FLAG_FTF | DMA_INT_FLAG_TAE)>();
 
     NVIC_SetPriority(DMA1_Channel0_IRQn, 0);
     NVIC_EnableIRQ(DMA1_Channel0_IRQn);
 #endif
+#endif
 }
 } // namespace dma::memcpy32

lib-gd32/src/f/gd32_i2c.cpp

@@ -2,7 +2,7 @@
  * @file gd32_i2c.cpp
  *
  */
-/* Copyright (C) 2021-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2021-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -345,7 +345,7 @@ static void GpioConfigI2c()
     }
     else
     {
-        assert(0);
+        assert(false && "Invalid I2C_REMAP");
     }
 #endif
 #else
@@ -380,7 +380,7 @@ static void GpioConfigI2c1()
     }
     else
     {
-        assert(0);
+        assert(false && "Invalid I2C1_REMAP");
     }
 #endif
 #else

lib-gd32/src/gd32_bkp.cpp

@@ -2,7 +2,7 @@
  * @file gd32_bkp.cpp
  *
  */
-/* Copyright (C) 2022-2025 by Arjan van Vught mailto:info@gd32-dmx.org
+/* Copyright (C) 2022-2026 by Arjan van Vught mailto:info@gd32-dmx.org
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -38,7 +38,7 @@ void bkp_data_write(bkp_data_register_enum register_number, uint16_t data)
             RTC_BKP1 = static_cast<uint32_t>(data);
             break;
         default:
-            assert(0);
+            assert(false && "Invalid register_number");
             break;
     }
 }
@@ -54,11 +54,10 @@ uint16_t bkp_data_read(bkp_data_register_enum register_number)
             return RTC_BKP1;
             break;
         default:
-            assert(0);
+            assert(false && "Invalid register_number");
             break;
     }
 
-    assert(0);
     return 0;
 }
 #endif