Skip to content

Commit 08b14ed

Browse files
committed
Add debug include and update copyright
Enable debug support and clean up formatting: add an unconditional #undef NDEBUG and include firmware/debug/debug_debug.h in json/pixeldmxparams.cpp to enable assertions/debug helpers; update copyright year to 2026 in pixeldmxparamsrdm.cpp, consolidate NDEBUG handling behind DEBUG_PIXELDMX, and normalize include/indentation/whitespace (including the SetPersonalityDescription call).
1 parent 857ce97 commit 08b14ed

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

lib-pixeldmx/src/json/pixeldmxparams.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2323
* THE SOFTWARE.
2424
*/
25+
26+
#undef NDEBUG
2527

2628
#include <cstdint>
2729
#include <algorithm>
@@ -44,6 +46,7 @@
4446
#include "dmxnode.h"
4547
#include "dmxnode_nodetype.h"
4648
#include "pixeltestpattern.h"
49+
#include "firmware/debug/debug_debug.h"
4750

4851
static constexpr uint32_t kConfigMaxPorts = CONFIG_DMXNODE_PIXEL_MAX_PORTS;
4952

lib-pixeldmx/src/pixeldmxparams/pixeldmxparamsrdm.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* @file pixeldmxparamsrdm.cpp
33
*
44
*/
5-
/* Copyright (C) 2021-2025 by Arjan van Vught mailto:info@gd32-dmx.org
5+
/* Copyright (C) 2021-2026 by Arjan van Vught mailto:info@gd32-dmx.org
66
*
77
* Permission is hereby granted, free of charge, to any person obtaining a copy
88
* of this software and associated documentation files (the "Software"), to deal
@@ -23,9 +23,6 @@
2323
* THE SOFTWARE.
2424
*/
2525

26-
27-
#undef NDEBUG
28-
2926
#if defined(DEBUG_PIXELDMX)
3027
#undef NDEBUG
3128
#endif
@@ -39,7 +36,7 @@
3936
#include "common/utils/utils_enum.h"
4037
#include "pixeldmxconfiguration.h"
4138
#include "rdmdeviceresponder.h"
42-
#include "firmware/debug/debug_debug.h"
39+
#include "firmware/debug/debug_debug.h"
4340

4441
void PixelDmxParamsRdm::SetDataImpl([[maybe_unused]] uint32_t port_index, const uint8_t* data, uint32_t length, [[maybe_unused]] bool do_update)
4542
{
@@ -92,7 +89,7 @@ void PixelDmxParamsRdm::SetDataImpl([[maybe_unused]] uint32_t port_index, const
9289
configuration.Validate(1);
9390

9491
char description[rdm::personality::DESCRIPTION_MAX_LENGTH];
95-
pixeldmx::paramsdmx::SetPersonalityDescription(description);
92+
pixeldmx::paramsdmx::SetPersonalityDescription(description);
9693
auto* personality = RDMDeviceResponder::Get()->GetPersonality(RDM_ROOT_DEVICE, 1);
9794
personality->SetDescription(description);
9895

0 commit comments

Comments
 (0)