Skip to content

Commit 4dcec4e

Browse files
authored
Prefix default usernames and password for test with test_ instead of vapor_ (#192)
* Prefix default usernames and password for test with test_ instead of vapor_ * Update test workflow to use new defaults
1 parent 24d8423 commit 4dcec4e

File tree

5 files changed

+40
-31
lines changed

5 files changed

+40
-31
lines changed

.github/workflows/test.yml

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -57,28 +57,37 @@ jobs:
5757
runs-on: ubuntu-latest
5858
env:
5959
LOG_LEVEL: debug
60+
# Unfortunately, fluent-postgres-driver details leak through here
6061
POSTGRES_HOSTNAME: 'psql-a'
61-
POSTGRES_DB: 'vapor_database'
62-
POSTGRES_USER: 'vapor_username'
63-
POSTGRES_PASSWORD: 'vapor_password'
62+
POSTGRES_DB: 'test_database'
63+
POSTGRES_DATABASE: 'test_database'
64+
POSTGRES_DATABASE_A: 'test_database'
65+
POSTGRES_DATABASE_B: 'test_database'
66+
POSTGRES_USER: 'test_username'
67+
POSTGRES_USERNAME: 'test_username'
68+
POSTGRES_USERNAME_A: 'test_username'
69+
POSTGRES_USERNAME_B: 'test_username'
70+
POSTGRES_PASSWORD: 'test_password'
71+
POSTGRES_PASSWORD_A: 'test_password'
72+
POSTGRES_PASSWORD_B: 'test_password'
6473
POSTGRES_HOSTNAME_A: 'psql-a'
6574
POSTGRES_HOSTNAME_B: 'psql-b'
6675
POSTGRES_HOST_AUTH_METHOD: ${{ matrix.dbauth }}
6776
services:
6877
psql-a:
6978
image: ${{ matrix.dbimage }}
7079
env:
71-
POSTGRES_USER: 'vapor_username'
72-
POSTGRES_DB: 'vapor_database'
73-
POSTGRES_PASSWORD: 'vapor_password'
80+
POSTGRES_USER: 'test_username'
81+
POSTGRES_DB: 'test_database'
82+
POSTGRES_PASSWORD: 'test_password'
7483
POSTGRES_HOST_AUTH_METHOD: ${{ matrix.dbauth }}
7584
POSTGRES_INITDB_ARGS: --auth-host=${{ matrix.dbauth }}
7685
psql-b:
7786
image: ${{ matrix.dbimage }}
7887
env:
79-
POSTGRES_USER: 'vapor_username'
80-
POSTGRES_DB: 'vapor_database'
81-
POSTGRES_PASSWORD: 'vapor_password'
88+
POSTGRES_USER: 'test_username'
89+
POSTGRES_DB: 'test_database'
90+
POSTGRES_PASSWORD: 'test_password'
8291
POSTGRES_HOST_AUTH_METHOD: ${{ matrix.dbauth }}
8392
POSTGRES_INITDB_ARGS: --auth-host=${{ matrix.dbauth }}
8493
steps:
@@ -124,8 +133,8 @@ jobs:
124133
env:
125134
LOG_LEVEL: debug
126135
POSTGRES_HOSTNAME: 127.0.0.1
127-
POSTGRES_USER: 'vapor_username'
128-
POSTGRES_PASSWORD: 'vapor_password'
136+
POSTGRES_USER: 'test_username'
137+
POSTGRES_PASSWORD: 'test_password'
129138
POSTGRES_DB: 'postgres'
130139
POSTGRES_HOST_AUTH_METHOD: ${{ matrix.dbauth }}
131140
steps:

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ Once you have a connection, you will need to authenticate with the server using
124124

125125
```swift
126126
try conn.authenticate(
127-
username: "vapor_username",
128-
database: "vapor_database",
129-
password: "vapor_password"
127+
username: "your_username",
128+
database: "your_database",
129+
password: "your_password"
130130
).wait()
131131
```
132132

Tests/IntegrationTests/PSQLIntegrationTests.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ final class IntegrationTests: XCTestCase {
2525
let config = PSQLConnection.Configuration(
2626
host: env("POSTGRES_HOSTNAME") ?? "localhost",
2727
port: 5432,
28-
username: env("POSTGRES_USER") ?? "postgres",
29-
database: env("POSTGRES_DB"),
28+
username: env("POSTGRES_USER") ?? "test_username",
29+
database: env("POSTGRES_DB") ?? "test_database",
3030
password: "wrong_password",
3131
tlsConfiguration: nil)
3232

@@ -327,9 +327,9 @@ extension PSQLConnection {
327327
let config = PSQLConnection.Configuration(
328328
host: env("POSTGRES_HOSTNAME") ?? "localhost",
329329
port: 5432,
330-
username: env("POSTGRES_USER") ?? "postgres",
331-
database: env("POSTGRES_DB"),
332-
password: env("POSTGRES_PASSWORD"),
330+
username: env("POSTGRES_USER") ?? "test_username",
331+
database: env("POSTGRES_DB") ?? "test_database",
332+
password: env("POSTGRES_PASSWORD") ?? "test_password",
333333
tlsConfiguration: nil)
334334

335335
return PSQLConnection.connect(configuration: config, logger: logger, on: eventLoop)

Tests/IntegrationTests/Utilities.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ extension PostgresConnection {
2626
static func test(on eventLoop: EventLoop, logLevel: Logger.Level = .info) -> EventLoopFuture<PostgresConnection> {
2727
return testUnauthenticated(on: eventLoop, logLevel: logLevel).flatMap { conn in
2828
return conn.authenticate(
29-
username: env("POSTGRES_USER") ?? "vapor_username",
30-
database: env("POSTGRES_DB") ?? "vapor_database",
31-
password: env("POSTGRES_PASSWORD") ?? "vapor_password"
29+
username: env("POSTGRES_USER") ?? "test_username",
30+
database: env("POSTGRES_DB") ?? "test_database",
31+
password: env("POSTGRES_PASSWORD") ?? "test_password"
3232
).map {
3333
return conn
3434
}.flatMapError { error in

docker-compose.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,28 @@ services:
66
user: postgres:postgres
77
environment:
88
POSTGRES_HOST_AUTH_METHOD: "${POSTGRES_HOST_AUTH_METHOD:-md5}"
9-
POSTGRES_USER: vapor_username
10-
POSTGRES_DB: vapor_database
11-
POSTGRES_PASSWORD: vapor_password
9+
POSTGRES_USER: test_username
10+
POSTGRES_DB: test_database
11+
POSTGRES_PASSWORD: test_password
1212
ports:
1313
- 5432:5432
1414
psql-12:
1515
image: postgres:12
1616
user: postgres:postgres
1717
environment:
1818
POSTGRES_HOST_AUTH_METHOD: "${POSTGRES_HOST_AUTH_METHOD:-md5}"
19-
POSTGRES_USER: vapor_username
20-
POSTGRES_DB: vapor_database
21-
POSTGRES_PASSWORD: vapor_password
19+
POSTGRES_USER: test_username
20+
POSTGRES_DB: test_database
21+
POSTGRES_PASSWORD: test_password
2222
ports:
2323
- 5432:5432
2424
psql-11:
2525
image: postgres:11
2626
user: postgres:postgres
2727
environment:
2828
POSTGRES_HOST_AUTH_METHOD: "${POSTGRES_HOST_AUTH_METHOD:-md5}"
29-
POSTGRES_USER: vapor_username
30-
POSTGRES_DB: vapor_database
31-
POSTGRES_PASSWORD: vapor_password
29+
POSTGRES_USER: test_username
30+
POSTGRES_DB: test_database
31+
POSTGRES_PASSWORD: test_password
3232
ports:
3333
- 5432:5432

0 commit comments

Comments
 (0)