Skip to content

Commit 6a0374b

Browse files
James LinJames Lin
authored andcommitted
using requests.Session for better optimization
1 parent 562b6bb commit 6a0374b

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

rest_framework_queryset/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
from __future__ import unicode_literals
33
from __future__ import absolute_import
44

5-
__version__ = '0.1.2'
5+
__version__ = '0.2.2'
66

77
from .queryset import RestFrameworkQuerySet

rest_framework_queryset/queryset.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88

99
class BaseAPIQuerySet(object):
1010
def __init__(self, url, *args, **kwargs):
11-
self.request_method = requests.get
11+
_req_session = requests.Session()
12+
self.request_method = _req_session.get
1213
self.url = url
1314
self.args = args
1415
self.kwargs = kwargs

tests.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def test_filter_chain(self):
3131

3232
def test_filter_call(self):
3333
fake_response = MagicMock(json=lambda:{'count': 10, 'results': range(10)})
34-
with patch('rest_framework_queryset.queryset.requests.get', return_value=fake_response) as mock_get:
34+
with patch('rest_framework_queryset.queryset.requests.Session.get', return_value=fake_response) as mock_get:
3535
qs = RestFrameworkQuerySet('/api/')
3636
qs1 = qs.filter(a=123)
3737
self.assertEqual(list(qs1), list(range(10)))
@@ -42,7 +42,7 @@ def test_filter_call(self):
4242

4343
def test_get_call(self):
4444
fake_response = MagicMock(json=lambda:{'count': 10, 'results': range(10)})
45-
with patch('rest_framework_queryset.queryset.requests.get', return_value=fake_response) as mock_get:
45+
with patch('rest_framework_queryset.queryset.requests.Session.get', return_value=fake_response) as mock_get:
4646
qs = RestFrameworkQuerySet('/api/')
4747
with self.assertRaises(MultipleObjectsReturned):
4848
qs1 = qs.get(a=123)
@@ -51,13 +51,13 @@ def test_get_call(self):
5151

5252
def test_count_call(self):
5353
fake_response = MagicMock(json=lambda:{'count': 10, 'results': range(10)})
54-
with patch('rest_framework_queryset.queryset.requests.get', return_value=fake_response) as mock_get:
54+
with patch('rest_framework_queryset.queryset.requests.Session.get', return_value=fake_response) as mock_get:
5555
count = RestFrameworkQuerySet('/api/').count()
5656
self.assertEqual(count, 10)
5757

5858
def test_all(self):
5959
fake_response = MagicMock(json=lambda:{'count': 10, 'results': range(10)})
60-
with patch('rest_framework_queryset.queryset.requests.get', return_value=fake_response) as mock_get:
60+
with patch('rest_framework_queryset.queryset.requests.Session.get', return_value=fake_response) as mock_get:
6161
qs = RestFrameworkQuerySet('/api/').all()
6262
self.assertEqual(list(qs), list(range(10)))
6363

0 commit comments

Comments
 (0)