bug fix get by id

Author: James Lin

api/views.py

@@ -1,5 +1,6 @@
 from rest_framework import generics
 from rest_framework import serializers
+from rest_framework import viewsets
 from .models import DataModel
 from .filters import DataModelFilter
 
@@ -10,7 +11,7 @@ class Meta(object):
         fields = '__all__'
 
 
-class ListView(generics.ListAPIView):
+class ListView(viewsets.ModelViewSet):
     serializer_class = DataModelSerializer
     queryset = DataModel.objects.all()
     filter_class = DataModelFilter

django_rest_framework_queryset/settings.py

@@ -41,6 +41,7 @@
     'rest_framework',
     'api',
     'web',
+    'django_filters',
 ]
 
 MIDDLEWARE_CLASSES = [

django_rest_framework_queryset/urls.py

@@ -16,12 +16,16 @@
 """
 from django.conf.urls import url
 from django.contrib import admin
+from rest_framework import routers
 from api.views import ListView
 from web.views import ListDataView
 
+router = routers.SimpleRouter()
+router.register(r'api', ListView)
+
 urlpatterns = [
     url(r'^admin/', admin.site.urls),
-    url(r'^api/', ListView.as_view()),
+    # url(r'^api/', ListView.as_view()),
     url(r'^list/$', ListDataView.as_view()),
     url(r'^list/page/(?P<page>\d+)/$', ListDataView.as_view()),
-]
+] + router.urls

rest_framework_queryset/queryset.py

@@ -76,7 +76,7 @@ def _clone(self):
 
     def _call_api(self):
         if self.__id:
-            self.url = '{}/{}'.format(self.url.rstrip('/'), self.__id)
+            self.url = '{}/{}/'.format(self.url.rstrip('/'), self.__id)
         return super(RestFrameworkQuerySet, self)._call_api()
 
     def count(self):
@@ -90,6 +90,7 @@ def count(self):
 
     def get_result(self):
         response = self._call_api()
+        print(response.text)
         result = response.json()
         if 'results' in result:
             return result['results']

tests.py

@@ -100,3 +100,11 @@ def test_slice(self):
         qs = RestFrameworkQuerySet('{}/api/'.format(self.live_server_url))
         item_list = [item['value'] for item in qs[200:1000]]
         self.assertEqual(item_list, list(range(200, 1000)))
+
+    def test_get(self):
+        DataModel.objects.bulk_create([DataModel(value=i) for i in range(100)])
+        qs = RestFrameworkQuerySet('{}/api/'.format(self.live_server_url))
+        item = qs.get(1)
+        self.assertEqual(item['id'], 1)
+        item = qs.get(2)
+        self.assertEqual(item['id'], 2)