Skip to content

Commit 7db5846

Browse files
committed
Use the gigapage helper in permanent remote resume
1 parent 6d892d3 commit 7db5846

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

lib/tinykvm/remote.cpp

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -228,22 +228,7 @@ void Machine::ipre_permanent_remote_resume_now(bool store_fsbase_rdi)
228228
this->set_registers(this->registers()); // Set dirty bit
229229
}
230230

231-
if (this->memory.foreign_banks.size() < remote().memory.banks.size()) {
232-
const size_t start_idx = this->memory.foreign_banks.size();
233-
for (size_t i = start_idx; i < remote().memory.banks.size(); i++)
234-
{
235-
const auto& bank = remote().memory.banks.at(i);
236-
const VirtualMem vmem = bank.to_vmem();
237-
if constexpr (VERBOSE_REMOTE) {
238-
fprintf(stderr, "Permanent remote: mapped bank %u at 0x%lX-0x%lX\n",
239-
bank.idx, bank.addr, bank.addr + bank.size());
240-
}
241-
const unsigned new_idx = memory.allocate_region_idx();
242-
this->install_memory(new_idx, vmem, false);
243-
memory.foreign_banks.push_back(new_idx);
244-
}
245-
this->prepare_vmresume(0, true); // Reload page tables
246-
}
231+
this->remote_update_gigapage_mappings(remote());
247232

248233
// Resume execution directly into remote VM
249234
// Our execution timeout will interrupt the remote VM if needed.

0 commit comments

Comments
 (0)