feat: add logInfo and logWarn in VmFullBackup

Author: pierrebrunet289

@xen-orchestra/backup-archive/src/VmBackup.types.mts

@@ -16,6 +16,14 @@ export interface PartialBackupMetadata {
   timestamp: number
 }
 
+export interface BackupCleanOptions {
+  fix: boolean
+  merge: boolean
+  remove: boolean
+  logInfo: (message: any, opts?: object) => void
+  logWarn: (message: any, opts?: object) => void
+}
+
 export interface IBackupLineage {
   init(): Promise<void>
   check(): Promise<void>

@xen-orchestra/backup-archive/src/VmBackupDirectory.mts

@@ -59,7 +59,13 @@ export class VmBackupDirectory implements IVmBackupInterface {
     let backupArchive: IVmBackupInterface
     try {
       if (metadata.mode == 'full') {
-        backupArchive = new VmFullBackupArchive(this.handler, this.rootPath, metadataPath, metadata, metadata.xva!)
+        backupArchive = new VmFullBackupArchive(this.handler, this.rootPath, metadataPath, metadata, metadata.xva!, {
+          fix: true,
+          merge: true,
+          remove: true,
+          logWarn: console.warn,
+          logInfo: console.log,
+        })
       } else {
         //@ts-ignore
         backupArchive = new VmIncrementalBackupArchive(this.handler)

@xen-orchestra/backup-archive/src/VmFullBackupArchive.mts

@@ -1,7 +1,7 @@
 import { basename, normalize } from '@xen-orchestra/fs/path'
 import assert from 'node:assert'
 import { FileDescriptor } from '@xen-orchestra/fs'
-import { IVmBackupInterface, PartialBackupMetadata } from './VmBackup.types.mjs'
+import { BackupCleanOptions, IVmBackupInterface, PartialBackupMetadata } from './VmBackup.types.mjs'
 import RemoteHandlerAbstract from '@xen-orchestra/fs'
 
 const COMPRESSED_MAGIC_NUMBERS: Buffer[] = [
@@ -72,19 +72,22 @@ export class VmFullBackupArchive implements IVmBackupInterface {
   isValid?: boolean
   metadataPath: string
   metadata: PartialBackupMetadata
+  opts: BackupCleanOptions
 
   constructor(
     handler: RemoteHandlerAbstract,
     rootPath: string,
     metadataPath: string,
     metadata: PartialBackupMetadata,
-    xvaPath: string
+    xvaPath: string,
+    opts: BackupCleanOptions
   ) {
     this.handler = handler
     this.rootPath = normalize(rootPath)
     this.metadataPath = normalize(metadataPath)
     this.metadata = metadata
     this.xvaPath = normalize(xvaPath)
+    this.opts = opts
   }
 
   async init() {
@@ -97,13 +100,13 @@ export class VmFullBackupArchive implements IVmBackupInterface {
         this.isValid = await isValidXva(this.handler, this.xvaPath)
       }
     } catch (error) {
-      console.log(error)
+      this.opts.logWarn(error)
       this.isValid = false
     }
     // TODO: check isValid
     // isValid is always false in test because XVA test is too small
     if (this.isValid) {
-      console.warn('XVA might be broken', { path: this.xvaPath })
+      this.opts.logWarn('XVA might be broken', { path: this.xvaPath })
     }
     return { xvaValid: this.isValid }
   }
@@ -114,14 +117,14 @@ export class VmFullBackupArchive implements IVmBackupInterface {
    * @param opts { remove: boolean }
    * @returns
    */
-  async clean({ remove = false }) {
+  async clean({ remove = this.opts.remove ?? false }) {
     let filesToRemove: Array<string> = []
     if (remove) {
       for (const file of filesToRemove) {
         try {
           await this.handler.unlink(file)
         } catch (error) {
-          console.warn(`Issue removing ${file}`)
+          this.opts.logWarn(`Issue removing ${file}`)
         }
       }
     }