clean code

Author: fbeauchamp

@xen-orchestra/backups/_incrementalVm.mjs

@@ -160,42 +160,42 @@ export const importIncrementalVm = defer(async function importIncrementalVm(
   let vmRef
   if (isUpdate) {
     vmRef = targetRef
-    await xapi.setFields('VM', vmRef, vmRecord)
     await Promise.all([
-      xapi.setField('VM', vmRef, 'actions_after_crash', vmRecord.actions_after_crash),
-      xapi.setField('VM', vmRef, 'actions_after_reboot', vmRecord.actions_after_reboot),
-      xapi.setField('VM', vmRef, 'actions_after_shutdown', vmRecord.actions_after_shutdown),
-      vmRecord.domain_type !== undefined && xapi.setField('VM', vmRef, 'domain_type', vmRecord.domain_type),
-      xapi.setField('VM', vmRef, 'ha_restart_priority', vmRecord.ha_restart_priority),
-      xapi.setField('VM', vmRef, 'has_vendor_device', vmRecord.has_vendor_device),
-      xapi.setField('VM', vmRef, 'HVM_boot_params', vmRecord.HVM_boot_params),
-      xapi.setField('VM', vmRef, 'HVM_boot_policy', vmRecord.HVM_boot_policy),
-      vmRecord.HVM_shadow_multiplier !== undefined &&
-        xapi.setField('VM', vmRef, 'HVM_shadow_multiplier', vmRecord.HVM_shadow_multiplier),
-      xapi.setField('VM', vmRef, 'memory_dynamic_max', vmRecord.memory_dynamic_max),
-      xapi.setField('VM', vmRef, 'memory_dynamic_min', vmRecord.memory_dynamic_min),
-      xapi.setField('VM', vmRef, 'memory_static_max', vmRecord.memory_static_max),
-      xapi.setField('VM', vmRef, 'memory_static_min', vmRecord.memory_static_min),
-      xapi.setField('VM', vmRef, 'name_description', vmRecord.name_description),
-      xapi.setField('VM', vmRef, 'order', vmRecord.order),
-      xapi.setField('VM', vmRef, 'other_config', vmRecord.other_config),
-      xapi.setField('VM', vmRef, 'platform', vmRecord.platform),
-      xapi.setField('VM', vmRef, 'PV_args', vmRecord.PV_args),
-      xapi.setField('VM', vmRef, 'PV_bootloader', vmRecord.PV_bootloader),
-      xapi.setField('VM', vmRef, 'PV_bootloader_args', vmRecord.PV_bootloader_args),
-      xapi.setField('VM', vmRef, 'PV_kernel', vmRecord.PV_kernel),
-      xapi.setField('VM', vmRef, 'PV_legacy_args', vmRecord.PV_legacy_args),
-      xapi.setField('VM', vmRef, 'PV_ramdisk', vmRecord.PV_ramdisk),
-      xapi.setField('VM', vmRef, 'recommendations', vmRecord.recommendations),
-      xapi.setField('VM', vmRef, 'shutdown_delay', vmRecord.shutdown_delay),
-      xapi.setField('VM', vmRef, 'start_delay', vmRecord.start_delay),
-      vmRecord.suspend_SR !== undefined && xapi.setField('VM', vmRef, 'suspend_SR', vmRecord.suspend_SR),
-      xapi.setField('VM', vmRef, 'tags', vmRecord.tags),
-      xapi.setField('VM', vmRef, 'user_version', vmRecord.user_version),
-      xapi.setField('VM', vmRef, 'VCPUs_at_startup', vmRecord.VCPUs_at_startup),
-      xapi.setField('VM', vmRef, 'VCPUs_max', vmRecord.VCPUs_max),
-      xapi.setField('VM', vmRef, 'VCPUs_params', vmRecord.VCPUs_params),
-      vmRecord.xenstore_data !== undefined && xapi.setField('VM', vmRef, 'xenstore_data', vmRecord.xenstore_data),
+      xapi.setFields('VM', vmRef, {
+        actions_after_crash: vmRecord.actions_after_crash,
+        actions_after_reboot: vmRecord.actions_after_reboot,
+        actions_after_shutdown: vmRecord.actions_after_shutdown,
+        domain_type: vmRecord.domain_type,
+        ha_restart_priority: vmRecord.ha_restart_priority,
+        has_vendor_device: vmRecord.has_vendor_device,
+        HVM_boot_params: vmRecord.HVM_boot_params,
+        HVM_boot_policy: vmRecord.HVM_boot_policy,
+        HVM_shadow_multiplier: vmRecord.HVM_shadow_multiplier,
+        memory_dynamic_max: vmRecord.memory_dynamic_max,
+        memory_dynamic_min: vmRecord.memory_dynamic_min,
+        memory_static_max: vmRecord.memory_static_max,
+        memory_static_min: vmRecord.memory_static_min,
+        name_description: vmRecord.name_description,
+        order: vmRecord.order,
+        other_config: vmRecord.other_config,
+        platform: vmRecord.platform,
+        PV_args: vmRecord.PV_args,
+        PV_bootloader: vmRecord.PV_bootloader,
+        PV_bootloader_args: vmRecord.PV_bootloader_args,
+        PV_kernel: vmRecord.PV_kernel,
+        PV_legacy_args: vmRecord.PV_legacy_args,
+        PV_ramdisk: vmRecord.PV_ramdisk,
+        recommendations: vmRecord.recommendations,
+        shutdown_delay: vmRecord.shutdown_delay,
+        start_delay: vmRecord.start_delay,
+        suspend_SR: vmRecord.suspend_SR,
+        tags: vmRecord.tags,
+        user_version: vmRecord.user_version,
+        VCPUs_at_startup: vmRecord.VCPUs_at_startup,
+        VCPUs_max: vmRecord.VCPUs_max,
+        VCPUs_params: vmRecord.VCPUs_params,
+        xenstore_data: vmRecord.xenstore_data,
+      }),
       targetVm.update_blocked_operations({
         start: 'Importing…',
         start_on: 'Importing…',