gprofng: do not skip weak symbols

Dmitrii Bordukov · Vladimir Mezentsev · commit 00df7c126b9a · 2025-07-19T12:54:32.000-07:00
PR gprofng/33151 gprofng ignores functions that are compiled as weak symbols. This heavily affects C++ class methods that are always compiled by g++ and clang++ as weak symbols. In this case 'gprofng display text' just displays <static>@address(<FILENAME>) instead of proper method name. The bug has been introduced in the commit 470a028.
diff --git a/gprofng/src/Stabs.cc b/gprofng/src/Stabs.cc
@@ -1546,7 +1546,7 @@ Stabs::readSymSec (Elf *elf, bool is_dynamic)
       switch (GELF_ST_TYPE (Sym.st_info))
 	{
 	case STT_FUNC:
-	  if (Sym.st_size == 0 || ELF_ST_BIND (Sym.st_info) == STB_WEAK)
+	  if (Sym.st_size == 0)
 	    break;
 	  if (Sym.st_shndx == 0)
 	    {

Original file line number	Diff line number	Diff line change
`@@ -1546,7 +1546,7 @@ Stabs::readSymSec (Elf *elf, bool is_dynamic)`
`1546`	`1546`	`switch (GELF_ST_TYPE (Sym.st_info))`
`1547`	`1547`	`{`
`1548`	`1548`	`case STT_FUNC:`
`1549`		`- if (Sym.st_size == 0 \|\| ELF_ST_BIND (Sym.st_info) == STB_WEAK)`
	`1549`	`+ if (Sym.st_size == 0)`
`1550`	`1550`	`break;`
`1551`	`1551`	`if (Sym.st_shndx == 0)`
`1552`	`1552`	`{`