Skip to content

Commit 7e2911f

Browse files
authored
Faster LinkedHashMap tail() (#2725)
Change: LinkedHashMap tail() is now constant-time, from being O(size) time and space. Motivation: We have a use case which looks somewhat like the following. 1. It's effectively a Queue use case (fifo). 2. Iteration order needs to be stable. 3. Elements in the queue frequently need to be verified as present in the queue. 4. Occasionally, removals must occur, which are usually from the head of the queue although occasionally randomly. We started with a Queue and eventually found performance issues from too much linear scanning. This was not obviously going to be a bottleneck since our queues are usually of very small size, but ended up so. The next type we considered was a LinkedHashSet, using the `head` and `tail` methods to implement a dequeue-like operation and the set operations being sufficient for the other operations. Unfortunately, it seems that `tail` at present copies the entire queue despite not seemingly needing to. We moved to our own hand-crafted HashSet+Queue structure, but this PR seems like it'd generally be beneficial for users of Vavr!
1 parent 48a3193 commit 7e2911f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/main/java/io/vavr/collection/LinkedHashMap.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -917,7 +917,7 @@ public LinkedHashMap<K, V> tail() {
917917
if (isEmpty()) {
918918
throw new UnsupportedOperationException("tail of empty LinkedHashMap");
919919
} else {
920-
return LinkedHashMap.ofEntries(list.tail());
920+
return wrap(list.tail(), map.remove(list.head()._1()));
921921
}
922922
}
923923

0 commit comments

Comments
 (0)