more robust slideby classifier function handling (#2642)

When the classifier function is pure everything works fine, but with
state, `slideBy` might end up in an infinite loop. The reason: `slideBy`
calls the classifier two times on the same item. If the second call
returns a different value, `slideBy` will not advance anymore and
iterate indefinitely on the same item.

Author: jwbargsten

src/main/java/io/vavr/collection/Iterator.java

@@ -1909,6 +1909,7 @@ public boolean hasNext() {
                     if (next == null && source.hasNext()) {
                         final Object key = classifier.apply(source.touch());
                         final java.util.List<T> acc = new ArrayList<>();
+                        acc.add(source.next());
                         while (source.hasNext() && key.equals(classifier.apply(source.touch()))) {
                             acc.add(source.next());
                         }

src/test/java/io/vavr/collection/AbstractTraversableTest.java

@@ -26,6 +26,7 @@
 import java.math.BigDecimal;
 import java.math.BigInteger;
 import java.util.*;
+import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Function;
 import java.util.function.Supplier;
 import java.util.stream.Collector;
@@ -1919,6 +1920,17 @@ public void shouldSlideNilByClassifier() {
         assertThat(empty().slideBy(Function.identity())).isEmpty();
     }
 
+    @Test(timeout=1000)
+    public void shouldTerminateSlideByClassifier() {
+        AtomicInteger ai = new AtomicInteger(0);
+        List<List<String>> expected = List.of(List.of("a", "-"), List.of( "-"), List.of("d") );
+        List<List<String>> actual = List.of("a", "-", "-", "d")
+                .slideBy(x -> x.equals("-") ? ai.getAndIncrement() : ai.get())
+                .toList();
+        assertThat(actual).containsAll(expected);
+        assertThat(expected).containsAll(actual);
+    }
+
     @Test
     public void shouldSlideSingularByClassifier() {
         final List<Traversable<Integer>> actual = of(1).slideBy(Function.identity()).toList().map(io.vavr.collection.Vector::ofAll);