From 3bc95365a557aa5c151d99dcb4f017ed8d7333a7 Mon Sep 17 00:00:00 2001 From: Boris van Katwijk Date: Wed, 12 Mar 2025 09:45:29 +0100 Subject: [PATCH 1/3] Actually use randomness --- vavr/src/test/java/io/vavr/collection/BitSetTest.java | 2 +- vavr/src/test/java/io/vavr/collection/PriorityQueueTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vavr/src/test/java/io/vavr/collection/BitSetTest.java b/vavr/src/test/java/io/vavr/collection/BitSetTest.java index 623c69f94..6dbf2cee2 100644 --- a/vavr/src/test/java/io/vavr/collection/BitSetTest.java +++ b/vavr/src/test/java/io/vavr/collection/BitSetTest.java @@ -462,7 +462,7 @@ public void shouldSerializeDeserializeEnumBitSet() { @Test public void shouldBehaveExactlyLikeAnotherBitSet() { for (int i = 0; i < 10; i++) { - final Random random = getRandom(123456789); + final Random random = new Random(); final java.util.BitSet mutableBitSet = new java.util.BitSet(); BitSet functionalBitSet = BitSet.empty(); diff --git a/vavr/src/test/java/io/vavr/collection/PriorityQueueTest.java b/vavr/src/test/java/io/vavr/collection/PriorityQueueTest.java index a68c9a081..62694e47d 100644 --- a/vavr/src/test/java/io/vavr/collection/PriorityQueueTest.java +++ b/vavr/src/test/java/io/vavr/collection/PriorityQueueTest.java @@ -285,7 +285,7 @@ public void shouldKeepInstanceOfPriorityQueue() { @Test public void shouldBehaveExactlyLikeAnotherPriorityQueue() { for (int i = 0; i < 10; i++) { - final Random random = getRandom(987654321); + final Random random = new Random(); final java.util.PriorityQueue mutablePriorityQueue = new java.util.PriorityQueue<>(); PriorityQueue functionalPriorityQueue = PriorityQueue.empty(); From a4eb04f9161da78b0333188a2f4fa204e8fe94d8 Mon Sep 17 00:00:00 2001 From: Boris van Katwijk Date: Wed, 12 Mar 2025 09:45:36 +0100 Subject: [PATCH 2/3] Remove unused method --- vavr/src/test/java/io/vavr/AbstractValueTest.java | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/vavr/src/test/java/io/vavr/AbstractValueTest.java b/vavr/src/test/java/io/vavr/AbstractValueTest.java index 8f2ba8cae..f5d4584fb 100644 --- a/vavr/src/test/java/io/vavr/AbstractValueTest.java +++ b/vavr/src/test/java/io/vavr/AbstractValueTest.java @@ -64,18 +64,6 @@ @ExtendWith(AbstractMultimapTest.TestTemplateProvider.class) public abstract class AbstractValueTest { - protected Random getRandom(int seed) { - if (seed >= 0) { - return new Random(seed); - } else { - final Random random = new Random(); - seed = random.nextInt(); - System.out.println("using seed: " + seed); - random.setSeed(seed); - return random; - } - } - protected IterableAssert assertThat(Iterable actual) { return new IterableAssert(actual) { }; From 552efc73f23b8cd4e577aae151e21819d4c1478c Mon Sep 17 00:00:00 2001 From: Boris van Katwijk Date: Wed, 12 Mar 2025 09:47:10 +0100 Subject: [PATCH 3/3] Update AbstractValueTest.java --- vavr/src/test/java/io/vavr/AbstractValueTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/vavr/src/test/java/io/vavr/AbstractValueTest.java b/vavr/src/test/java/io/vavr/AbstractValueTest.java index f5d4584fb..44a9f924f 100644 --- a/vavr/src/test/java/io/vavr/AbstractValueTest.java +++ b/vavr/src/test/java/io/vavr/AbstractValueTest.java @@ -35,7 +35,6 @@ import java.util.Comparator; import java.util.NoSuchElementException; import java.util.Optional; -import java.util.Random; import java.util.function.Function; import java.util.function.Supplier; import org.assertj.core.api.BooleanAssert;