fix(project): Project Submission fixes.

Author: hiocas

lib/blocs/audio_player/audio_player_bloc.dart

@@ -14,10 +14,6 @@ part 'audio_player_state.dart';
 class AudioPlayerBloc extends Bloc<AudioPlayerEvent, AudioPlayerState> {
   static const maxPlayers = 4;
   final List<Player> _players = [];
-  static const int defaultBassOctave = 2;
-  static const int defaultBassOctaves = defaultBassOctave * 12;
-  static const int defaultNoteOctave = 4;
-  static const int defaultNoteOctaves = defaultNoteOctave * 12;
   static const int maxMelody = 71; // B4.
   static const int minBass = 31; // G2.
   bool _baseControl = true;
@@ -96,10 +92,7 @@ class AudioPlayerBloc extends Bloc<AudioPlayerEvent, AudioPlayerState> {
     emit(Idle());
   }
 
-  Future<void> _play({
-    required Emitter<AudioPlayerState> emit,
-    bool arpeggio = false,
-  }) async {
+  Future<void> _play({required Emitter<AudioPlayerState> emit}) async {
     if (_currentMeasures != null) {
       double millisecondsPerBeat = (60 / _bpm) * 1000;
       double mult =
@@ -121,15 +114,7 @@ class AudioPlayerBloc extends Bloc<AudioPlayerEvent, AudioPlayerState> {
             Duration duration =
                 Duration(milliseconds: (prog.durations[_cC] * mult).toInt());
             if (prog[_cC] != null) {
-              if (arpeggio) {
-                _playChordArpeggio(
-                    chord: prog[_cC]!,
-                    duration: duration,
-                    noteLength:
-                        Duration(milliseconds: ((0.125 / 2) * mult).toInt()));
-              } else {
-                prevPitches = _playChord(prog[_cC]!, prevPitches);
-              }
+              prevPitches = _playChord(prog[_cC]!, prevPitches);
             }
             await Future.delayed(duration);
           } else {
@@ -153,24 +138,6 @@ class AudioPlayerBloc extends Bloc<AudioPlayerEvent, AudioPlayerState> {
     return pitches;
   }
 
-  void _playChordArpeggio({
-    required Chord chord,
-    required Duration duration,
-    required Duration noteLength,
-  }) async {
-    int times = duration.inMilliseconds ~/ noteLength.inMilliseconds;
-    List<Pitch> pitches = _walk(chord);
-    for (int i = 0; i < times; i++) {
-      try {
-        _players[i].open(Media.asset(pitchFileName(pitches[i % maxPlayers])));
-        _players[i].play();
-        await Future.delayed(noteLength);
-      } catch (e) {
-        rethrow;
-      }
-    }
-  }
-
   Pitch getBase(Pitch pitch) {
     int note = pitch.midiNumber % 12;
     int minBassNote = minBass % 12;

lib/blocs/substitution_handler/substitution_handler_bloc.dart

@@ -8,7 +8,6 @@ import 'package:thoery_test/modals/pitch_scale.dart';
 import 'package:thoery_test/modals/progression.dart';
 import 'package:thoery_test/modals/scale_degree_progression.dart';
 import 'package:thoery_test/modals/substitution.dart';
-import 'package:thoery_test/modals/substitution_match.dart';
 import 'package:thoery_test/modals/weights/keep_harmonic_function_weight.dart';
 import 'package:thoery_test/modals/weights/weight.dart';
 import 'package:thoery_test/state/progression_bank.dart';
@@ -151,21 +150,6 @@ class SubstitutionHandlerBloc
     return _chordProgressions![index]!;
   }
 
-  ChordProgression getOriginalSubChords(PitchScale scale, int index) {
-    assert(index >= 0 && index < _originalSubs!.length);
-    if (_originalSubs![index] == null) {
-      ScaleDegreeProgression originalSub =
-          _substitutions![index].originalSubstitution;
-      SubstitutionMatch match = _substitutions![index].match;
-      if (match.type == SubstitutionMatchType.tonicization) {
-        originalSub = originalSub.tonicizedFor(
-            _substitutions![index].substitutedBase[match.baseIndex]!);
-      }
-      _originalSubs![index] = originalSub.inScale(scale);
-    }
-    return _originalSubs![index]!;
-  }
-
   /// Creates an [Isolate] to compute the substitution. The isolate will be
   /// saved in [_substituteByIsolate] until it is complete.
   Future<Substitution> _isolateSubstituteBy(int iterations) async {

lib/constants.dart

@@ -2,8 +2,6 @@ import 'package:flutter/material.dart';
 
 abstract class Constants {
   static const Size minimumWindowSize = Size(855, 378);
-
-  static const Color titleBarColor = Color.fromARGB(255, 196, 196, 196);
   static const Color buttonBackgroundColor = Color.fromARGB(255, 227, 227, 227);
   static const Color buttonUnfocusedColor = Color.fromARGB(255, 192, 192, 192);
   static const Color buttonUnfocusedTextColor =
@@ -13,7 +11,6 @@ abstract class Constants {
       Color.fromARGB(100, 206, 206, 206);
   static const Color selectedColor = Color.fromARGB(255, 187, 187, 187);
   static const Color measureColor = Color.fromARGB(255, 171, 171, 171);
-  static const Color playedValueColor = Colors.blue;
   static const double measureWidth = 315;
   static const double measureHeight = 66;
   static const double measureSpacing = measureHeight / 2;

lib/main.dart

@@ -15,14 +15,9 @@ void main() async {
   runApp(const MyApp());
 }
 
-class MyApp extends StatefulWidget {
+class MyApp extends StatelessWidget {
   const MyApp({Key? key}) : super(key: key);
 
-  @override
-  State<MyApp> createState() => _MyAppState();
-}
-
-class _MyAppState extends State<MyApp> {
   @override
   Widget build(BuildContext context) {
     return MaterialApp(
@@ -81,15 +76,13 @@ class _MyAppState extends State<MyApp> {
           textStyle: const TextStyle(fontSize: 12, color: Colors.black),
         ),
       ),
-      home: const MyHomePage(title: 'Flutter Demo Home Page'),
+      home: const MyHomePage(),
     );
   }
 }
 
 class MyHomePage extends StatelessWidget {
-  const MyHomePage({Key? key, required this.title}) : super(key: key);
-
-  final String title;
+  const MyHomePage({Key? key}) : super(key: key);
 
   @override
   Widget build(BuildContext context) {

lib/screens/progression_screen/widgets/bank_progression_button.dart

@@ -42,7 +42,7 @@ class _BankProgressionButtonState extends State<BankProgressionButton> {
     int id = _bloc.currentProgression.id;
     if (ProgressionBank.idFreeInSubs(_bloc.title, id)) {
       if (!ProgressionBank.canBeSubstitution(_bloc.currentProgression)) {
-        _error = 'Progression is does not consist of 2 - 8 chords';
+        _error = 'Progression does not consist of 2 - 8 chords';
       }
     } else {
       String title =