fix: do not remove comment when there is an entry option

jeffcunat · jeffcunat · commit 2e0825217b26 · 2022-12-09T15:55:08.000+01:00
diff --git a/packages/core/src/__tests__/html.spec.ts b/packages/core/src/__tests__/html.spec.ts
@@ -56,6 +56,26 @@ describe('function test.', () => {
     <title>env-title</title>
   </head>
 </html>
+`)
+  })
+
+  test('renderHtml must keep comment with entry.', async () => {
+    const content = await renderHtml(`
+<!DOCTYPE html>
+<html>
+<!--comment-->
+</html>
+`, {
+  injectOptions: {},
+  viteConfig: {} as any,
+  env: {},
+  entry: 'fake'
+},)
+  expect(content).toEqual(`
+<!DOCTYPE html>
+<html>
+<!--comment-->
+</html>
 `)
   })
 })
diff --git a/packages/core/src/htmlPlugin.ts b/packages/core/src/htmlPlugin.ts
@@ -3,7 +3,7 @@ import type { InjectOptions, PageOption, Pages, UserOptions } from './typing'
 import { render } from 'ejs'
 import { isDirEmpty, loadEnv } from './utils'
 import { normalizePath } from 'vite'
-import { parse } from 'node-html-parser'
+import parse from 'node-html-parser'
 import fs from 'fs-extra'
 import path from 'pathe'
 import fg from 'fast-glob'
@@ -255,7 +255,7 @@ export function removeEntryScript(html: string, verbose = false) {
     return html
   }
 
-  const root = parse(html)
+  const root = parse(html, { comment: true })
   const scriptNodes = root.querySelectorAll('script[type=module]') || []
   const removedNode: string[] = []
   scriptNodes.forEach((item) => {
@@ -268,6 +268,7 @@ export function removeEntryScript(html: string, verbose = false) {
       removedNode.toString(),
     )} is deleted. You may also delete it from the index.html.
         `)
+  consola.warn(root.toString())
   return root.toString()
 }
 
