You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sagemathgh-38822: Upgrade database_knotinfo to version 2024.10.1
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixessagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixessagemath#12345". -->
The current `database_knotinfo` version 2024.10.1 is no longer
compatible with Sage because the syntax for 16 knots for which two braid
notations are recorded has changed (see the corresponding [Release Notes
](https://github.com/soehms/database_knotinfo/releases/tag/2024.10.1)).
This is fixed by this PR. In addition, two new fields (`geometric_type`
and `cosmetic_crossing`) added in this version are used to implement
corresponding methods (`is_hyperbolic` and
`cosmetic_crossing_conjecture_verified`) of the interface.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38822
Reported by: Sebastian Oehms
Reviewer(s): Sebastian Oehms, Travis Scrimshaw
0 commit comments