You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sagemathgh-40401: Implement Square Roots to FiniteFields Category
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixessagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixessagemath#12345". -->
Fixessagemath#39688Fixessagemath#39798
Added the following methods to the finite field category
- `quadratic_non_residue()`
- `square_root()` and `sqrt()`
- `_tonelli()` and `_cipolla()`: the algorithms for finding a square
root
- `is_square()` Moved `is_square()` and `sqrt()` methods from
element.pyx to their proper categories.
Most profiling tests showed that Tonelli's algorithm outperforms
Cipolla. However a profile with a Finite Field with order of a Cullen
prime resulted in Cipolla outperforming Tonelli.
I'm running the meson build and currently cannot find the way to build
the html documentation.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#40401
Reported by: Brian Heckel
Reviewer(s): Brian Heckel, Frédéric Chapoton, Vincent Macri
0 commit comments