remove some deprecated methods in matrix/

Author: fchapoton

src/sage/matrix/matrix0.pyx

@@ -6306,39 +6306,3 @@ def unpickle(cls, parent, immutability, cache, data, version):
     else:
         A._unpickle_generic(data, version)
     return A
-
-
-def set_max_rows(n):
-    """
-    Set the global variable ``max_rows`` (which is used in deciding how to
-    output a matrix).
-
-    EXAMPLES::
-
-        sage: from sage.matrix.matrix0 import set_max_rows
-        sage: set_max_rows(20)
-        doctest:...: DeprecationWarning: 'set_max_rows' is replaced by 'matrix.options.max_rows'
-        See https://github.com/sagemath/sage/issues/30552 for details.
-    """
-    from sage.misc.superseded import deprecation
-    deprecation(30552, "'set_max_rows' is replaced by 'matrix.options.max_rows'")
-    from sage.matrix.constructor import options
-    options.max_rows = n-1
-
-
-def set_max_cols(n):
-    """
-    Set the global variable ``max_cols`` (which is used in deciding how to
-    output a matrix).
-
-    EXAMPLES::
-
-        sage: from sage.matrix.matrix0 import set_max_cols
-        sage: set_max_cols(50)
-        doctest:...: DeprecationWarning: 'set_max_cols' is replaced by 'matrix.options.max_cols'
-        See https://github.com/sagemath/sage/issues/30552 for details.
-    """
-    from sage.misc.superseded import deprecation
-    deprecation(30552, "'set_max_cols' is replaced by 'matrix.options.max_cols'")
-    from sage.matrix.constructor import options
-    options.max_cols = n-1

src/sage/matrix/matrix1.pyx

@@ -132,10 +132,9 @@ cdef class Matrix(Matrix0):
         """
         cdef Py_ssize_t i, j
         v = []
-        for i from 0 <= i < self._nrows:
-            tmp = []
-            for j from 0 <= j < self._ncols:
-                tmp.append(self.get_unsafe(i, j)._gap_init_())
+        for i in range(self._nrows):
+            tmp = [self.get_unsafe(i, j)._gap_init_()
+                   for j in range(self._ncols)]
             v.append('[%s]' % (','.join(tmp)))
         # It is needed to multiply with 'One(...)', because
         # otherwise the result would not be a gap matrix
@@ -930,22 +929,6 @@ cdef class Matrix(Matrix0):
         self.cache('row_ambient_module', x)
         return x
 
-    def _row_ambient_module(self, base_ring=None):
-        r"""
-        TESTS::
-
-            sage: M = matrix(Zmod(5), 2, 3)
-            sage: M._row_ambient_module()
-            doctest:warning
-            ...
-            DeprecationWarning: the method _row_ambient_module is deprecated use row_ambient_module (without underscore) instead
-            See https://github.com/sagemath/sage/issues/32984 for details.
-            Vector space of dimension 3 over Ring of integers modulo 5
-        """
-        from sage.misc.superseded import deprecation
-        deprecation(32984, 'the method _row_ambient_module is deprecated use row_ambient_module (without underscore) instead')
-        return self.row_ambient_module(base_ring)
-
     cpdef column_ambient_module(self, base_ring=None, sparse=None):
         r"""
         Return the free module that contains the columns of the matrix.
@@ -987,22 +970,6 @@ cdef class Matrix(Matrix0):
         self.cache('column_ambient_module', x)
         return x
 
-    def _column_ambient_module(self):
-        r"""
-        TESTS::
-
-            sage: M = matrix(Zmod(5), 2, 3)
-            sage: M._column_ambient_module()
-            doctest:warning
-            ...
-            DeprecationWarning: the method _column_ambient_module is deprecated use column_ambient_module (without underscore) instead
-            See https://github.com/sagemath/sage/issues/32984 for details.
-            Vector space of dimension 2 over Ring of integers modulo 5
-        """
-        from sage.misc.superseded import deprecation
-        deprecation(32984, 'the method _column_ambient_module is deprecated use column_ambient_module (without underscore) instead')
-        return self.column_ambient_module()
-
     def columns(self, copy=True):
         r"""
         Return a list of the columns of ``self``.