Skip to content

Commit a030984

Browse files
author
Release Manager
committed
sagemathgh-41017: Fix an incorrect comparison in crypto/sbox detected by the compiler ``` warning: self-comparison always evaluates to true [-Wtautological- compare] ``` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41017 Reported by: user202729 Reviewer(s): Lorenz Panny
2 parents 6b76b79 + 85ff5ed commit a030984

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/sage/crypto/sbox.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ cdef class SBox(SageObject):
252252
raise NotImplemented
253253

254254
cdef SBox other = <SBox> rhs
255-
return (self._S_list == other._S_list) and (self._big_endian == self._big_endian)
255+
return (self._S_list == other._S_list) and (self._big_endian == other._big_endian)
256256

257257
def __ne__(self, other):
258258
"""

0 commit comments

Comments
 (0)