Skip to content

Commit e40fef7

Browse files
committed
More fixes from review
1 parent 3cb4174 commit e40fef7

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

src/sage/geometry/fan.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2472,6 +2472,15 @@ def is_polytopal(self):
24722472
sage: mother(epsilon).is_polytopal()
24732473
True
24742474
2475+
TESTS::
2476+
2477+
sage: cone = Cone([(1,1), (2,1)])
2478+
sage: F = Fan([cone])
2479+
sage: F.is_polytopal()
2480+
Traceback (most recent call last):
2481+
...
2482+
ValueError: to be polytopal, the fan should be complete
2483+
24752484
.. SEEALSO::
24762485
24772486
:meth:`is_projective`.

src/sage/geometry/polyhedron/base5.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,7 @@ def deformation_cone(self):
664664
Return the deformation cone of ``self``.
665665
666666
Let `P` be a `d`-polytope in `\RR^r` with `n` facets. The deformation
667-
cone is a polyhedron in `\RR^n` who points are the right-hand side `b`
667+
cone is a polyhedron in `\RR^n` whose points are the right-hand side `b`
668668
in `Ax\leq b` where `A` is the matrix of facet normals of ``self``, so
669669
that the resulting polytope has a normal fan which is a coarsening of
670670
the normal fan of ``self``.
@@ -707,15 +707,15 @@ def deformation_cone(self):
707707
708708
REFERENCES:
709709
710-
For more information, see Section 5.4 of [DLRS2010]_ and Section
711-
2.2 of [ACEP2020].
710+
For more information, see Section 5.4 of [DLRS2010]_ and Section
711+
2.2 of [ACEP2020].
712712
"""
713713
from .constructor import Polyhedron
714714
m = matrix([ineq.A() for ineq in self.Hrepresentation()])
715715
m = m.transpose()
716716
m_ker = m.right_kernel_matrix(basis='computed')
717717
gale = tuple(m_ker.columns())
718-
collection = [f.ambient_H_indices() for f in self.faces(0)]
718+
collection = (f.ambient_H_indices() for f in self.faces(0))
719719
n = len(gale)
720720
c = None
721721
for cone_indices in collection:

0 commit comments

Comments
 (0)