fix linter warnings in sage_setup and sage_docbuild

Author: fchapoton

src/sage_docbuild/conf.py

@@ -670,6 +670,7 @@ def linkcode_resolve(domain, info):
     # used when building html version
     pngmath_latex_preamble += macro + '\n'
 
+
 # ------------------------------------------
 # add custom context variables for templates
 # ------------------------------------------
@@ -712,10 +713,12 @@ def add_page_context(app, pagename, templatename, context, doctree):
 
 dangling_debug = False
 
+
 def debug_inf(app, message):
     if dangling_debug:
         app.info(message)
 
+
 def call_intersphinx(app, env, node, contnode):
     r"""
     Call intersphinx and make links between Sage manuals relative.
@@ -749,6 +752,7 @@ def call_intersphinx(app, env, node, contnode):
         debug_inf(app, "---- Intersphinx: %s not Found" % node['reftarget'])
     return res
 
+
 def find_sage_dangling_links(app, env, node, contnode):
     r"""
     Try to find dangling link in local module imports or all.py.
@@ -859,6 +863,7 @@ def find_sage_dangling_links(app, env, node, contnode):
     '__builtin__',
 ]
 
+
 def check_nested_class_picklability(app, what, name, obj, skip, options):
     """
     Print a warning if pickling is broken for nested classes.
@@ -879,6 +884,7 @@ def check_nested_class_picklability(app, what, name, obj, skip, options):
                          'sage.misc.nested_class.NestedClassMetaclass.' % (
                         v.__module__ + '.' + name + '.' + nm))
 
+
 def skip_member(app, what, name, obj, skip, options):
     """
     To suppress Sphinx warnings / errors, we

src/sage_docbuild/ext/sage_autodoc.py

@@ -81,8 +81,12 @@
                                    is_function_or_cython_function)
 
 _getdoc = getdoc
+
+
 def getdoc(obj, *args, **kwargs):
     return sage_getdoc_original(obj)
+
+
 # ------------------------------------------------------------------
 
 if TYPE_CHECKING:
@@ -1616,7 +1620,7 @@ def can_document_member(
         try:
             result_bool = isinstance(member, type) or (
                 isattr and isinstance(member, NewType | TypeVar))
-        except:
+        except Exception:
             result_bool = isinstance(member, type) or (
                 isattr and (inspect.isNewType(member) or isinstance(member, TypeVar)))
         return result_bool
@@ -1695,7 +1699,7 @@ def import_object(self, raiseerror: bool = False) -> bool:
             # support both sphinx 8 and py3.9/older sphinx
             try:
                 test_bool = isinstance(self.object, NewType | TypeVar)
-            except:
+            except Exception:
                 test_bool = inspect.isNewType(self.object) or isinstance(self.object, TypeVar)
             if test_bool:
                 modname = getattr(self.object, '__module__', self.modname)
@@ -1709,7 +1713,7 @@ def _get_signature(self) -> tuple[Any | None, str | None, Signature | None]:
         # support both sphinx 8 and py3.9/older sphinx
         try:
             test_bool = isinstance(self.object, NewType | TypeVar)
-        except:
+        except Exception:
             test_bool = inspect.isNewType(self.object) or isinstance(self.object, TypeVar)
         if test_bool:
             # Suppress signature
@@ -1899,7 +1903,7 @@ def add_directive_header(self, sig: str) -> None:
         # support both sphinx 8 and py3.9/older sphinx
         try:
             test_bool = isinstance(self.object, NewType | TypeVar)
-        except:
+        except Exception:
             test_bool = inspect.isNewType(self.object) or isinstance(self.object, TypeVar)
         if test_bool:
             return
@@ -1911,7 +1915,7 @@ def add_directive_header(self, sig: str) -> None:
         # support both sphinx 8 and py3.9/older sphinx
         try:
             newtype_test = isinstance(self.object, NewType)
-        except:
+        except Exception:
             newtype_test = inspect.isNewType(self.object)
         if (not self.doc_as_attr and not newtype_test
                 and canonical_fullname and self.fullname != canonical_fullname):
@@ -2053,7 +2057,7 @@ def add_content(self, more_content: StringList | None) -> None:
         # support both sphinx 8 and py3.9/older sphinx
         try:
             newtype_test = isinstance(self.object, NewType)
-        except:
+        except Exception:
             newtype_test = inspect.isNewType(self.object)
         if newtype_test:
             if self.config.autodoc_typehints_format == "short":

src/sage_setup/autogen/interpreters/internal/instructions.py

@@ -385,6 +385,7 @@ def instr_funcall_1arg_mpfr(name, io, op):
     """
     return InstrSpec(name, io, code='%s(o0, i0, MPFR_RNDN);' % op)
 
+
 def instr_funcall_2args_mpc(name, io, op):
     r"""
     A helper function for creating MPC instructions with two inputs
@@ -400,6 +401,7 @@ def instr_funcall_2args_mpc(name, io, op):
     """
     return InstrSpec(name, io, code='%s(o0, i0, i1, MPC_RNDNN);' % op)
 
+
 def instr_funcall_1arg_mpc(name, io, op):
     r"""
     A helper function for creating MPC instructions with one input

src/sage_setup/autogen/interpreters/internal/memory.py

@@ -36,7 +36,7 @@ def string_of_addr(a):
     """
     if isinstance(a, int):
         return str(a)
-    assert(isinstance(a, MemoryChunk))
+    assert isinstance(a, MemoryChunk)
     return '*%s++' % a.name
 
 

src/sage_setup/autogen/interpreters/internal/specs/cc.py

@@ -101,6 +101,7 @@ def pass_call_c_argument(self):
         """
         return "result"
 
+
 class CCInterpreter(StackInterpreter):
     r"""
     A subclass of StackInterpreter, specifying an interpreter over

src/sage_setup/autogen/interpreters/internal/storage.py

@@ -852,6 +852,7 @@ def assign_c_from_py(self, c, py):
 
 ty_mpfr = StorageTypeMPFR()
 
+
 class StorageTypeMPC(StorageTypeAutoReference):
     r"""
     StorageTypeMPC is a subtype of StorageTypeAutoReference that deals

src/sage_setup/command/sage_build_cython.py

@@ -49,6 +49,7 @@
 if DEVEL:
     extra_compile_args.append('-ggdb')
 
+
 class sage_build_cython(Command):
     name = 'build_cython'
     description = "compile Cython extensions into C/C++ extensions"

src/sage_setup/command/sage_build_ext.py

@@ -15,6 +15,7 @@
     from distutils.errors import DistutilsSetupError
 from sage_setup.run_parallel import execute_list_of_commands
 
+
 class sage_build_ext(build_ext):
     def finalize_options(self):
         build_ext.finalize_options(self)

src/sage_setup/excepthook.py

@@ -1,6 +1,7 @@
 import os
 import sys
 
+
 def excepthook(*exc):
     """
     When an error occurs, display an error message similar to the error

src/sage_setup/find.py

@@ -172,6 +172,7 @@ def find_python_sources(src_dir, modules=['sage'], distributions=None,
         os.chdir(cwd)
     return python_packages, python_modules, cython_modules
 
+
 def filter_cython_sources(src_dir, distributions, exclude_distributions=None):
     """
     Find all Cython modules in the given source directory that belong to the
@@ -221,6 +222,7 @@ def filter_cython_sources(src_dir, distributions, exclude_distributions=None):
 
     return files
 
+
 def _cythonized_dir(src_dir=None, editable_install=None):
     """
     Return the path where Cython-generated files are placed by the build system.
@@ -343,6 +345,7 @@ def find_extra_files(src_dir, modules, cythonized_dir, special_filenames=[], *,
 
     return data_files
 
+
 def installed_files_by_module(site_packages, modules=('sage',)):
     """
     Find all currently installed files