add Qt 5.15.x patches from KDE

generated from a72077a88903fe532f6a749677eb4da4ea99f79f

except:
0018-Fix-memory-leak
0024-Use-icon-themes-in-QPrintPreviewDialog-if-they-exist
0061-Annotate-QMutex-with-TSAN-annotations

Author: kambala-decapitator

conan_patches/qt/conandata.yml

@@ -0,0 +1,84 @@
+From cc3cfd006594231f3f8e13325305fe0300a4bec5 Mon Sep 17 00:00:00 2001
+From: ChunLin Wang <[email protected]>
+Date: Wed, 31 Mar 2021 17:54:49 +0800
+Subject: [PATCH 001/130] Fix get out of bounds index in
+ QSortFilterProxyModel::filterAcceptsRow
+
+Before calling the index function, we need to check the validity of the parameters.
+
+Fixes: QTBUG-91878
+Change-Id: I9ec7265fff3f81b8a288c4ba8fae606a2ec808a6
+Reviewed-by: David Faure <[email protected]>
+(cherry picked from commit b8802071ed00689373da5817fc4824a30b5fcf86)
+(cherry picked from commit 0a5326a6c292df9cda313e0dcbe75f69f2f7072d)
+---
+ .../itemmodels/qsortfilterproxymodel.cpp        |  8 +++++---
+ .../tst_qconcatenatetablesproxymodel.cpp        | 17 +++++++++++++++++
+ 2 files changed, 22 insertions(+), 3 deletions(-)
+
+diff --git a/src/corelib/itemmodels/qsortfilterproxymodel.cpp b/src/corelib/itemmodels/qsortfilterproxymodel.cpp
+index 3d7fe43cd3f..ce35bda5e11 100644
+--- a/src/corelib/itemmodels/qsortfilterproxymodel.cpp
++++ b/src/corelib/itemmodels/qsortfilterproxymodel.cpp
+@@ -3131,8 +3131,9 @@ bool QSortFilterProxyModel::filterAcceptsRow(int source_row, const QModelIndex &
+ 
+     if (d->filter_data.isEmpty())
+         return true;
++
++    int column_count = d->model->columnCount(source_parent);
+     if (d->filter_column == -1) {
+-        int column_count = d->model->columnCount(source_parent);
+         for (int column = 0; column < column_count; ++column) {
+             QModelIndex source_index = d->model->index(source_row, column, source_parent);
+             QString key = d->model->data(source_index, d->filter_role).toString();
+@@ -3141,9 +3142,10 @@ bool QSortFilterProxyModel::filterAcceptsRow(int source_row, const QModelIndex &
+         }
+         return false;
+     }
+-    QModelIndex source_index = d->model->index(source_row, d->filter_column, source_parent);
+-    if (!source_index.isValid()) // the column may not exist
++
++    if (d->filter_column >= column_count) // the column may not exist
+         return true;
++    QModelIndex source_index = d->model->index(source_row, d->filter_column, source_parent);
+     QString key = d->model->data(source_index, d->filter_role).toString();
+     return d->filter_data.hasMatch(key);
+ }
+diff --git a/tests/auto/corelib/itemmodels/qconcatenatetablesproxymodel/tst_qconcatenatetablesproxymodel.cpp b/tests/auto/corelib/itemmodels/qconcatenatetablesproxymodel/tst_qconcatenatetablesproxymodel.cpp
+index e1ea7a45525..90972caa575 100644
+--- a/tests/auto/corelib/itemmodels/qconcatenatetablesproxymodel/tst_qconcatenatetablesproxymodel.cpp
++++ b/tests/auto/corelib/itemmodels/qconcatenatetablesproxymodel/tst_qconcatenatetablesproxymodel.cpp
+@@ -117,6 +117,7 @@ private Q_SLOTS:
+     void shouldPropagateDropAfterLastRow_data();
+     void shouldPropagateDropAfterLastRow();
+     void qtbug91788();
++    void qtbug91878();
+ 
+ private:
+     QStandardItemModel mod;
+@@ -843,6 +844,22 @@ void tst_QConcatenateTablesProxyModel::qtbug91788()
+     QCOMPARE(proxyConcat.columnCount(), 0);
+ }
+ 
++void tst_QConcatenateTablesProxyModel::qtbug91878()
++{
++    QStandardItemModel m;
++    m.setRowCount(4);
++    m.setColumnCount(4);
++
++    QConcatenateTablesProxyModel pm;
++    QSortFilterProxyModel proxyFilter;
++    proxyFilter.setSourceModel(&pm);
++    proxyFilter.setFilterFixedString("something");
++    pm.addSourceModel(&m);  // This should not assert
++
++    QCOMPARE(pm.columnCount(), 4);
++    QCOMPARE(pm.rowCount(), 4);
++}
++
+ QTEST_GUILESS_MAIN(tst_QConcatenateTablesProxyModel)
+ 
+ #include "tst_qconcatenatetablesproxymodel.moc"
+-- 
+2.39.5 (Apple Git-154)
+

conan_patches/qt/patches/kde/0001-Fix-get-out-of-bounds-index-in-QSortFilterProxyModel.patch

@@ -0,0 +1,37 @@
+From a0143b653f6dec495303a4dba3d019384e1f4657 Mon Sep 17 00:00:00 2001
+From: Edward Welbourne <[email protected]>
+Date: Mon, 8 Feb 2021 12:13:13 +0100
+Subject: [PATCH 002/130] Fix handling of surrogates in QBidiAlgorithm
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Prior code was naively assuming the character after a high surrogate
+would necessarily be a low surrogate, which is buggy.
+Fixes oss-fuzz issue 29718.
+
+Pick-to: 6.0 6.1 5.15
+Change-Id: I10f023c4b5024a0d76fea0a3672001063591ec6d
+Reviewed-by: Konstantin Ritt <[email protected]>
+Reviewed-by: Robert Löhning <[email protected]>
+Reviewed-by: Lars Knoll <[email protected]>
+(cherry picked from commit aeeaab1a5ac0b4d91c9f9b542035b8970e4c61dd)
+---
+ src/gui/text/qtextengine.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/gui/text/qtextengine.cpp b/src/gui/text/qtextengine.cpp
+index 6336fadf749..a6c66e5d2dc 100644
+--- a/src/gui/text/qtextengine.cpp
++++ b/src/gui/text/qtextengine.cpp
+@@ -1,6 +1,6 @@
+ /****************************************************************************
+ **
+-** Copyright (C) 2016 The Qt Company Ltd.
++** Copyright (C) 2021 The Qt Company Ltd.
+ ** Contact: https://www.qt.io/licensing/
+ **
+ ** This file is part of the QtGui module of the Qt Toolkit.
+-- 
+2.39.5 (Apple Git-154)
+

conan_patches/qt/patches/kde/0002-Fix-handling-of-surrogates-in-QBidiAlgorithm.patch

@@ -0,0 +1,86 @@
+From 11897b39598875f367311f87949332b3f028c4cf Mon Sep 17 00:00:00 2001
+From: Ilya Fedin <[email protected]>
+Date: Mon, 12 Apr 2021 12:09:59 +0400
+Subject: [PATCH 003/130] Don't own unique name for QDBusTrayIcon
+
+Flatpak doesn't allow to own random name with PID. Even after adding
+such a permission into manifest, all flatpaked apps have PID 2, so only
+one Qt application at a time can have tray icon.
+
+Even though unique name is a part of the spec, no tray hosts really
+check it and SNI implementations without unique name run just fine
+inside and outside of Flatpak.
+
+This fixes the inability of Qt applications to have tray icon in Flatpak
+outside of KDE.
+
+Pick-to: 6.0 6.1 5.15
+Change-Id: Ieea6dc335b7a74537a51929f6e70ca68c84228fb
+Reviewed-by: Dmitry Shachnev <[email protected]>
+Reviewed-by: Shawn Rutledge <[email protected]>
+(cherry picked from commit 9db7cc79a26ced4997277b5c206ca15949133240)
+---
+ .../dbusmenu/qdbusmenuconnection.cpp            | 17 ++++-------------
+ .../dbusmenu/qdbusmenuconnection_p.h            |  2 +-
+ 2 files changed, 5 insertions(+), 14 deletions(-)
+
+diff --git a/src/platformsupport/themes/genericunix/dbusmenu/qdbusmenuconnection.cpp b/src/platformsupport/themes/genericunix/dbusmenu/qdbusmenuconnection.cpp
+index 09470bccc6c..345a853b1b7 100644
+--- a/src/platformsupport/themes/genericunix/dbusmenu/qdbusmenuconnection.cpp
++++ b/src/platformsupport/themes/genericunix/dbusmenu/qdbusmenuconnection.cpp
+@@ -105,13 +105,7 @@ void QDBusMenuConnection::unregisterTrayIconMenu(QDBusTrayIcon *item)
+ 
+ bool QDBusMenuConnection::registerTrayIcon(QDBusTrayIcon *item)
+ {
+-    bool success = connection().registerService(item->instanceId());
+-    if (!success) {
+-        qWarning() << "failed to register service" << item->instanceId();
+-        return false;
+-    }
+-
+-    success = connection().registerObject(StatusNotifierItemPath, item);
++    bool success = connection().registerObject(StatusNotifierItemPath, item);
+     if (!success) {
+         unregisterTrayIcon(item);
+         qWarning() << "failed to register" << item->instanceId() << StatusNotifierItemPath;
+@@ -126,21 +120,18 @@ bool QDBusMenuConnection::registerTrayIcon(QDBusTrayIcon *item)
+ 
+ bool QDBusMenuConnection::registerTrayIconWithWatcher(QDBusTrayIcon *item)
+ {
++    Q_UNUSED(item);
+     QDBusMessage registerMethod = QDBusMessage::createMethodCall(
+                 StatusNotifierWatcherService, StatusNotifierWatcherPath, StatusNotifierWatcherService,
+                 QLatin1String("RegisterStatusNotifierItem"));
+-    registerMethod.setArguments(QVariantList() << item->instanceId());
++    registerMethod.setArguments(QVariantList() << m_connection.baseService());
+     return m_connection.callWithCallback(registerMethod, this, SIGNAL(trayIconRegistered()), SLOT(dbusError(QDBusError)));
+ }
+ 
+-bool QDBusMenuConnection::unregisterTrayIcon(QDBusTrayIcon *item)
++void QDBusMenuConnection::unregisterTrayIcon(QDBusTrayIcon *item)
+ {
+     unregisterTrayIconMenu(item);
+     connection().unregisterObject(StatusNotifierItemPath);
+-    bool success = connection().unregisterService(item->instanceId());
+-    if (!success)
+-        qWarning() << "failed to unregister service" << item->instanceId();
+-    return success;
+ }
+ #endif // QT_NO_SYSTEMTRAYICON
+ 
+diff --git a/src/platformsupport/themes/genericunix/dbusmenu/qdbusmenuconnection_p.h b/src/platformsupport/themes/genericunix/dbusmenu/qdbusmenuconnection_p.h
+index f484795fbb7..11c7e56534d 100644
+--- a/src/platformsupport/themes/genericunix/dbusmenu/qdbusmenuconnection_p.h
++++ b/src/platformsupport/themes/genericunix/dbusmenu/qdbusmenuconnection_p.h
+@@ -78,7 +78,7 @@ public:
+     void unregisterTrayIconMenu(QDBusTrayIcon *item);
+     bool registerTrayIcon(QDBusTrayIcon *item);
+     bool registerTrayIconWithWatcher(QDBusTrayIcon *item);
+-    bool unregisterTrayIcon(QDBusTrayIcon *item);
++    void unregisterTrayIcon(QDBusTrayIcon *item);
+ #endif // QT_NO_SYSTEMTRAYICON
+ 
+ Q_SIGNALS:
+-- 
+2.39.5 (Apple Git-154)
+

conan_patches/qt/patches/kde/0003-Don-t-own-unique-name-for-QDBusTrayIcon.patch

@@ -0,0 +1,97 @@
+From 1940e91c23aba5528e928ff1da68dda657178109 Mon Sep 17 00:00:00 2001
+From: Lars Knoll <[email protected]>
+Date: Fri, 4 Sep 2020 10:40:29 +0200
+Subject: [PATCH 004/130] Deprecate QMutex in recursive mode
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Use QRecursiveMutex instead.
+
+Pick-to: 5.15
+Change-Id: I862fc2b3143deeb5c96dc8d445be5f9fa2535670
+Reviewed-by: Volker Hilsheimer <[email protected]>
+Reviewed-by: Mårten Nordheim <[email protected]>
+(cherry picked from commit 0e681064b54a6873bef5ddb7edef7e2efc317efc)
+---
+ src/corelib/thread/qmutex.cpp              |  4 +++-
+ src/corelib/thread/qmutex.h                | 11 ++++++++---
+ src/corelib/thread/qwaitcondition_unix.cpp |  2 +-
+ 3 files changed, 12 insertions(+), 5 deletions(-)
+
+diff --git a/src/corelib/thread/qmutex.cpp b/src/corelib/thread/qmutex.cpp
+index 310d1cb14f7..7097122d8e0 100644
+--- a/src/corelib/thread/qmutex.cpp
++++ b/src/corelib/thread/qmutex.cpp
+@@ -152,6 +152,7 @@ public:
+ 
+ /*!
+     \enum QMutex::RecursionMode
++    \obsolete Use QRecursiveMutex to create a recursive mutex.
+ 
+     \value Recursive  In this mode, a thread can lock the same mutex
+                       multiple times and the mutex won't be unlocked
+@@ -173,6 +174,7 @@ public:
+ 
+ /*!
+     Constructs a new mutex. The mutex is created in an unlocked state.
++    \obsolete Use QRecursiveMutex to create a recursive mutex.
+ 
+     If \a mode is QMutex::Recursive, a thread can lock the same mutex
+     multiple times and the mutex won't be unlocked until a
+@@ -197,7 +199,7 @@ QMutex::QMutex(RecursionMode mode)
+ QMutex::~QMutex()
+ {
+     QMutexData *d = d_ptr.loadRelaxed();
+-    if (isRecursive()) {
++    if (QBasicMutex::isRecursive()) {
+         delete static_cast<QRecursiveMutexPrivate *>(d);
+     } else if (d) {
+ #ifndef QT_LINUX_FUTEX
+diff --git a/src/corelib/thread/qmutex.h b/src/corelib/thread/qmutex.h
+index 73c9e006630..b2e2640ba2d 100644
+--- a/src/corelib/thread/qmutex.h
++++ b/src/corelib/thread/qmutex.h
+@@ -134,8 +134,16 @@ public:
+ #else
+     QMutex() { d_ptr.storeRelaxed(nullptr); }
+ #endif
++#if QT_DEPRECATED_SINCE(5,15)
+     enum RecursionMode { NonRecursive, Recursive };
++    QT_DEPRECATED_VERSION_X(5, 15, "Use QRecursiveMutex instead of a recursive QMutex")
+     explicit QMutex(RecursionMode mode);
++
++    QT_DEPRECATED_VERSION_X(5, 15, "Use QRecursiveMutex instead of a recursive QMutex")
++    bool isRecursive() const noexcept
++    { return QBasicMutex::isRecursive(); }
++#endif
++
+     ~QMutex();
+ 
+     // BasicLockable concept
+@@ -166,9 +174,6 @@ public:
+     }
+ #endif
+ 
+-    bool isRecursive() const noexcept
+-    { return QBasicMutex::isRecursive(); }
+-
+ private:
+     Q_DISABLE_COPY(QMutex)
+     friend class QMutexLocker;
+diff --git a/src/corelib/thread/qwaitcondition_unix.cpp b/src/corelib/thread/qwaitcondition_unix.cpp
+index 88b058f4101..0f1da4dc9b3 100644
+--- a/src/corelib/thread/qwaitcondition_unix.cpp
++++ b/src/corelib/thread/qwaitcondition_unix.cpp
+@@ -213,7 +213,7 @@ bool QWaitCondition::wait(QMutex *mutex, QDeadlineTimer deadline)
+ {
+     if (! mutex)
+         return false;
+-    if (mutex->isRecursive()) {
++    if (static_cast<QBasicMutex *>(mutex)->isRecursive()) {
+         qWarning("QWaitCondition: cannot wait on recursive mutexes");
+         return false;
+     }
+-- 
+2.39.5 (Apple Git-154)
+

conan_patches/qt/patches/kde/0004-Deprecate-QMutex-in-recursive-mode.patch

@@ -0,0 +1,48 @@
+From 5761fc24f3cf015428dd4816800e3142e44a6b8d Mon Sep 17 00:00:00 2001
+From: Luca Beldi <[email protected]>
+Date: Fri, 23 Apr 2021 15:35:29 +0100
+Subject: [PATCH 005/130] Fix QAbstractItemModelTester false positive
+
+When inserting rows to a branch with no columns
+the tester should not complain about indexes being invalid
+
+Pick-to: 6.1 6.0 5.15
+Change-Id: I466f4e5140b10f6dcf65a71f109c2d3be7336507
+Reviewed-by: David Faure <[email protected]>
+(cherry picked from commit fcea8e7aa8a65de9e80136c2d603478831b246d0)
+---
+ src/testlib/qabstractitemmodeltester.cpp                      | 2 +-
+ .../qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp | 4 ++++
+ 2 files changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/src/testlib/qabstractitemmodeltester.cpp b/src/testlib/qabstractitemmodeltester.cpp
+index 1cd18b98bbc..41219a7e233 100644
+--- a/src/testlib/qabstractitemmodeltester.cpp
++++ b/src/testlib/qabstractitemmodeltester.cpp
+@@ -454,7 +454,7 @@ void QAbstractItemModelTesterPrivate::parent()
+ 
+     // Common error test #2, make sure that a second level index has a parent
+     // that is the first level index.
+-    if (model->rowCount(topIndex) > 0) {
++    if (model->rowCount(topIndex) > 0 && model->columnCount(topIndex) > 0) {
+         QModelIndex childIndex = model->index(0, 0, topIndex);
+         MODELTESTER_VERIFY(childIndex.isValid());
+         MODELTESTER_COMPARE(model->parent(childIndex), topIndex);
+diff --git a/tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp b/tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp
+index f6ad97a96be..61452dceaed 100644
+--- a/tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp
++++ b/tests/auto/testlib/qabstractitemmodeltester/tst_qabstractitemmodeltester.cpp
+@@ -116,6 +116,10 @@ void tst_QAbstractItemModelTester::standardItemModelZeroColumns()
+     // QTBUG-92886
+     model.insertRows(0, 5);
+     model.removeRows(1, 2);
++
++    const QModelIndex parentIndex = model.index(0, 0);
++    model.insertRows(0, 5, parentIndex);
++    model.removeRows(1, 2, parentIndex);
+ }
+ 
+ void tst_QAbstractItemModelTester::testInsertThroughProxy()
+-- 
+2.39.5 (Apple Git-154)
+