Merge pull request #24 from vcon-dev/fix-inline-dialog

Bump version to 0.3.9

Author: howethomas

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "vcon"
-version = "0.3.8"
+version = "0.3.9"
 description = "The vCon library"
 authors = ["Thomas McCarthy-Howe <ghostofbasho@gmail.com>"]
 license = "MIT"

setup.py

@@ -5,7 +5,7 @@
 
 setup(
     name="vcon",
-    version="0.3.8",
+    version="0.3.9",
     author="Thomas McCarthy-Howe",
     author_email="ghostofbasho@gmail.com",
     description="A package for working with vCon containers",

src/vcon/dialog.py

@@ -284,10 +284,6 @@ def to_inline_data(self) -> None:
         :return: None
         :rtype: None
         """
-        # Ensure filename attribute exists
-        if not hasattr(self, "filename"):
-            self.filename = None
-
         # Read the contents from the URL
         response = requests.get(self.url)
         if response.status_code == 200:
@@ -306,11 +302,9 @@ def to_inline_data(self) -> None:
             hashlib.sha256(raw_content).digest()
         ).decode()
 
-        # Set the filename if not already provided
-        if not self.filename:
-            # Extract filename from URL, removing any query parameters
-            url_path = self.url.split("?")[0]
-            self.filename = url_path.split("/")[-1]
+        # Set the filename if it doesn't exist
+        if not hasattr(self, "filename"):
+            self.filename = self.url.split("/")[-1]
 
         # Remove the url since this is now inline data
         delattr(self, "url")