fix: Strip ANSI codes in tests to handle Rich color output on CI

Add strip_ansi helper function to remove ANSI escape codes from CLI
output before assertions. Rich/Typer outputs color codes that split
option names like --build into separate strings, causing test failures.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: howethomas

tests/test_cli.py

@@ -2,12 +2,20 @@
 CLI integration tests for Conserver.
 """
 
+import re
+
 from typer.testing import CliRunner
 
 from conserver import __version__
 from conserver.cli import app
 
 
+def strip_ansi(text: str) -> str:
+    """Strip ANSI escape codes from text."""
+    ansi_pattern = re.compile(r"\x1b\[[0-9;]*m")
+    return ansi_pattern.sub("", text)
+
+
 def test_version(cli_runner: CliRunner) -> None:
     """Test --version flag."""
     result = cli_runner.invoke(app, ["--version"])
@@ -30,68 +38,76 @@ def test_start_help(cli_runner: CliRunner) -> None:
     """Test start command help."""
     result = cli_runner.invoke(app, ["start", "--help"])
     assert result.exit_code == 0
-    assert "--build" in result.stdout
-    assert "--detach" in result.stdout
-    assert "--services" in result.stdout
+    output = strip_ansi(result.stdout)
+    assert "--build" in output
+    assert "--detach" in output
+    assert "--services" in output
 
 
 def test_stop_help(cli_runner: CliRunner) -> None:
     """Test stop command help."""
     result = cli_runner.invoke(app, ["stop", "--help"])
     assert result.exit_code == 0
-    assert "--remove" in result.stdout
-    assert "--volumes" in result.stdout
-    assert "--timeout" in result.stdout
+    output = strip_ansi(result.stdout)
+    assert "--remove" in output
+    assert "--volumes" in output
+    assert "--timeout" in output
 
 
 def test_status_help(cli_runner: CliRunner) -> None:
     """Test status command help."""
     result = cli_runner.invoke(app, ["status", "--help"])
     assert result.exit_code == 0
-    assert "--format" in result.stdout
-    assert "--all" in result.stdout
-    assert "--watch" in result.stdout
+    output = strip_ansi(result.stdout)
+    assert "--format" in output
+    assert "--all" in output
+    assert "--watch" in output
 
 
 def test_config_help(cli_runner: CliRunner) -> None:
     """Test config command help."""
     result = cli_runner.invoke(app, ["config", "--help"])
     assert result.exit_code == 0
-    assert "show" in result.stdout
-    assert "edit" in result.stdout
-    assert "set" in result.stdout
-    assert "validate" in result.stdout
-    assert "init" in result.stdout
+    output = strip_ansi(result.stdout)
+    assert "show" in output
+    assert "edit" in output
+    assert "set" in output
+    assert "validate" in output
+    assert "init" in output
 
 
 def test_config_show_help(cli_runner: CliRunner) -> None:
     """Test config show command help."""
     result = cli_runner.invoke(app, ["config", "show", "--help"])
     assert result.exit_code == 0
-    assert "--file" in result.stdout
-    assert "--secrets" in result.stdout
+    output = strip_ansi(result.stdout)
+    assert "--file" in output
+    assert "--secrets" in output
 
 
 def test_logs_help(cli_runner: CliRunner) -> None:
     """Test logs command help."""
     result = cli_runner.invoke(app, ["logs", "--help"])
     assert result.exit_code == 0
-    assert "--follow" in result.stdout
-    assert "--tail" in result.stdout
-    assert "--since" in result.stdout
+    output = strip_ansi(result.stdout)
+    assert "--follow" in output
+    assert "--tail" in output
+    assert "--since" in output
 
 
 def test_health_help(cli_runner: CliRunner) -> None:
     """Test health command help."""
     result = cli_runner.invoke(app, ["health", "--help"])
     assert result.exit_code == 0
-    assert "--verbose" in result.stdout
+    output = strip_ansi(result.stdout)
+    assert "--verbose" in output
 
 
 def test_upgrade_help(cli_runner: CliRunner) -> None:
     """Test upgrade command help."""
     result = cli_runner.invoke(app, ["upgrade", "--help"])
     assert result.exit_code == 0
-    assert "--pull" in result.stdout
-    assert "--backup" in result.stdout
-    assert "--dry-run" in result.stdout
+    output = strip_ansi(result.stdout)
+    assert "--pull" in output
+    assert "--backup" in output
+    assert "--dry-run" in output

tests/test_commands/test_config.py

@@ -2,6 +2,7 @@
 Tests for config commands.
 """
 
+import re
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
@@ -10,15 +11,22 @@
 from conserver.cli import app
 
 
+def strip_ansi(text: str) -> str:
+    """Strip ANSI escape codes from text."""
+    ansi_pattern = re.compile(r"\x1b\[[0-9;]*m")
+    return ansi_pattern.sub("", text)
+
+
 class TestConfigShowCommand:
     """Tests for the config show command."""
 
     def test_config_show_help(self, cli_runner: CliRunner) -> None:
         """Test config show command shows help."""
         result = cli_runner.invoke(app, ["config", "show", "--help"])
         assert result.exit_code == 0
-        assert "--file" in result.stdout
-        assert "--secrets" in result.stdout
+        output = strip_ansi(result.stdout)
+        assert "--file" in output
+        assert "--secrets" in output
 
     @patch("conserver.commands.config.DockerOps")
     def test_config_show_env(
@@ -210,7 +218,8 @@ def test_config_init_help(self, cli_runner: CliRunner) -> None:
         """Test config init command shows help."""
         result = cli_runner.invoke(app, ["config", "init", "--help"])
         assert result.exit_code == 0
-        assert "--overwrite" in result.stdout
+        output = strip_ansi(result.stdout)
+        assert "--overwrite" in output
 
     @patch("conserver.commands.config.DockerOps")
     def test_config_init_creates_files(

tests/test_commands/test_start.py

@@ -2,6 +2,7 @@
 Tests for start command.
 """
 
+import re
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
@@ -10,15 +11,22 @@
 from conserver.cli import app
 
 
+def strip_ansi(text: str) -> str:
+    """Strip ANSI escape codes from text."""
+    ansi_pattern = re.compile(r"\x1b\[[0-9;]*m")
+    return ansi_pattern.sub("", text)
+
+
 class TestStartCommand:
     """Tests for the start command."""
 
     def test_start_help(self, cli_runner: CliRunner) -> None:
         """Test start command shows help."""
         result = cli_runner.invoke(app, ["start", "--help"])
         assert result.exit_code == 0
-        assert "--build" in result.stdout
-        assert "--services" in result.stdout
+        output = strip_ansi(result.stdout)
+        assert "--build" in output
+        assert "--services" in output
 
     @patch("conserver.commands.start.DockerOps")
     @patch("conserver.commands.start.HealthChecker")

tests/test_commands/test_status.py

@@ -2,6 +2,7 @@
 Tests for status command.
 """
 
+import re
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
@@ -11,15 +12,22 @@
 from conserver.docker_ops import ContainerInfo
 
 
+def strip_ansi(text: str) -> str:
+    """Strip ANSI escape codes from text."""
+    ansi_pattern = re.compile(r"\x1b\[[0-9;]*m")
+    return ansi_pattern.sub("", text)
+
+
 class TestStatusCommand:
     """Tests for the status command."""
 
     def test_status_help(self, cli_runner: CliRunner) -> None:
         """Test status command shows help."""
         result = cli_runner.invoke(app, ["status", "--help"])
         assert result.exit_code == 0
-        assert "--format" in result.stdout
-        assert "--all" in result.stdout
+        output = strip_ansi(result.stdout)
+        assert "--format" in output
+        assert "--all" in output
 
     @patch("conserver.commands.status.DockerOps")
     def test_status_no_containers(

tests/test_commands/test_stop.py

@@ -2,6 +2,7 @@
 Tests for stop command.
 """
 
+import re
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
@@ -10,15 +11,22 @@
 from conserver.cli import app
 
 
+def strip_ansi(text: str) -> str:
+    """Strip ANSI escape codes from text."""
+    ansi_pattern = re.compile(r"\x1b\[[0-9;]*m")
+    return ansi_pattern.sub("", text)
+
+
 class TestStopCommand:
     """Tests for the stop command."""
 
     def test_stop_help(self, cli_runner: CliRunner) -> None:
         """Test stop command shows help."""
         result = cli_runner.invoke(app, ["stop", "--help"])
         assert result.exit_code == 0
-        assert "--remove" in result.stdout
-        assert "--volumes" in result.stdout
+        output = strip_ansi(result.stdout)
+        assert "--remove" in output
+        assert "--volumes" in output
 
     @patch("conserver.commands.stop.DockerOps")
     def test_stop_no_containers(