Add GitHub Actions CI workflow and fix linting

- Add .github/workflows/tests.yml for automated testing
  - Run tests on Python 3.10, 3.11, 3.12
  - Run Black formatting check
  - Run Ruff linting check
  - Upload coverage to Codecov
- Format all code with Black
- Fix all Ruff linting issues
- Update pyproject.toml with refined Ruff configuration
  - Ignore N803 (Twilio uses PascalCase params)
  - Ignore B008 (FastAPI Depends pattern)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: howethomas

.github/workflows/tests.yml

@@ -0,0 +1,61 @@
+name: Tests
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        python-version: ["3.10", "3.11", "3.12"]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install git+https://github.com/vcon-dev/vcon-lib.git
+          pip install -e ".[dev]"
+
+      - name: Run tests with coverage
+        run: |
+          pytest --cov=core --cov=adapters --cov-report=xml --cov-report=term-missing
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v4
+        if: matrix.python-version == '3.12'
+        with:
+          files: ./coverage.xml
+          fail_ci_if_error: false
+
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install ruff black
+
+      - name: Check formatting with Black
+        run: black --check .
+
+      - name: Lint with Ruff
+        run: ruff check .

adapters/__init__.py

@@ -15,11 +15,7 @@
 """
 
 # Import all adapters for convenient access
-from . import twilio
-from . import freeswitch
-from . import asterisk
-from . import telnyx
-from . import bandwidth
+from . import asterisk, bandwidth, freeswitch, telnyx, twilio
 
 __all__ = [
     "twilio",

adapters/asterisk/__init__.py

@@ -1,7 +1,7 @@
 """Asterisk adapter for vCon telephony adapters."""
 
-from .config import AsteriskConfig
 from .builder import AsteriskRecordingData, AsteriskVconBuilder
+from .config import AsteriskConfig
 from .webhook import create_app
 
 __all__ = [

adapters/asterisk/builder.py

@@ -3,14 +3,13 @@
 import logging
 import os
 from datetime import datetime, timezone
-from typing import Any, Dict, Optional
+from typing import Any
 
 import requests
 from requests.auth import HTTPBasicAuth
 
 from core.base_builder import BaseRecordingData, BaseVconBuilder
 
-
 logger = logging.getLogger(__name__)
 
 
@@ -35,7 +34,7 @@ class AsteriskRecordingData(BaseRecordingData):
     - timestamp: Event timestamp
     """
 
-    def __init__(self, event_data: Dict[str, Any]):
+    def __init__(self, event_data: dict[str, Any]):
         """Initialize from Asterisk event data.
 
         Args:
@@ -47,25 +46,20 @@ def __init__(self, event_data: Dict[str, Any]):
     def recording_id(self) -> str:
         """Asterisk recording name/ID."""
         return self._data.get(
-            "recording_name",
-            self._data.get("name", self._data.get("Uniqueid", ""))
+            "recording_name", self._data.get("name", self._data.get("Uniqueid", ""))
         )
 
     @property
     def from_number(self) -> str:
         """Caller's phone number."""
-        return self._data.get(
-            "caller_id_num",
-            self._data.get("CallerIDNum", "")
-        )
+        return self._data.get("caller_id_num", self._data.get("CallerIDNum", ""))
 
     @property
     def to_number(self) -> str:
         """Called phone number."""
         return self._data.get(
             "connected_line_num",
-            self._data.get("ConnectedLineNum",
-                          self._data.get("extension", ""))
+            self._data.get("ConnectedLineNum", self._data.get("extension", "")),
         )
 
     @property
@@ -88,13 +82,10 @@ def direction(self) -> str:
     @property
     def recording_url(self) -> str:
         """URL or path to the recording."""
-        return self._data.get(
-            "target_uri",
-            self._data.get("recording_url", "")
-        )
+        return self._data.get("target_uri", self._data.get("recording_url", ""))
 
     @property
-    def recording_file_path(self) -> Optional[str]:
+    def recording_file_path(self) -> str | None:
         """Local file path to the recording."""
         target_uri = self._data.get("target_uri", "")
         if target_uri.startswith("file:"):
@@ -112,7 +103,7 @@ def recording_format(self) -> str:
         return self._data.get("format", "wav")
 
     @property
-    def duration_seconds(self) -> Optional[float]:
+    def duration_seconds(self) -> float | None:
         """Recording duration in seconds."""
         duration = self._data.get("duration")
         if duration is not None:
@@ -144,7 +135,7 @@ def start_time(self) -> datetime:
         return datetime.now(timezone.utc)
 
     @property
-    def platform_tags(self) -> Dict[str, str]:
+    def platform_tags(self) -> dict[str, str]:
         """Asterisk-specific metadata tags."""
         tags = {
             "asterisk_recording_name": self.recording_id,
@@ -183,9 +174,9 @@ def __init__(
         self,
         download_recordings: bool = True,
         recording_format: str = "wav",
-        recordings_path: Optional[str] = None,
-        ari_url: Optional[str] = None,
-        ari_auth: Optional[tuple] = None,
+        recordings_path: str | None = None,
+        ari_url: str | None = None,
+        ari_auth: tuple | None = None,
     ):
         """Initialize Asterisk vCon builder.
 
@@ -201,10 +192,7 @@ def __init__(
         self.ari_url = ari_url
         self.ari_auth = ari_auth
 
-    def _download_recording(
-        self,
-        recording_data: BaseRecordingData
-    ) -> Optional[bytes]:
+    def _download_recording(self, recording_data: BaseRecordingData) -> bytes | None:
         """Download or read recording from Asterisk.
 
         Args:
@@ -259,10 +247,8 @@ def _download_recording(
                 logger.debug(f"Reading recording from file: {file_path}")
                 with open(file_path, "rb") as f:
                     return f.read()
-            except IOError as e:
+            except OSError as e:
                 logger.error(f"Failed to read recording file: {e}")
 
-        logger.error(
-            f"Could not access recording for {ast_data.recording_id}"
-        )
+        logger.error(f"Could not access recording for {ast_data.recording_id}")
         return None

adapters/asterisk/config.py

@@ -1,7 +1,7 @@
 """Configuration management for Asterisk adapter."""
 
 import os
-from typing import Optional
+
 from core.base_config import BaseConfig
 
 
@@ -12,7 +12,7 @@ class AsteriskConfig(BaseConfig):
     ARI (Asterisk REST Interface) connection and recording paths.
     """
 
-    def __init__(self, env_file: Optional[str] = None):
+    def __init__(self, env_file: str | None = None):
         """Load configuration from environment.
 
         Args:
@@ -21,10 +21,7 @@ def __init__(self, env_file: Optional[str] = None):
         super().__init__(env_file)
 
         # State file specific to Asterisk
-        self.state_file = os.getenv(
-            "STATE_FILE",
-            ".asterisk_adapter_state.json"
-        )
+        self.state_file = os.getenv("STATE_FILE", ".asterisk_adapter_state.json")
 
         # Asterisk ARI connection settings
         self.asterisk_host = os.getenv("ASTERISK_HOST", "localhost")
@@ -35,24 +32,23 @@ def __init__(self, env_file: Optional[str] = None):
         # ARI base URL
         ari_scheme = os.getenv("ASTERISK_ARI_SCHEME", "http")
         self.asterisk_ari_url = os.getenv(
-            "ASTERISK_ARI_URL",
-            f"{ari_scheme}://{self.asterisk_host}:{self.asterisk_ari_port}"
+            "ASTERISK_ARI_URL", f"{ari_scheme}://{self.asterisk_host}:{self.asterisk_ari_port}"
         )
 
         # Recording storage location (for local file access)
         self.recordings_path = os.getenv(
-            "ASTERISK_RECORDINGS_PATH",
-            "/var/spool/asterisk/recording"
+            "ASTERISK_RECORDINGS_PATH", "/var/spool/asterisk/recording"
         )
 
         # Webhook authentication (optional)
         self.webhook_secret = os.getenv("ASTERISK_WEBHOOK_SECRET")
 
         # Whether to validate webhook signatures
-        self.validate_webhook = os.getenv(
-            "VALIDATE_ASTERISK_WEBHOOK",
-            "false"
-        ).lower() in ("true", "1", "yes")
+        self.validate_webhook = os.getenv("VALIDATE_ASTERISK_WEBHOOK", "false").lower() in (
+            "true",
+            "1",
+            "yes",
+        )
 
     def get_ari_auth(self) -> tuple:
         """Get ARI authentication tuple.