Middleware should return None instead of request

Author: Clement Denoix

scrapy_selenium/middlewares.py

@@ -73,7 +73,7 @@ def process_request(self, request, spider):
         """Process a request using the selenium driver if applicable"""
 
         if not isinstance(request, SeleniumRequest):
-            return request
+            return None
 
         self.driver.get(request.url)
 

tests/test_middlewares.py

@@ -69,17 +69,16 @@ def test_spider_closed_should_close_the_driver(self):
 
         mocked_quit.assert_called_once()
 
-    def test_process_request_should_return_the_request_if_not_selenium_request(self):
-        """Test that the ``process_request`` should return a request if not selenium request"""
+    def test_process_request_should_return_none_if_not_selenium_request(self):
+        """Test that the ``process_request`` should return none if not selenium request"""
 
         scrapy_request = Request(url='http://not-an-url')
 
-        self.assertEqual(
+        self.assertIsNone(
             self.selenium_middleware.process_request(
                 request=scrapy_request,
                 spider=None
-            ),
-            scrapy_request
+            )
         )
 
     def test_process_request_should_return_a_response_if_selenium_request(self):