#69: Use alternative golangci-lint (#70)

* #69: Use alternative golangci-lint

* #69: Fix lint issues for tests in os.Create/os.Remove functions

Author: vdjagilev

.github/workflows/go.yml

@@ -15,10 +15,15 @@ jobs:
         go-version: [1.17.x]
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-
-      - name: golangci-lint
-        uses: reviewdog/action-golangci-lint@v2
+      - name: Set up Go
+        uses: actions/setup-go@v3
+        with:
+          go-version: ${{ matrix.go-version }}
+      - uses: actions/checkout@v3
+      - name: Run golangci-lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          version: latest
   test:
     strategy:
       matrix:

cmd/root_test.go

@@ -42,15 +42,15 @@ func Test_validate(t *testing.T) {
 		name    string
 		args    args
 		wantErr bool
-		before  func()
-		after   func()
+		before  func(t *testing.T)
+		after   func(t *testing.T)
 	}{
 		{
 			name:    "Wrong output format",
 			args:    args{config: formatter.Config{OutputFormat: formatter.OutputFormat("test")}},
 			wantErr: true,
-			before:  func() {},
-			after:   func() {},
+			before:  func(t *testing.T) {},
+			after:   func(t *testing.T) {},
 		},
 		{
 			name: "Missing input file",
@@ -60,8 +60,8 @@ func Test_validate(t *testing.T) {
 				},
 			},
 			wantErr: true,
-			before:  func() {},
-			after:   func() {},
+			before:  func(t *testing.T) {},
+			after:   func(t *testing.T) {},
 		},
 		{
 			name: "Successful validation",
@@ -72,18 +72,26 @@ func Test_validate(t *testing.T) {
 				},
 			},
 			wantErr: false,
-			before: func() {
-				os.Create(path.Join(os.TempDir(), "formatter_cmd_valid_2"))
+			before: func(t *testing.T) {
+				path := path.Join(os.TempDir(), "formatter_cmd_valid_2")
+				_, err := os.Create(path)
+				if err != nil {
+					t.Errorf("could not create temporary file: %s", path)
+				}
 			},
-			after: func() {
-				os.Remove(path.Join(os.TempDir(), "formatter_cmd_valid_2"))
+			after: func(t *testing.T) {
+				path := path.Join(os.TempDir(), "formatter_cmd_valid_2")
+				err := os.Remove(path)
+				if err != nil {
+					t.Errorf("could not remove temporary file: %s", path)
+				}
 			},
 		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			tt.before()
-			defer tt.after()
+			tt.before(t)
+			defer tt.after(t)
 			if err := validate(tt.args.config); (err != nil) != tt.wantErr {
 				t.Errorf("validate() error = %v, wantErr %v", err, tt.wantErr)
 			}
@@ -145,14 +153,26 @@ func Test_run(t *testing.T) {
 		cmd  *cobra.Command
 		args []string
 	}
-	before := func(file string, testWorkflow formatter.Workflow, testConfig formatter.Config) {
-		os.Create(file)
+	before := func(file string, testWorkflow formatter.Workflow, testConfig formatter.Config, t *testing.T) {
+		var err error
+		if len(file) != 0 {
+			_, err = os.Create(file)
+		}
+		if err != nil {
+			t.Errorf("could not create temporary file: %s", file)
+		}
 		workflow = testWorkflow
 		config = testConfig
 		config.InputFile = formatter.InputFile(file)
 	}
-	after := func(file string) {
-		os.Remove(file)
+	after := func(file string, t *testing.T) {
+		var err error
+		if len(file) != 0 {
+			err = os.Remove(file)
+		}
+		if err != nil {
+			t.Errorf("could not remove temporary file: %s", file)
+		}
 		workflow = nil
 		config = formatter.Config{}
 	}
@@ -212,8 +232,8 @@ func Test_run(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			if tt.runBefore {
-				before(tt.input, tt.workflow, tt.config)
-				defer after(tt.input)
+				before(tt.input, tt.workflow, tt.config, t)
+				defer after(tt.input, t)
 			}
 			if err := run(tt.args.cmd, tt.args.args); (err != nil) != tt.wantErr {
 				t.Errorf("run() error = %v, wantErr %v", err, tt.wantErr)

formatter/workflow_test.go

@@ -100,7 +100,7 @@ func TestMainWorkflow_Execute(t *testing.T) {
 		wantErr     bool
 		fileName    string
 		fileContent string
-		before      func(file string)
+		before      func(file string, t *testing.T)
 	}{
 		{
 			name: "Cannot open OutputFile for a write",
@@ -119,9 +119,13 @@ func TestMainWorkflow_Execute(t *testing.T) {
 			wantErr:     true,
 			fileName:    "main_workflow_Execute_2_test",
 			fileContent: "",
-			before: func(file string) {
+			before: func(file string, t *testing.T) {
 				// Creating output file
-				os.Create(path.Join(os.TempDir(), file+"_output"))
+				path := path.Join(os.TempDir(), file+"_output")
+				_, err := os.Create(path)
+				if err != nil {
+					t.Errorf("failed to create temporary output file: %s", path)
+				}
 			},
 		},
 		{
@@ -159,7 +163,7 @@ func TestMainWorkflow_Execute(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			if tt.before != nil {
-				tt.before(tt.fileName)
+				tt.before(tt.fileName, t)
 			}
 			if tt.fileName != "" {
 				name := path.Join(os.TempDir(), tt.fileName)