Ensure the new content_length field for HTTP request and response events are an integer.

Author: binarylogic

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+
+  - Ensure the new `content_length` field for HTTP request and response events are an integer.
+
 ## [2.5.0] - 2017-10-27
 
 ### Changed

lib/timber/events/http_request.rb

@@ -14,7 +14,7 @@ class HTTPRequest < Timber::Event
 
       def initialize(attributes)
         @body = attributes[:body] && Util::HTTPEvent.normalize_body(attributes[:body])
-        @content_length = attributes[:content_length]
+        @content_length = Timber::Util::Object.try(attributes[:content_length], :to_i)
         @headers = Util::HTTPEvent.normalize_headers(attributes[:headers])
         @host = attributes[:host]
         @method = Util::HTTPEvent.normalize_method(attributes[:method]) || raise(ArgumentError.new(":method is required"))

lib/timber/events/http_response.rb

@@ -13,7 +13,7 @@ class HTTPResponse < Timber::Event
 
       def initialize(attributes)
         @body = attributes[:body] && Util::HTTPEvent.normalize_body(attributes[:body])
-        @content_length = attributes[:content_length]
+        @content_length = Timber::Util::Object.try(attributes[:content_length], :to_i)
         @headers = Util::HTTPEvent.normalize_headers(attributes[:headers])
         @http_context = attributes[:http_context]
         @request_id = attributes[:request_id]

spec/timber/events/http_request_spec.rb

@@ -4,6 +4,11 @@
 
 describe Timber::Events::HTTPRequest, :rails_23 => true do
   describe ".initialize" do
+    it "should coerce content_length into an integer" do
+      event = described_class.new(:method => 'GET', :content_length => "123")
+      expect(event.content_length).to eq(123)
+    end
+
     context "with a header filters" do
       around(:each) do |example|
         old_http_header_filters = Timber::Config.instance.http_header_filters

spec/timber/events/http_response_spec.rb

@@ -0,0 +1,12 @@
+# encoding: UTF-8
+
+require "spec_helper"
+
+describe Timber::Events::HTTPResponse, :rails_23 => true do
+  describe ".initialize" do
+    it "should coerce content_length into an integer" do
+      event = described_class.new(:content_length => "123", :status => 200, :time_ms => 1)
+      expect(event.content_length).to eq(123)
+    end
+  end
+end