chore(dev): fix top tests features and run them on CI (#24677)

* chore(dev): fix top tests features and run them on CI

* add PR comment CI trigger

* fix features

* upload_test_results: true

* fix bad rebase

Author: pront

.github/workflows/ci-review-trigger.yml

@@ -11,6 +11,7 @@
 #
 # /ci-run-all                 : runs all of the below
 # /ci-run-cli                 : runs CLI - Linux
+# /ci-run-test-top            : runs make test-top
 # /ci-run-test-behavior       : runs make test-behavior
 # /ci-run-check-examples      : runs make check-examples
 # /ci-run-test-docs           : runs make test-docs
@@ -55,6 +56,7 @@ jobs:
     if: |
         startsWith(github.event.review.body, '/ci-run-all')
         || startsWith(github.event.review.body, '/ci-run-cli')
+        || startsWith(github.event.review.body, '/ci-run-test-top')
         || startsWith(github.event.review.body, '/ci-run-test-behavior')
         || startsWith(github.event.review.body, '/ci-run-check-examples')
         || startsWith(github.event.review.body, '/ci-run-test-docs')
@@ -93,6 +95,16 @@ jobs:
       job_name: CLI tests
     secrets: inherit
 
+  make-test-top:
+    needs: validate
+    if: startsWith(github.event.review.body, '/ci-run-all') || contains(github.event.review.body, '/ci-run-test-top')
+    uses: ./.github/workflows/test-make-command.yml
+    with:
+      ref: ${{ github.event.review.commit_id }}
+      command: test-top
+      job_name: make test-top
+    secrets: inherit
+
   make-test-behavior:
     needs: validate
     if: startsWith(github.event.review.body, '/ci-run-all') || contains(github.event.review.body, '/ci-run-test-behavior')

.github/workflows/master_merge_queue.yml

@@ -56,6 +56,16 @@ jobs:
     needs: changes
     secrets: inherit
 
+  test-top:
+    if: ${{ needs.changes.outputs.source == 'true' || needs.changes.outputs.test-make-command-yml == 'true' }}
+    uses: ./.github/workflows/test-make-command.yml
+    with:
+      command: test-top
+      job_name: make test-top
+      upload_test_results: true
+    needs: changes
+    secrets: inherit
+
   make-test-behavior:
     if: ${{ needs.changes.outputs.source == 'true' || needs.changes.outputs.test-make-command-yml == 'true' }}
     uses: ./.github/workflows/test-make-command.yml
@@ -126,6 +136,7 @@ jobs:
     needs:
       - changes
       - test-cli
+      - test-top
       - make-test-behavior
       - make-check-examples
       - make-test-docs

Cargo.toml

@@ -41,6 +41,11 @@ path = "tests/integration/lib.rs"
 name = "e2e"
 path = "tests/e2e/mod.rs"
 
+[[test]]
+name = "top"
+path = "tests/top/lib.rs"
+required-features = ["top-tests"]
+
 # CI-based builds use full release optimization. See scripts/environment/release-flags.sh.
 # This results in roughly a 5% reduction in performance when compiling locally vs when
 # compiled via the CI pipeline.
@@ -943,6 +948,7 @@ all-integration-tests = [
   "pulsar-integration-tests",
   "redis-integration-tests",
   "splunk-integration-tests",
+  "top-tests",
   "webhdfs-integration-tests",
 ]
 
@@ -1010,6 +1016,7 @@ pulsar-integration-tests = ["sinks-pulsar", "sources-pulsar"]
 redis-integration-tests = ["sinks-redis", "sources-redis"]
 splunk-integration-tests = ["sinks-splunk_hec"]
 dnstap-integration-tests = ["sources-dnstap", "dep:bollard"]
+top-tests = ["top", "api", "sources-demo_logs", "sinks-blackhole"]
 webhdfs-integration-tests = ["sinks-webhdfs"]
 disable-resolv-conf = []
 shutdown-tests = ["api", "sinks-blackhole", "sinks-console", "sinks-prometheus", "sources", "transforms-lua", "transforms-remap", "unix"]

Makefile

@@ -406,9 +406,13 @@ test-e2e-kubernetes: ## Runs Kubernetes E2E tests (Sorry, no `ENVIRONMENT=true`
 test-cli: ## Runs cli tests
 	${MAYBE_ENVIRONMENT_EXEC} cargo nextest run --no-fail-fast --no-default-features --features cli-tests --test integration --test-threads 4
 
+.PHONY: test-top
+test-top: ## Runs top tests
+	${MAYBE_ENVIRONMENT_EXEC} cargo nextest run --no-fail-fast --no-default-features --features top-tests --test top --test-threads 4
+
 .PHONY: test-component-validation
 test-component-validation: ## Runs component validation tests
-	${MAYBE_ENVIRONMENT_EXEC} cargo nextest run --no-fail-fast --no-default-features --features component-validation-tests --status-level pass --test-threads 4 components::validation::tests
+	${MAYBE_ENVIRONMENT_EXEC} cargo nextest run --no-fail-fast --no-default-features --features component-validation-tests --status-level pass --test-threads 4 --lib components::validation::tests
 
 ##@ Benching (Supports `ENVIRONMENT=true`)
 

tests/integration/lib.rs

@@ -12,10 +12,6 @@ mod cli;
 #[cfg(feature = "shutdown-tests")]
 mod shutdown;
 
-// Top tests use Unix signals (SIGTERM, SIGHUP) via the nix crate
-#[cfg(all(feature = "top", target_family = "unix"))]
-mod top;
-
 /// Creates a file with given content
 pub fn create_file(config: &str) -> PathBuf {
     let path = temp_file();