Skip to content

Commit 70a8bfa

Browse files
chore(ci): remove docker dependency from deb/rpm package targets (#24864)
1 parent 40e8291 commit 70a8bfa

File tree

4 files changed

+14
-15
lines changed

4 files changed

+14
-15
lines changed

.github/workflows/k8s_e2e.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,10 @@ jobs:
8888
rust: true
8989
cross: true
9090
mold: false
91+
cargo-deb: true
92+
93+
- name: Install packaging dependencies
94+
run: sudo apt-get install -y cmark-gfm
9195

9296
- run: VECTOR_VERSION="$(vdev version)" make package-deb-x86_64-unknown-linux-gnu
9397

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ jobs:
7171
- name: Bootstrap runner environment (Ubuntu-specific)
7272
run: sudo -E bash scripts/environment/bootstrap-ubuntu-24.04.sh
7373
- name: Bootstrap runner environment (generic)
74-
run: bash scripts/environment/prepare.sh --modules=rustup,cross
74+
run: bash scripts/environment/prepare.sh --modules=rustup,cross,cargo-deb
7575
- name: Build Vector
7676
run: make package-${{ matrix.target }}-all
7777
- name: Stage package artifacts for publish

Makefile

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -599,41 +599,41 @@ package-arm-unknown-linux-musleabi: target/artifacts/vector-${VERSION}-arm-unkno
599599

600600
.PHONY: package-deb-x86_64-unknown-linux-gnu
601601
package-deb-x86_64-unknown-linux-gnu: package-x86_64-unknown-linux-gnu ## Build the x86_64 GNU deb package
602-
$(CONTAINER_TOOL) run -v $(PWD):/git/vectordotdev/vector/ -e TARGET=x86_64-unknown-linux-gnu -e VECTOR_VERSION $(ENVIRONMENT_UPSTREAM) cargo vdev package deb
602+
TARGET=x86_64-unknown-linux-gnu $(VDEV) package deb
603603

604604
.PHONY: package-deb-x86_64-unknown-linux-musl
605605
package-deb-x86_64-unknown-linux-musl: package-x86_64-unknown-linux-musl ## Build the x86_64 GNU deb package
606-
$(CONTAINER_TOOL) run -v $(PWD):/git/vectordotdev/vector/ -e TARGET=x86_64-unknown-linux-musl -e VECTOR_VERSION $(ENVIRONMENT_UPSTREAM) cargo vdev package deb
606+
TARGET=x86_64-unknown-linux-musl $(VDEV) package deb
607607

608608
.PHONY: package-deb-aarch64
609609
package-deb-aarch64: package-aarch64-unknown-linux-gnu ## Build the aarch64 deb package
610-
$(CONTAINER_TOOL) run -v $(PWD):/git/vectordotdev/vector/ -e TARGET=aarch64-unknown-linux-gnu -e VECTOR_VERSION $(ENVIRONMENT_UPSTREAM) cargo vdev package deb
610+
TARGET=aarch64-unknown-linux-gnu $(VDEV) package deb
611611

612612
.PHONY: package-deb-armv7-gnu
613613
package-deb-armv7-gnu: package-armv7-unknown-linux-gnueabihf ## Build the armv7-unknown-linux-gnueabihf deb package
614-
$(CONTAINER_TOOL) run -v $(PWD):/git/vectordotdev/vector/ -e TARGET=armv7-unknown-linux-gnueabihf -e VECTOR_VERSION $(ENVIRONMENT_UPSTREAM) cargo vdev package deb
614+
TARGET=armv7-unknown-linux-gnueabihf $(VDEV) package deb
615615

616616
.PHONY: package-deb-arm-gnu
617617
package-deb-arm-gnu: package-arm-unknown-linux-gnueabi ## Build the arm-unknown-linux-gnueabi deb package
618-
$(CONTAINER_TOOL) run -v $(PWD):/git/vectordotdev/vector/ -e TARGET=arm-unknown-linux-gnueabi -e VECTOR_VERSION $(ENVIRONMENT_UPSTREAM) cargo vdev package deb
618+
TARGET=arm-unknown-linux-gnueabi $(VDEV) package deb
619619

620620
# rpms
621621

622622
.PHONY: package-rpm-x86_64-unknown-linux-gnu
623623
package-rpm-x86_64-unknown-linux-gnu: package-x86_64-unknown-linux-gnu ## Build the x86_64 rpm package
624-
$(CONTAINER_TOOL) run -v $(PWD):/git/vectordotdev/vector/ -e TARGET=x86_64-unknown-linux-gnu -e VECTOR_VERSION $(ENVIRONMENT_UPSTREAM) cargo vdev package rpm
624+
TARGET=x86_64-unknown-linux-gnu $(VDEV) package rpm
625625

626626
.PHONY: package-rpm-x86_64-unknown-linux-musl
627627
package-rpm-x86_64-unknown-linux-musl: package-x86_64-unknown-linux-musl ## Build the x86_64 musl rpm package
628-
$(CONTAINER_TOOL) run -v $(PWD):/git/vectordotdev/vector/ -e TARGET=x86_64-unknown-linux-musl -e VECTOR_VERSION $(ENVIRONMENT_UPSTREAM) cargo vdev package rpm
628+
TARGET=x86_64-unknown-linux-musl $(VDEV) package rpm
629629

630630
.PHONY: package-rpm-aarch64
631631
package-rpm-aarch64: package-aarch64-unknown-linux-gnu ## Build the aarch64 rpm package
632-
$(CONTAINER_TOOL) run -v $(PWD):/git/vectordotdev/vector/ -e TARGET=aarch64-unknown-linux-gnu -e VECTOR_VERSION $(ENVIRONMENT_UPSTREAM) cargo vdev package rpm
632+
TARGET=aarch64-unknown-linux-gnu $(VDEV) package rpm
633633

634634
.PHONY: package-rpm-armv7hl-gnu
635635
package-rpm-armv7hl-gnu: package-armv7-unknown-linux-gnueabihf ## Build the armv7hl-unknown-linux-gnueabihf rpm package
636-
$(CONTAINER_TOOL) run -v $(PWD):/git/vectordotdev/vector/ -e TARGET=armv7-unknown-linux-gnueabihf -e ARCH=armv7hl -e VECTOR_VERSION $(ENVIRONMENT_UPSTREAM) cargo vdev package rpm
636+
TARGET=armv7-unknown-linux-gnueabihf ARCH=armv7hl $(VDEV) package rpm
637637

638638
##@ Releasing
639639

scripts/package-deb.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,6 @@ cat LICENSE NOTICE >"$PROJECT_ROOT/target/debian-license.txt"
7171
# --no-build
7272
# because this step should follow a build
7373

74-
# TODO: Remove this after the Vector docker image contains a newer cargo-deb version.
75-
# Temporary override of cargo-deb to support Rust 2024 edition.
76-
if [[ "$(cargo-deb --version 2>/dev/null)" != "2.9.3" ]]; then
77-
cargo install cargo-deb --version 2.9.3 --force --locked
78-
fi
7974
cargo deb --target "$TARGET" --deb-version "${PACKAGE_VERSION}-1" --variant "$TARGET" --no-build --no-strip
8075

8176
# Rename the resulting .deb file to remove TARGET from name.

0 commit comments

Comments
 (0)