Skip to content

Commit e1b22a1

Browse files
committed
refactor: set schema to none if provider is used
1 parent 1db0f07 commit e1b22a1

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

lib/codecs/src/encoding/format/arrow.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,10 @@ impl ArrowStreamSerializerConfig {
9191
}
9292

9393
/// Create a new ArrowStreamSerializerConfig with a schema provider
94-
pub fn with_provider(provider: Arc<dyn SchemaProvider>) -> Self {
95-
Self {
96-
schema: None,
97-
schema_provider: Some(provider),
98-
allow_nullable_fields: false,
99-
}
94+
pub fn with_provider(mut self, provider: Arc<dyn SchemaProvider>) -> Self {
95+
self.schema = None;
96+
self.schema_provider = Some(provider);
97+
self
10098
}
10199

102100
/// Get the schema provider if one was configured

src/sinks/clickhouse/config.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -352,9 +352,7 @@ impl ClickhouseConfig {
352352
auth.cloned(),
353353
));
354354

355-
let mut arrow_config = ArrowStreamSerializerConfig::with_provider(provider);
356-
// Preserve allow_nullable_fields setting from the user's config
357-
arrow_config.allow_nullable_fields = base_config.allow_nullable_fields;
355+
let mut arrow_config = base_config.with_provider(provider);
358356
arrow_config.resolve().await.map_err(|e| {
359357
format!(
360358
"Failed to fetch schema for {}.{}: {}.",

0 commit comments

Comments
 (0)