Missing enrichment dependency and Type Mismatch Error with git in Cargo.toml

[LinTechSo]

Hi,

Description:

I have encountered two issues while working with the web-playground or vrl-server:

Missing enrichment Dependency:

The Cargo.toml file of the main vector.dev repo does not include the enrichment dependency. As a result, attempting to use enrichment::vrl_functions() in the vrl-server codebase leads to unresolved types and potential build errors.

Type Mismatch Error with git in Cargo.toml:

When attempting to use the git feature in our Cargo.toml to reference remote dependencies , a type mismatch error occurs during the build process. The error is as follows:

error[E0271]: type mismatch resolving `<Vec<Box<dyn Function>> as IntoIterator>::Item == Box<dyn Function>`
  --> src/resolve.rs:79:22
   |
79 |     functions.extend(vector_vrl_functions::all());
   |               ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected trait `vrl::compiler::Function`, found trait `vrl::compiler::function::Function`
   |               |
   |               required by a bound introduced by this call

vector version: 0.34.0
vrl version: 0.8.1

my Cargo.toml configuration:

[dependencies]
vrl.workspace = true
vector-vrl-functions = { package = "vector-vrl-functions" , git = "https://github.com/vectordotdev/vector", tag = "v0.34.0"}
enrichment = { git = "https://github.com/vectordotdev/vector", tag = "v0.34.0"}
vector-common = { git = "https://github.com/vectordotdev/vector", tag = "v0.34.0"}

[pront]

Hi @LinTechSo,

Is the full error the following:

error[E0271]: type mismatch resolving `<Vec<Box<dyn Function>> as IntoIterator>::Item == Box<dyn Function>`
   --> src/main.rs:15:16
    |
15  |     fns.extend(vector_vrl_functions::all());
    |         ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected trait `Function`, found trait `vrl::compiler::function::Function`
    |         |
    |         required by a bound introduced by this call
    |
    = note: expected struct `Box<dyn Function>`
               found struct `Box<dyn vrl::compiler::function::Function>`
    = note: perhaps two different versions of crate `vrl` are being used?
note: required by a bound in `extend`
   --> /Users/pavlos.rontidis/.rustup/toolchains/1.71.1-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/collect.rs:377:31
    |
377 |     fn extend<T: IntoIterator<Item = A>>(&mut self, iter: T);
    |                               ^^^^^^^^ required by this bound in `Extend::extend`

Is yes, it means the VRL crate is compiled twice and there are two different Function traits.

Vector v0.34 uses the "vrl 0.8.1" from crates.io and if you use the same in your project, this error will go away.

Let me know if this makes sense and if it fixes your issue.

---

I reproduced locally with the following main.rs:

use std::collections::BTreeMap;

use vrl::compiler::TargetValue;
use vrl::prelude::*;
use vrl::prelude::state::RuntimeState;
use vrl::value;
use vrl::value::Secrets;

fn main() {
    // The VRL source code to run. This just retrieves the value of field "x"
    let src = ".x";

    // Use all of the std library functions
    let mut fns = vrl::stdlib::all();
    fns.extend(vector_vrl_functions::all());
    
    // Compile the program (and panic if it's invalid)
    let result = vrl::compiler::compile(src, &fns).unwrap();

    // This is the target that can be accessed / modified in the VRL program.
    // You can use any custom type that implements `Target`, but `TargetValue` is also provided for convenience.
    let mut target = TargetValue {
        // the value starts as just an object with a single field "x" set to 1
        value: value!({x: 1}),
        // the metadata is empty
        metadata: Value::Object(BTreeMap::new()),
        // and there are no secrets associated with the target
        secrets: Secrets::default(),
    };

    // The current state of the runtime (i.e. local variables)
    let mut state = RuntimeState::default();

    let timezone = TimeZone::default();

    // A context bundles all the info necessary for the runtime to resolve a value.
    let mut ctx = Context::new(&mut target, &mut state, &timezone);

    // This executes the VRL program, making any modifications to the target, and returning a result.
    let value = result.program.resolve(&mut ctx).unwrap();

    assert_eq!(value, value!(1));
}

and Cargo.toml:

[package]
name = "use-vector-and-vrl"
version = "0.1.0"
edition = "2021"

[dependencies]
#vrl = { git = "https://github.com/vectordotdev/vrl", rev = "37319dfca17dc5d7637b24455199029cc30eb128", features = ["arbitrary", "cli", "test", "test_framework"] }
vrl = { version = "0.8.1", features = ["arbitrary", "cli", "test", "test_framework"] }

enrichment = { git = "https://github.com/vectordotdev/vector", tag = "v0.34.0" }
vector-vrl-functions = { package = "vector-vrl-functions", git = "https://github.com/vectordotdev/vector", tag = "v0.34.0" }

[LinTechSo]

Hi @pront .
Yes, your answer help me figure this out.
Thank you very much for the reply.