Skip to content

Conversation

@bachgarash
Copy link

@bachgarash bachgarash commented Oct 15, 2025

This PR contains initial implementation for SNMP source to log v1 and v2 version traps.

Summary

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@bachgarash bachgarash requested a review from a team as a code owner October 15, 2025 06:54
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Oct 15, 2025
@bachgarash bachgarash force-pushed the feat/snmp-v1/v2-log-traps branch 2 times, most recently from e6ecda3 to 7fc2822 Compare October 15, 2025 06:55
@bachgarash bachgarash marked this pull request as draft October 15, 2025 06:56
@bachgarash bachgarash force-pushed the feat/snmp-v1/v2-log-traps branch from fcd2fcd to 8769361 Compare October 15, 2025 07:08
@bachgarash bachgarash changed the title feat:#4567 initial implementation for snmp v1 and v2 traps feat: initial implementation for snmp v1 and v2 traps #4567 Oct 15, 2025
@bachgarash bachgarash marked this pull request as ready for review October 15, 2025 11:25
@thomasqueirozb thomasqueirozb added the source: new Request or implementation of a new source label Oct 16, 2025
@thomasqueirozb
Copy link
Contributor

thomasqueirozb commented Oct 16, 2025

Hi @bachgarash, thanks for your contribution! While I haven't yet looked deeply into the code I noticed that you are lacking docs for this PR. Some docs will be generated by running make generate-component-docs (I suggest you start by doing this) and others need to be manually added.

The most recent example I can remember of a new source PR is 23449. You can take a look at that PR and take a look under the files added under website for a template (added only not modified).

Also please include a Vector config and a test plan to make it easier for us to review your PR. Thanks!

@thomasqueirozb thomasqueirozb added the meta: awaiting author Pull requests that are awaiting their author. label Oct 16, 2025
@bachgarash bachgarash force-pushed the feat/snmp-v1/v2-log-traps branch from 8769361 to 467f8b1 Compare October 19, 2025 18:00
@github-actions github-actions bot removed the meta: awaiting author Pull requests that are awaiting their author. label Oct 19, 2025
@bachgarash bachgarash requested a review from a team as a code owner October 19, 2025 18:19
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Oct 19, 2025
@bachgarash bachgarash marked this pull request as draft October 19, 2025 18:21
@LucaFilipozzi
Copy link

Adding SNMPv1 traps to vector would be beneficial for my org. Anything I can do to help advance this PR?

@bachgarash
Copy link
Author

Adding SNMPv1 traps to vector would be beneficial for my org. Anything I can do to help advance this PR?

Hey, was extremely busy since this PR that I couldn't wrap up comments left here. If you have time you can push changes to this PR, it needs some documentation and examples to be provided.

Otherwise I will try to do it soon hopefully :)

@bachgarash bachgarash force-pushed the feat/snmp-v1/v2-log-traps branch from d37c6e2 to 4a2ce21 Compare December 29, 2025 19:35
@bachgarash bachgarash changed the title feat: initial implementation for snmp v1 and v2 traps #4567 feat: new source - initial implementation for snmp v1 and v2 traps #4567 Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: external docs Anything related to Vector's external, public documentation domain: sources Anything related to the Vector's sources source: new Request or implementation of a new source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants