-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: new source - initial implementation for snmp v1 and v2 traps #4567 #24004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: new source - initial implementation for snmp v1 and v2 traps #4567 #24004
Conversation
e6ecda3 to
7fc2822
Compare
fcd2fcd to
8769361
Compare
|
Hi @bachgarash, thanks for your contribution! While I haven't yet looked deeply into the code I noticed that you are lacking docs for this PR. Some docs will be generated by running The most recent example I can remember of a new source PR is 23449. You can take a look at that PR and take a look under the files added under Also please include a Vector config and a test plan to make it easier for us to review your PR. Thanks! |
8769361 to
467f8b1
Compare
|
Adding SNMPv1 traps to vector would be beneficial for my org. Anything I can do to help advance this PR? |
Hey, was extremely busy since this PR that I couldn't wrap up comments left here. If you have time you can push changes to this PR, it needs some documentation and examples to be provided. Otherwise I will try to do it soon hopefully :) |
This PR contains initial implementation for SNMP source to log v1 and v2 version traps.
d37c6e2 to
4a2ce21
Compare
This PR contains initial implementation for SNMP source to log v1 and v2 version traps.
Summary
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.