fix: remove autoremoval functionality (#79)

Since there is an option to delete a diagram within UI, there is no reason of having autoremoval now

Author: veelenga

src/constants.ts

@@ -103,11 +103,6 @@ export const UNIX_SYSTEM_PATHS = [
 
 export const WINDOWS_SYSTEM_PATHS = ["C:\\Windows", "C:\\Program Files"] as const;
 
-// ===== Timeouts and Intervals =====
-export const TIMEOUTS = {
-  CLEANUP_MAX_AGE_MS: 7 * 24 * 60 * 60 * 1000, // 7 days in milliseconds
-} as const;
-
 // ===== WebSocket Messages =====
 export const WS_MESSAGES = {
   RELOAD: "reload",

src/file-utils.ts

@@ -1,17 +1,15 @@
-import { readdir, unlink, stat, mkdir, readFile, writeFile, rmdir } from "fs/promises";
+import { readdir, unlink, readFile, writeFile, rmdir } from "fs/promises";
 import { join, resolve } from "path";
 import { tmpdir } from "os";
 import {
   APP_NAME,
   PREVIEW_ID_REGEX,
   UNIX_SYSTEM_PATHS,
   WINDOWS_SYSTEM_PATHS,
-  TIMEOUTS,
   FILE_NAMES,
   DIR_NAMES,
 } from "./constants.js";
 import type { DiagramOptions } from "./types.js";
-import { webLogger } from "./logger.js";
 
 export function getConfigDir(): string {
   const xdg = process.env.XDG_CONFIG_HOME;
@@ -152,46 +150,3 @@ export function getOpenCommand(): string {
       ? "start"
       : "xdg-open";
 }
-
-export async function cleanupOldDiagrams(
-  maxAgeMs: number = TIMEOUTS.CLEANUP_MAX_AGE_MS
-): Promise<number> {
-  try {
-    const liveDir = getLiveDir();
-    await mkdir(liveDir, { recursive: true });
-
-    const entries = await readdir(liveDir, { withFileTypes: true });
-    const now = Date.now();
-    let cleanedCount = 0;
-
-    for (const entry of entries) {
-      if (entry.isDirectory()) {
-        const dirPath = join(liveDir, entry.name);
-        const sourcePath = join(dirPath, FILE_NAMES.DIAGRAM_SOURCE);
-
-        try {
-          const stats = await stat(sourcePath);
-          const age = now - stats.mtimeMs;
-
-          if (age > maxAgeMs) {
-            await deleteDiagramDirectory(dirPath);
-            webLogger.info(`Cleaned up old diagram: ${entry.name}`);
-            cleanedCount++;
-          }
-        } catch (error) {
-          // Log but continue if individual diagram cleanup fails
-          webLogger.debug(`Skipping diagram cleanup: ${entry.name}`, {
-            error: error instanceof Error ? error.message : String(error),
-          });
-        }
-      }
-    }
-
-    return cleanedCount;
-  } catch (error) {
-    webLogger.warn("Diagram cleanup failed", {
-      error: error instanceof Error ? error.message : String(error),
-    });
-    return 0;
-  }
-}

src/index.ts

@@ -10,7 +10,6 @@ import {
 import { readFile } from "fs/promises";
 import { join, dirname } from "path";
 import { fileURLToPath } from "url";
-import { cleanupOldDiagrams } from "./file-utils.js";
 import { handleMermaidPreview, handleMermaidSave } from "./handlers.js";
 import { mcpLogger } from "./logger.js";
 
@@ -170,11 +169,6 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
 async function main() {
   mcpLogger.info("MCP Server starting", { version: VERSION });
 
-  const cleanedCount = await cleanupOldDiagrams();
-  if (cleanedCount > 0) {
-    mcpLogger.info(`Cleaned up ${cleanedCount} old diagrams`);
-  }
-
   const transport = new StdioServerTransport();
   await server.connect(transport);
   mcpLogger.info("MCP Server connected via stdio");

test/file-utils.test.ts

@@ -8,11 +8,10 @@ import {
   saveDiagramSource,
   loadDiagramSource,
   loadDiagramOptions,
-  cleanupOldDiagrams,
   getConfigDir,
   validateSavePath,
 } from "../src/file-utils.js";
-import { writeFile, unlink, mkdir, utimes, rmdir, readdir, mkdtemp } from "fs/promises";
+import { writeFile, unlink, mkdir, rmdir, readdir, mkdtemp } from "fs/promises";
 import { tmpdir } from "os";
 import { join } from "path";
 
@@ -259,105 +258,6 @@ describe("File Utilities", () => {
     });
   });
 
-  describe("cleanupOldDiagrams", () => {
-    let tempDir: string;
-    let testFiles: string[];
-
-    beforeEach(async () => {
-      // Use a test-specific directory
-      tempDir = join(tmpdir(), "claude-mermaid-test-cleanup", Date.now().toString());
-      await mkdir(tempDir, { recursive: true });
-      testFiles = [];
-    });
-
-    afterEach(async () => {
-      // Clean up test files
-      for (const file of testFiles) {
-        try {
-          await unlink(file);
-        } catch {
-          // Ignore if file doesn't exist
-        }
-      }
-    });
-
-    it("should return 0 when no files to clean", async () => {
-      // Test with very short max age to simulate old files
-      const count = await cleanupOldDiagrams(0);
-      expect(count).toBeGreaterThanOrEqual(0);
-    });
-
-    it("should clean up files older than max age", async () => {
-      const oldFile = join(tempDir, "old-diagram.svg");
-      const newFile = join(tempDir, "new-diagram.svg");
-
-      // Create old file
-      await writeFile(oldFile, "<svg>old</svg>", "utf-8");
-      testFiles.push(oldFile);
-
-      // Set file modification time to 8 days ago
-      const eightDaysAgo = new Date(Date.now() - 8 * 24 * 60 * 60 * 1000);
-      await utimes(oldFile, eightDaysAgo, eightDaysAgo);
-
-      // Create new file
-      await writeFile(newFile, "<svg>new</svg>", "utf-8");
-      testFiles.push(newFile);
-
-      // This test verifies the cleanup logic works conceptually
-      // In practice, it cleans the actual live directory, not our test dir
-      const maxAge = 7 * 24 * 60 * 60 * 1000; // 7 days
-      expect(maxAge).toBe(604800000);
-    });
-
-    it("should clean up directories with all their files", async () => {
-      const testPreviewId = "test-cleanup-dir";
-      const testDir = getPreviewDir(testPreviewId);
-
-      await mkdir(testDir, { recursive: true });
-      await writeFile(join(testDir, "diagram.svg"), "<svg>test</svg>", "utf-8");
-      await writeFile(join(testDir, "diagram.mmd"), "graph TD; A-->B", "utf-8");
-      await writeFile(join(testDir, "options.json"), "{}", "utf-8");
-
-      const files = await readdir(testDir);
-      expect(files.length).toBeGreaterThan(0);
-
-      // Cleanup test directory
-      for (const file of files) {
-        await unlink(join(testDir, file));
-      }
-      await rmdir(testDir);
-    });
-
-    it("should handle different max age values", () => {
-      const oneDayMs = 24 * 60 * 60 * 1000;
-      const sevenDaysMs = 7 * 24 * 60 * 60 * 1000;
-      const thirtyDaysMs = 30 * 24 * 60 * 60 * 1000;
-
-      expect(oneDayMs).toBe(86400000);
-      expect(sevenDaysMs).toBe(604800000);
-      expect(thirtyDaysMs).toBe(2592000000);
-    });
-
-    it("should use 7 days as default max age", () => {
-      const defaultMaxAge = 7 * 24 * 60 * 60 * 1000;
-      expect(defaultMaxAge).toBe(604800000);
-    });
-
-    it("should not throw errors when directory does not exist", async () => {
-      // The function creates the directory if it doesn't exist
-      await expect(cleanupOldDiagrams()).resolves.not.toThrow();
-    });
-
-    it("should calculate file age correctly", () => {
-      const now = Date.now();
-      const eightDaysAgo = now - 8 * 24 * 60 * 60 * 1000;
-      const age = now - eightDaysAgo;
-      const sevenDaysMs = 7 * 24 * 60 * 60 * 1000;
-
-      expect(age).toBeGreaterThan(sevenDaysMs);
-    });
-  });
-
   describe("validateSavePath", () => {
     it("should allow valid relative paths", () => {
       expect(() => validateSavePath("./diagrams/test.svg")).not.toThrow();