Skip to content

fix(factory): Fix deprecated glob import that prevents using from code after glob upgrade #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(factory): Fix deprecated glob import that prevents using from code after glob upgrade #1981

merged 1 commit into from
Jun 4, 2024

Conversation

gallayl
Copy link
Contributor

@gallayl gallayl commented Jun 2, 2024 •
edited by github-actions bot
Loading

After updating glob to ^10.x.x, named exports where removed
There was 1 global import left in the factory that prevented the generation from code-level with the following stack:

There was an error generating schema from ./src/models/config/*.ts TypeError: glob.sync is not a function
    at createProgram (file:///home/runner/work/pi-rat/pi-rat/node_modules/ts-json-schema-generator/dist/factory/program.js:51:1[6](https://github.com/furystack/pi-rat/actions/runs/9336662958/job/25697493845?pr=57#step:7:7))
    at createGenerator (file:///home/runner/work/pi-rat/pi-rat/node_modules/ts-json-schema-generator/dist/factory/generator.js:8:21)
    at file:///home/runner/work/pi-rat/pi-rat/common/dist/bin/create-schemas.js:92:28
    at Array.map (<anonymous>)
    at exec (file:///home/runner/work/pi-rat/pi-rat/common/dist/bin/create-schemas.js:8[7](https://github.com/furystack/pi-rat/actions/runs/9336662958/job/25697493845?pr=57#step:7:8):55)
    at file:///home/runner/work/pi-rat/pi-rat/common/dist/bin/create-schemas.js:105:1
    at ModuleJob.run (node:internal/modules/esm/module_job:222:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:316:24)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:123:5)

This little PR fixes the invalid import

Version

Published prerelease version: v2.3.0-next.5

Changelog

🎉 This release contains work from a new contributor! 🎉

Thank you, Lajos (@gallayl), for all your work!

🚀 Enhancement

🐛 Bug Fix

  • fix(factory): Fix deprecated glob import that prevents using from code after glob upgrade #1981 (@gallayl)
  • fix: Unknown type "undefined" when using generics without base type #1978 (@arthurfiorette)

🔩 Dependency Updates

Authors: 4

@gallayl gallayl mentioned this pull request Jun 2, 2024
Merged
@domoritz domoritz merged commit 3b85daf into vega:next Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

🚀 PR was released in v2.3.0 🚀

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease labels Jun 5, 2024
@Graysonbarton Graysonbarton mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gallayl @domoritz