fix(SimpCity): Update how filenames are created during download

Author: vegidio

internal/extractors/simpcity/api.go

@@ -35,8 +35,8 @@ func getThread(id string, startPage, maxPages int, headers map[string]string) <-
 			return
 		}
 
-		name := doc.Find("h1.p-title-value").Contents().Not("a, span").Text()
-		name = strings.TrimSpace(name)
+		title := doc.Find("h1.p-title-value").Contents().Not("a, span").Text()
+		title = strings.TrimSpace(title)
 
 		pagesStr := doc.Find("li.pageNav-page > a").Last().Text()
 		pagesNum, err := strconv.Atoi(pagesStr)
@@ -71,7 +71,7 @@ func getThread(id string, startPage, maxPages int, headers map[string]string) <-
 			}
 
 			pDoc.Find("div.message-cell--main").Each(func(i int, q *goquery.Selection) {
-				post, postErr := parsePost(id, name, q)
+				post, postErr := parsePost(id, title, q)
 
 				if postErr != nil {
 					out <- types.Result[Post]{Err: postErr}
@@ -85,7 +85,7 @@ func getThread(id string, startPage, maxPages int, headers map[string]string) <-
 	return out
 }
 
-func parsePost(id, name string, query *goquery.Selection) (*Post, error) {
+func parsePost(id, title string, query *goquery.Selection) (*Post, error) {
 	attachments := make([]Attachment, 0)
 	timeS := query.Find("time.u-dt")
 	published := time.Now()
@@ -114,7 +114,7 @@ func parsePost(id, name string, query *goquery.Selection) (*Post, error) {
 	return &Post{
 		Id:          id,
 		Url:         postUrl,
-		Name:        name,
+		Title:       title,
 		Attachments: attachments,
 		Published:   published,
 	}, nil

internal/extractors/simpcity/main.go

@@ -195,9 +195,9 @@ func (s *SimpCity) dataToMedia(post Post, sourceName string) <-chan types.Media
 
 		for _, attachment := range post.Attachments {
 			media := types.NewMedia(attachment.ThumbUrl, types.SimpCity, map[string]interface{}{
-				"id":      post.Id,
+				"name":    post.Id,
 				"url":     post.Url,
-				"name":    post.Name,
+				"title":   post.Title,
 				"source":  strings.ToLower(sourceName),
 				"created": post.Published,
 			}, headers)

internal/extractors/simpcity/types.go

@@ -5,7 +5,7 @@ import "time"
 type Post struct {
 	Id          string
 	Url         string
-	Name        string
+	Title       string
 	Attachments []Attachment
 	Published   time.Time
 }

tests/simpcity_test.go

@@ -40,7 +40,8 @@ func TestSimpCity_QueryThread(t *testing.T) {
 	assert.Equal(t, NumberOfPosts, len(resp.Media))
 	assert.Equal(t, "https://simpcity.cr/attachments/1215x1688_7ec0a1bb6b3e911e892e54556be53825-jpg.2063/", resp.Media[0].Url)
 	assert.Equal(t, "thread", resp.Media[0].Metadata["source"])
-	assert.Equal(t, "Jessica Nigri", resp.Media[0].Metadata["name"])
+	assert.Equal(t, "jessica-nigri.9946", resp.Media[0].Metadata["name"])
+	assert.Equal(t, "Jessica Nigri", resp.Media[0].Metadata["title"])
 }
 
 func TestSimpCity_QueryThread_Page45(t *testing.T) {
@@ -75,6 +76,7 @@ func TestSimpCity_QueryThread_Page45(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t, NumberOfPosts, len(resp.Media))
 	assert.Equal(t, "thread", resp.Media[0].Metadata["source"])
-	assert.Equal(t, "Jessica Nigri", resp.Media[0].Metadata["name"])
+	assert.Equal(t, "jessica-nigri.9946", resp.Media[0].Metadata["name"])
+	assert.Equal(t, "Jessica Nigri", resp.Media[0].Metadata["title"])
 	assert.True(t, exists)
 }