Skip to content

Improvements #6

@Draykee

Description

@Draykee

While I'm trying to get my own project running it's a bit too much work to directly contribute back my work.
So I at least want to maintain a list of things that need to be updated and I can do that once I'm done with my own challenges.

Things to update that everyone can use

  • Add .dockerignore and other "ignore" files for eslint
  • Update dependencies to latest vendure version (and therefore also all peer dependencies)
  • Update .Dockerfiles and share my size reduction improvements
  • Add tools script to build a docker image (since the command is pretty long otherewise)
  • Add script to add vendure plus repository (+ add .npmrc to gitignore)
  • Update prettier/eslint config (optional?)
  • Add docker-compose.yml file to create local dev environment

Things I had to do, but I'm not sure if everyone needs:

  • I had to add a scalar type for ID because otherwise I get internal type missmatches
//tools/executors/codegen/generatePluginTypesImpl.ts

const generatedFiles = await generate(
        {
            config: {
                strict: true,
                maybeValue: 'T',
                deprecatedFieldsWithReason: true,
                inputValueDeprecation: true,
                namingConvention: {
                    enumValues: 'keep',
                },
+                scalars: {
+                 ID: 'string | number',
+                },
            },
            generates,
        },
        true,
    );

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions